raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-25 20:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
e6e4e014dc95da76a6d96cea21fa2fa45380cf21
openfoodnetwork/app/models/spree
History
Neal Chambers c3c4486d0c Safely autocorrect Style/RedundantStringEscape 
Inspecting 1513 files
..........................................................................................................................................................................................................................................................................................................................C...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...........................................................................................................

Offenses:

app/models/spree/calculator.rb:31:48: C: [Corrected] Style/RedundantStringEscape: Redundant escape of / inside string literal.
      self.class.name.titleize.gsub("Calculator\/", "")
                                               ^^
spec/controllers/spree/admin/shipping_methods_controller_spec.rb:40:78: C: [Corrected] Style/RedundantStringEscape: Redundant escape of ' inside string literal.
        params[:shipping_method][:calculator_attributes][shipping_amount] = "\'20.0'"
                                                                             ^^
spec/system/admin/enterprise_fees_spec.rb:82:78: C: [Corrected] Style/RedundantStringEscape: Redundant escape of ' inside string literal.
    fill_in("#{prefix}_calculator_attributes_preferred_flat_percent", with: "\'20.0'")
                                                                             ^^
spec/system/admin/enterprise_fees_spec.rb:140:42: C: [Corrected] Style/RedundantStringEscape: Redundant escape of ' inside string literal.
        'preferred_flat_percent', with: "\'20.0'"
                                         ^^

1513 files inspected, 4 offenses detected, 4 offenses corrected
2023-11-17 09:03:32 +09:00
..
gateway
Delete Bogus Gateway Files
2023-11-07 11:19:23 +09:00
order
Recalculate voucher voucher adjusment when needed
2023-10-20 16:49:21 +11:00
payment
Add Order completion after capturing event
2023-10-29 21:58:03 +01:00
payment_method
Add Order completion after capturing event
2023-10-29 21:58:03 +01:00
preferences
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
stock
Safely autocorrect Style/RedundantReturn
2023-11-17 09:00:50 +09:00
ability.rb
Remove associated abilities
2023-08-08 11:36:31 +01:00
address.rb
Revert Complicated Rails/HasManyOrHasOneDependent Errors
2023-10-06 10:58:49 +09:00
adjustment.rb
Fix Rails/HasManyOrHasOneDependent with nil
2023-10-06 10:58:49 +09:00
app_configuration.rb
hide agree to the ToS when not ToS file is set
2023-08-22 10:22:26 +01:00
asset.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
calculator.rb
Safely autocorrect Style/RedundantStringEscape
2023-11-17 09:03:32 +09:00
country.rb
Fix Rails/HasManyOrHasOneDependent with Destroy
2023-10-06 10:58:49 +09:00
credit_card.rb
Add Order completion after capturing event
2023-10-29 21:58:03 +01:00
gateway.rb
Remove Deprecated delegate_belongs_to
2023-09-26 09:50:08 +09:00
image.rb
Rescue ImageMagick errors
2023-07-31 17:21:49 +01:00
inventory_unit.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
item_adjustments.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
line_item.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
log_entry.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
order_contents.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
order_inventory.rb
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
order.rb
Safely autocorrect Style/RedundantStringEscape
2023-11-17 09:03:32 +09:00
payment_method.rb
Fix Rails/HasManyOrHasOneDependent with Destroy
2023-10-06 10:58:49 +09:00
payment.rb
Apply Changes Suggested by Code Review
2023-10-06 10:58:49 +09:00
paypal_express_checkout.rb
Add ApplicationRecord for customisations
2021-04-15 15:59:03 +10:00
preference.rb
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
price.rb
Mark fields as changed if they contain unsaved values.
2023-10-24 15:21:14 +11:00
product_property.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
product.rb
Only validate an image if it has been changed
2023-10-11 10:12:52 +11:00
property.rb
Fix Rails/HasManyOrHasOneDependent with Destroy
2023-10-06 10:58:49 +09:00
return_authorization.rb
Fix deleting of return_authorizations
2023-10-06 10:58:49 +09:00
role.rb
Remove Spree.user_class
2021-12-10 18:18:20 +00:00
shipment.rb
Fix Rails/HasManyOrHasOneDependent with Destroy
2023-10-06 10:58:49 +09:00
shipping_category.rb
Fix Rails/HasManyOrHasOneDependent with nullify
2023-10-06 10:58:49 +09:00
shipping_method_category.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
shipping_method.rb
Safely autocorrect Style/RedundantRegexpArgument
2023-11-17 08:59:27 +09:00
shipping_rate.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
state_change.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
state.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
stock_item.rb
Revert Complicated Rails/HasManyOrHasOneDependent Errors
2023-10-06 10:58:49 +09:00
stock_location.rb
Fix Style/HashSyntax
2023-09-13 16:45:00 +09:00
stock_movement.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
tax_category.rb
Add ApplicationRecord for customisations
2021-04-15 15:59:03 +10:00
tax_rate.rb
Revert Complicated Rails/HasManyOrHasOneDependent Errors
2023-10-06 10:58:49 +09:00
taxon.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
taxonomy.rb
Fix Rails/HasManyOrHasOneDependent with nullify
2023-10-06 10:58:49 +09:00
tokenized_permission.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
user.rb
Fix Rails/HasManyOrHasDependent with restrict_with_exception
2023-10-06 10:58:49 +09:00
variant.rb
Mark fields as changed if they contain unsaved values.
2023-10-24 15:21:14 +11:00
zone_member.rb
Declare old belongs_to default on remaining models
2023-08-11 10:14:43 +10:00
zone.rb
Safely autocorrect Rails/WhereNot
2023-08-20 12:33:43 +09:00