mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-25 20:46:48 +00:00
e2b6199f26
We're passing the `id` key twice, and with different value, resulting in
warnings like:
> /path/to/app/views/producers/index.html.haml:27: warning: key :id is duplicated and overwritten on line 31
Use only the latest value passed to remove the warning.
##### Before
```
$ bundle exec rspec -e "displays in an iframe" -e "logging in with a redirect set"
(...)
Run options: include {:full_description=>/(?-mix:displays\ in\ an\ iframe)|(?-mix:logging\ in\ with\ a\ redirect\ set)/}
Capybara starting Puma...
* Version 6.5.0, codename: Sky's Version
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:50292
/path/to/app/views/producers/index.html.haml:27: warning: key :id is duplicated and overwritten on line 31
./path/to/app/views/groups/show.html.haml:68: warning: key :id is duplicated and overwritten on line 72
Modal window with text `Unable to load map. Please check your browser settings and allow 3rd party cookies for this website.` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
.
Finished in 4.54 seconds (files took 4.04 seconds to load)
2 examples, 0 failures
```
##### After
```
$ bundle exec rspec -e "displays in an iframe" -e "logging in with a redirect set"
(...)
Run options: include {:full_description=>/(?-mix:displays\ in\ an\ iframe)|(?-mix:logging\ in\ with\ a\ redirect\ set)/}
Capybara starting Puma...
* Version 6.5.0, codename: Sky's Version
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:50256
.Modal window with text `Unable to load map. Please check your browser settings and allow 3rd party cookies for this website.` has been opened, but you didn't wrap your code into (`accept_prompt` | `dismiss_prompt` | `accept_confirm` | `dismiss_confirm` | `accept_alert`), accepting by default
.
Finished in 4.17 seconds (files took 4.1 seconds to load)
2 examples, 0 failures
```
40 lines
1.3 KiB
Plaintext
40 lines
1.3 KiB
Plaintext
- content_for(:title) do
|
|
= t :producers_title
|
|
|
|
- content_for :scripts do
|
|
= render partial: "shared/google_maps_js"
|
|
|
|
- content_for :injection_data do
|
|
- cache @enterprises do
|
|
= inject_enterprises(@enterprises)
|
|
- cache(*CacheService::FragmentCaching.ams_all_taxons) do
|
|
= inject_taxons
|
|
- cache(*CacheService::FragmentCaching.ams_all_properties) do
|
|
= inject_properties
|
|
|
|
.producers{"ng-controller" => "EnterprisesCtrl", "ng-cloak" => true}
|
|
.row
|
|
.small-12.columns.pad-top
|
|
%h1
|
|
= t :producers_headline
|
|
|
|
= render partial: "shared/components/enterprise_search"
|
|
= render partial: "producers/filters"
|
|
|
|
.row
|
|
.small-12.columns
|
|
.active_table
|
|
%producer.active_table_node.row.animate-repeat{
|
|
"ng-repeat" => "producer in filteredEnterprises = (Enterprises.producers | searchEnterprises:query | taxons:activeTaxons | properties:activeProperties:'supplied_properties')",
|
|
"ng-controller" => "ProducerNodeCtrl",
|
|
"ng-class" => "{'closed' : !open(), 'open' : open(), 'inactive' : !producer.active}",
|
|
id: "{{producer.hash}}"}
|
|
|
|
.small-12.columns
|
|
= render partial: 'producers/skinny'
|
|
= render partial: 'producers/fat'
|
|
|
|
= render partial: 'shared/components/enterprise_no_results'
|
|
|
|
= render partial: "shared/footer"
|