mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-24 20:36:49 +00:00
44fe3de732
There's no point of using Code Climate if most of its checks are disabled. Now it scores our codebase with an A and reports just 2 code smells, 64 duplications and 14 other issues. That couldn't farther from reality. If we care about the architecture and maintainability of our app, this is a must. To transition towards enabling all default checks, I started with scss-lint, duplication and method-complexity. This doesn't mean will have to fix them all straight away as we'll add the current violations to the `.rubocop_todo.yml` but it'll point us the parts where we should focus our efforts.
39 lines
769 B
YAML
39 lines
769 B
YAML
version: "2"
|
|
plugins:
|
|
rubocop:
|
|
enabled: true
|
|
channel: "rubocop-0-55"
|
|
scss-lint:
|
|
enabled: true
|
|
duplication:
|
|
enabled: true
|
|
exclude_patterns:
|
|
- "db/**"
|
|
- "config/initializers/active_record_postgresql_referential_integrity_patch.rb"
|
|
checks:
|
|
argument-count:
|
|
enabled: false
|
|
complex-logic:
|
|
enabled: true
|
|
file-lines:
|
|
enabled: true
|
|
method-complexity:
|
|
enabled: true
|
|
method-count:
|
|
enabled: false
|
|
method-lines:
|
|
enabled: false
|
|
nested-control-flow:
|
|
enabled: true
|
|
return-statements:
|
|
enabled: true
|
|
similar-code:
|
|
enabled: true
|
|
identical-code:
|
|
enabled: true
|
|
exclude_patterns:
|
|
- "spec/**/*"
|
|
- "vendor/**/*"
|
|
- "app/assets/javascripts/shared/*"
|
|
- "app/assets/javascripts/jquery-migrate-1.0.0.js"
|