raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-05 22:26:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
a0999f5d58370e1409f48bcd8849d4bb413c73d8
openfoodnetwork/app/models
History
Matt-Yorkley a0999f5d58 Check #persisted? before calling #touch 
Rails 4 now throws a fatal error if calling #touch on an object that hasn't been saved yet: c63cfc8722/activerecord/lib/active_record/persistence.rb (L957)

Fixes:

  41) Stock::Package#shipping_methods does not return shipping methods not used by the package's order distributor
      Failure/Error: distributors.each(&:touch)

      ActiveRecord::ActiveRecordError:
        can not touch on a new record object
      # ./app/models/spree/shipping_method_decorator.rb:81:in `touch_distributors'
      # ./spec/models/stock/package_spec.rb:39:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:17:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:32:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:7:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:44:in `block (3 levels) in <module:Stock>'

  42) Stock::Package#shipping_categories returns shipping categories that are not shipping categories of the order's products
      Failure/Error: distributors.each(&:touch)

      ActiveRecord::ActiveRecordError:
        can not touch on a new record object
      # ./app/models/spree/shipping_method_decorator.rb:81:in `touch_distributors'
      # ./spec/models/stock/package_spec.rb:39:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:17:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:32:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:7:in `block (2 levels) in <module:Stock>'
      # ./spec/models/stock/package_spec.rb:50:in `block (3 levels) in <module:Stock>'
2020-03-01 18:40:15 +01:00
..
calculator
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
concerns
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
preference_sections
Replace connect-learn banner with custom content
2019-05-08 11:38:49 +10:00
product_import
Replace deprecated arguments in #find_by
2020-01-15 16:39:33 +01:00
spree
Check #persisted? before calling #touch
2020-03-01 18:40:15 +01:00
stock
Fix typo in package.rb
2019-06-15 20:45:57 +01:00
tag_rule
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
.gitkeep
new rails 3.1.4 app
2012-03-27 10:10:26 +11:00
adjustment_metadata.rb
Add AdjustmentMetadata, for holding info about enterprise fee adjustments at time of creation
2013-08-12 10:00:35 +10:00
column_preference_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
column_preference.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
content_configuration.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
coordinator_fee.rb
Remove product cache
2019-10-18 21:15:11 +01:00
customer.rb
Update deprecated #find_by_* methods
2020-02-22 11:06:51 +00:00
distributor_shipping_method.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
enterprise_fee_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
enterprise_fee.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
enterprise_group.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
enterprise_relationship_permission.rb
Fix default_scope deprecated syntax
2020-01-15 12:57:38 +01:00
enterprise_relationship.rb
Update deprecated #find_or_initialize_by_* methods
2020-02-22 11:06:51 +00:00
enterprise_role.rb
Change all model scopes without a callable object to use a proc
2019-05-28 15:55:13 +01:00
enterprise_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
enterprise.rb
Fix Enterprise validation and factory so that users are added after the validation
2020-02-22 12:06:33 +00:00
exchange_fee.rb
Remove product cache
2019-10-18 21:15:11 +01:00
exchange_variant.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
exchange.rb
Update deprecated #scoped calls
2020-02-22 11:06:51 +00:00
inventory_item.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
model_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
order_cycle_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
order_cycle.rb
Update deprecated #scoped calls
2020-02-22 11:06:51 +00:00
order_updater.rb
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
producer_property.rb
Update deprecated #find_by_* methods
2020-02-22 11:06:51 +00:00
proxy_order.rb
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
schedule.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
stripe_account.rb
Allow destruction of StripeAccounts even if deauthorise request fails
2017-09-23 14:58:35 +10:00
subscription_line_item.rb
Fix default_scope deprecated syntax
2020-01-15 12:57:38 +01:00
subscription.rb
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
tag_rule.rb
Remove attr_accessible declarations
2020-02-22 14:03:16 +01:00
variant_override_set.rb
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
variant_override.rb
Fix default_scope deprecated syntax
2020-01-15 12:57:38 +01:00