Matt-Yorkley 72c6935ff8 Fix handling of empty order cycle params ...

This guard clause was returning an instance of an unpermitted Params object (containing a blank hash) here, which was causing unexpected results in various places. Returning a blank hash explicitly resolved the issue.

Fixes:

4) Admin::OrderCyclesController create as a manager of a shop when creation is successful returns success: true and a valid edit path
     Failure/Error:
       @order_cycle_params ||= PermittedAttributes::OrderCycle.new(params).call.
         to_h.with_indifferent_access

     ActionController::UnfilteredParameters:
       unable to convert unpermitted parameters to hash
     # ./app/controllers/admin/order_cycles_controller.rb:245:in `order_cycle_params'
     # ./app/controllers/admin/order_cycles_controller.rb:44:in `create'
     # ./spec/support/controller_requests_helper.rb:49:in `process_action_with_route'
     # ./spec/support/controller_requests_helper.rb:27:in `spree_post'
     # ./spec/controllers/admin/order_cycles_controller_spec.rb:124:in `block (5 levels) in <module:Admin>'

2021-04-14 09:16:27 -07:00

..

assets

Merge pull request #7351 from Matt-Yorkley/dead-code-discount-order

2021-04-08 12:48:38 -07:00

controllers

Fix taxon error handling in Api::TaxonsController

2021-04-13 16:54:31 -07:00

helpers

Adapt routes and helpers to make view spec green

2021-04-13 16:54:32 -07:00

jobs

put Time.zone back

2021-04-04 12:27:46 -07:00

mailers

Fix showing soft-deleted products in producer mailer

2021-03-29 17:31:10 +01:00

models

Fix callback in Classification and update spec

2021-04-13 16:54:32 -07:00

queries

Fully qualify table columns in query object

2021-03-23 09:37:47 +01:00

serializers/api

Remove TagRule::DiscountOrder

2021-04-08 12:37:17 +01:00

services

Fix handling of empty order cycle params

2021-04-14 09:16:27 -07:00

validators

Add validator for integer arrays

2019-02-08 21:26:36 +00:00

views

Adapt routes and helpers to make view spec green

2021-04-13 16:54:32 -07:00