raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-25 20:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
5f302f347a99dd4119decd97aaa66edaa1e7ef80
openfoodnetwork/app/services
History
David Cook fbbaf51522 Safely autocorrect Lint/SymbolConversion 
Inspecting 1530 files
.....................................................................................................................................................................................................................................................................................................................................................W.................................................................................................................................................................................................................................................W..........................................................................................................................................................................................................................................................W.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Offenses:

app/models/spree/preferences/preferable_class_methods.rb:73:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"preferred_#{name}" instead.
        "preferred_#{name}".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:77:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"preferred_#{name}=" instead.
        "preferred_#{name}=".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:81:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"prefers_#{name}?" instead.
        "prefers_#{name}?".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:85:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"prefers_#{name}=" instead.
        "prefers_#{name}=".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:89:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"preferred_#{name}_default" instead.
        "preferred_#{name}_default".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:93:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"preferred_#{name}_type" instead.
        "preferred_#{name}_type".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/spree/preferences/preferable_class_methods.rb:97:9: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"preferred_#{name}_description" instead.
        "preferred_#{name}_description".to_sym
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/services/sets/product_set.rb:121:28: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"variant_#{error.attribute}" instead.
        product.errors.add("variant_#{error.attribute}".to_sym, error.message)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/spree/core/environment_extension.rb:11:24: W: [Corrected] Lint/SymbolConversion: Unnecessary symbol conversion; use :"#{name}=" instead.
        create_method( "#{name}=".to_sym ) { |val|
                       ^^^^^^^^^^^^^^^^^

1530 files inspected, 9 offenses detected, 9 offenses corrected
2024-01-10 09:21:43 +11:00
..
checkout
Replace references to :split_checkout translation keys with :checkout in views, controllers, etc.
2023-12-01 12:37:13 +00:00
permissions
Simplify further
2023-05-05 15:34:23 +10:00
permitted_attributes
Use instance default locale as the default locale for a new user
2023-09-05 01:00:35 +01:00
sets
Safely autocorrect Lint/SymbolConversion
2024-01-10 09:21:43 +11:00
shop
require tag_rule_applicator on Shop::OrderCyclesList
2024-01-03 11:59:21 +01:00
variant_units
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
address_geocoder.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
cache_service.rb
Safely autocorrect Naming/BlockForwarding
2023-07-30 21:29:19 +09:00
cap_quantity.rb
Safely autocorrect Rails/WhereNot
2023-08-20 12:33:43 +09:00
cart_service.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
content_sanitizer.rb
Fix Rails/Blank
2023-08-17 16:42:46 +09:00
content_scrubber.rb
Removes empty <p> tags from product description
2023-03-31 11:37:30 +02:00
create_order_cycle.rb
Safely autocorrect Rails/DurationArithmetic
2023-08-01 22:50:21 +09:00
current_order_locker.rb
Safely autocorrect Naming/BlockForwarding
2023-07-30 21:29:19 +09:00
customer_order_cancellation.rb
When an order is cancelled by a customer send an email to the shop.
2021-01-29 11:23:05 +00:00
customer_syncer.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
default_address_updater.rb
Customer can be nil if first time they checkout
2023-02-09 17:11:11 +01:00
default_country.rb
Cache default country simply in memory
2024-01-04 13:45:36 +11:00
default_shipping_category.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
default_stock_location.rb
Remove unused method loading default country
2022-11-02 16:21:15 +11:00
embedded_page_service.rb
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
exchange_products_renderer.rb
Safely autocorrect Style/QuotedSymbols
2023-11-10 09:13:57 +09:00
exchange_variant_bulk_updater.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
exchange_variant_deleter.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
file_path_sanitizer.rb
Style fix
2023-05-18 10:07:52 +10:00
image_importer.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
invoice_data_generator.rb
replace attr with attr_reader
2023-06-18 21:03:13 +02:00
invoice_renderer.rb
remove legacy template (used when invoice feature enable)
2023-10-30 19:43:57 +01:00
line_item_syncer.rb
Revert to false so strings can be mutated in this class
2021-06-17 23:07:54 +01:00
mail_configuration.rb
Remove unused feature to intercept emails
2023-04-26 13:50:31 +10:00
order_adjustments_fetcher.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
order_available_payment_methods.rb
require tag_rule_applicator as it's not loaded automatically on OrderAvailableShippingMethods & OrderAvailablePaymentMethods
2024-01-03 12:08:26 +01:00
order_available_shipping_methods.rb
require tag_rule_applicator as it's not loaded automatically on OrderAvailableShippingMethods & OrderAvailablePaymentMethods
2024-01-03 12:08:26 +01:00
order_capture_service.rb
Extract order capturing to OrderCaptureService
2023-05-21 00:15:32 +01:00
order_cart_reset.rb
Merge pull request #9710 from mkllnk/9002-customer-association-updates
2022-09-30 16:36:01 +02:00
order_checkout_restart.rb
Rename order.update! to order.update_order! and adjustment.update! to adjustment.update_adjustment!
2021-05-19 09:54:22 -07:00
order_cycle_clone.rb
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
order_cycle_distributed_products.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
order_cycle_distributed_variants.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
order_cycle_form.rb
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
order_cycle_warning.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
order_cycle_webhook_service.rb
Also send webhook payloads for distributor owners
2023-03-07 15:38:50 +11:00
order_data_masker.rb
Update usages of old preference getters and setters
2021-11-04 11:48:30 +00:00
order_factory.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
order_fees_handler.rb
Don't tax fees before payment state
2023-06-14 10:19:30 +01:00
order_invoice_comparator.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
order_invoice_generator.rb
update the invoice number calculation
2023-12-08 13:33:36 +01:00
order_payment_finder.rb
Use OrderPaymentFinder methods instead of payments.last and payments.pending.last
2020-04-23 16:08:10 +10:00
order_syncer.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
order_tax_adjustments_fetcher.rb
fix linter issues
2023-06-18 21:03:13 +02:00
order_update_issues.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
order_workflow.rb
Extract before_payment_state? method
2023-06-14 10:19:30 +01:00
orders_bulk_cancel_service.rb
Update app/services/orders_bulk_cancel_service.rb
2023-05-26 10:33:23 +01:00
path_checker.rb
Fix menu indicator on bulk order page
2021-10-26 06:41:30 +09:00
paypal_items_builder.rb
Simplify filtering items with zero price
2021-02-24 12:39:10 +00:00
place_proxy_order.rb
Update Bugsnag error data
2022-10-19 17:36:52 +11:00
process_payment_intent.rb
Move order to completed whether it's current state is payment or confirmation
2023-06-13 10:14:09 +01:00
product_filters.rb
move product filter helper to a service
2020-08-21 10:29:07 +10:00
product_tag_rules_filterer.rb
Remove andand
2021-09-08 14:28:31 +01:00
products_renderer.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
recurring_payments.rb
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
search_orders.rb
Show incomplete orders when sorting by name
2023-08-25 16:15:11 +10:00
shops_list_service.rb
Load closed shops in a separate request on /shops page
2020-04-04 14:06:10 +02:00
stripe_payment_status.rb
pass payment to Stripe Validator instead of the status object
2021-09-08 12:26:56 -07:00
tax_rate_finder.rb
Update delegation and method chaining between product and tax_category
2023-07-31 09:23:20 +10:00
tax_rate_updater.rb
Wrap updates in a transaction block
2021-02-03 11:54:54 +00:00
terms_of_service.rb
hide agree to the ToS when not ToS file is set
2023-08-22 10:22:26 +01:00
trix_sanitizer.rb
Sanitize content when display it on shop
2023-09-04 15:46:54 +02:00
trix_scrubber.rb
Add horizontal rule to trix editor
2023-09-04 15:46:54 +02:00
unit_price.rb
rename unit_price.rb file
2021-03-25 08:51:15 -07:00
upload_sanitizer.rb
Revert to false so strings can be mutated in this class
2021-06-17 23:07:35 +01:00
url_generator.rb
Create UrlGenerator service
2022-01-15 13:21:09 +00:00
user_default_address_setter.rb
Remove andand
2021-09-08 14:28:31 +01:00
user_locale_setter.rb
Refactor UserLocaleSetter public methods
2020-07-04 10:15:35 +02:00
variant_deleter.rb
Simplify exchange variant callback and prefer delete over destroy
2023-05-19 11:26:33 +01:00
variant_overrides_indexed.rb
Improve naming of variables in VariantOverridesIndexed for readability
2020-04-13 22:24:25 +10:00
variants_stock_levels.rb
Use rubocop auto correct to add frozen string literal to all files
2021-06-17 23:07:26 +01:00
voucher_adjustments_service.rb
Merge pull request #11543 from rioug/11364-Voucher-fix-tax-report
2023-10-01 02:09:33 +02:00
weights_and_measures.rb
update WeightsAndMeasures#scales_for_variant_unit to ignore available untis when needed
2023-11-13 09:59:14 +01:00