mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-24 20:36:49 +00:00
0fa73e3b02
The headers in the request were not being populated correctly in the test, so the #api_key method was not functioning as intended.
Fixes:
48) Api::BaseController cannot make a request to the API with an invalid API key
Failure/Error: expect(json_response).to eq( "error" => "Invalid API key (fake_key) specified." )
expected: {"error"=>"Invalid API key (fake_key) specified."}
got: {"products"=>[]}
(compared using ==)
Diff:
@@ -1,2 +1,2 @@
-"error" => "Invalid API key (fake_key) specified.",
+"products" => [],
# ./spec/controllers/api/base_controller_spec.rb:40:in `block (3 levels) in <top (required)>'
65 lines
1.9 KiB
Ruby
65 lines
1.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Api::BaseController do
|
|
render_views
|
|
controller(Api::BaseController) do
|
|
skip_authorization_check only: :index
|
|
|
|
def index
|
|
render text: { "products" => [] }.to_json
|
|
end
|
|
|
|
def spree_current_user; end
|
|
end
|
|
|
|
context "signed in as a user using an authentication extension" do
|
|
before do
|
|
allow(controller).to receive_messages try_spree_current_user:
|
|
double(email: "spree@example.com")
|
|
end
|
|
|
|
it "can make a request" do
|
|
api_get :index
|
|
expect(json_response).to eq( "products" => [] )
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
context "can make an anonymous request to the API" do
|
|
it "without an API key" do
|
|
api_get :index
|
|
expect(json_response["products"]).to eq []
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
context "cannot make a request to the API" do
|
|
it "with an invalid API key" do
|
|
request.headers["X-Spree-Token"] = "fake_key"
|
|
get :index, {}
|
|
expect(json_response).to eq( "error" => "Invalid API key (fake_key) specified." )
|
|
expect(response.status).to eq(401)
|
|
end
|
|
|
|
it "using an invalid token param" do
|
|
get :index, token: "fake_key"
|
|
expect(json_response).to eq( "error" => "Invalid API key (fake_key) specified." )
|
|
end
|
|
end
|
|
|
|
it 'handles exceptions' do
|
|
expect(subject).to receive(:authenticate_user).and_return(true)
|
|
expect(subject).to receive(:index).and_raise(Exception.new("no joy"))
|
|
get :index
|
|
expect(json_response).to eq( "exception" => "no joy" )
|
|
end
|
|
|
|
it 'handles record not found' do
|
|
expect(subject).to receive(:authenticate_user).and_return(true)
|
|
expect(subject).to receive(:index).and_raise(ActiveRecord::RecordNotFound.new)
|
|
get :index
|
|
expect(json_response).to eq( "error" => "The resource you were looking for could not be found." )
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|