mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-25 20:46:48 +00:00
Inspecting 1479 files
...................................................................................................................................................C..C.......................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................C.............................................................................................C...................................................................C.......................................................................................................................................................................C....................................................C.............C...........CC.........C......C.CC.C....................C........................................................
Offenses:
app/controllers/spree/users_controller.rb:36:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/spree/users_controller.rb:51:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/user_confirmations_controller.rb:27:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/models/enterprise.rb:117:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
validates :instagram,
^
spec/controllers/spree/credit_cards_controller_spec.rb:250:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:stored_credit_card, user_id: user.id,
^
spec/controllers/user_confirmations_controller_spec.rb:45:44: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
session[:confirmation_return_url] =
^
spec/factories/order_factory.rb:40:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
order.payments << build(:payment, amount: order.total,
^
spec/lib/reports/packing/packing_report_spec.rb:59:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/lib/reports/packing/packing_report_spec.rb:63:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/models/enterprise_spec.rb:521:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(Enterprise.supplying_variant_in([p1.variants.first,
^
spec/models/enterprise_spec.rb:906:77: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:enterprise_relationship, parent: distributor, child: supplier,
^
spec/services/products_renderer_spec.rb:22:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:product, name: "banana bread", primary_taxon_id: cakes.id,
^
spec/services/products_renderer_spec.rb:88:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:90:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:97:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
fruits_supplier.producer_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:99:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:109:93: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_conventional.id,
^
spec/services/products_renderer_spec.rb:111:94: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_banana_bread.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:113:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_cherries.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:115:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_doughnuts.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:117:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/support/request/stripe_stubs.rb:17:81: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def stub_payment_intent_get_request(response: {}, stripe_account_header: true,
^
spec/support/request/stripe_stubs.rb:172:6: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
{
^
spec/support/request/stripe_stubs.rb:175:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
object: "list",
^
spec/support/request/stripe_stubs.rb:176:25: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
has_more: false,
^
spec/system/admin/bulk_order_management_spec.rb:792:99: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it "displays only line items whose orders meet the date restriction criteria, when changed",
^
spec/system/admin/bulk_order_management_spec.rb:1071:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1121:82: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
shared_examples "display only group by information for selected variant" do
^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1143:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1166:12: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^
spec/system/admin/customers_spec.rb:18:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:customer, first_name: 'John', last_name: 'Doe', enterprise: managed_distributor1,
^
spec/system/admin/enterprise_fees_spec.rb:102:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Inherit From Product',
^
spec/system/admin/enterprise_fees_spec.rb:128:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Weight (per kg or lb)',
^
spec/system/admin/enterprise_fees_spec.rb:132:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per item)',
^
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:157:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:159:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per order)',
^
spec/system/admin/enterprise_fees_spec.rb:222:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:22:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:27:32: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("#admin-menu").click
^^^^^^^
spec/system/admin/flatpickr_spec.rb:32:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:34:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:41:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_cycles/complex_editing_spec.rb:74:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/complex_editing_spec.rb:110:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/list_spec.rb:147:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:160:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:188:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/simple_spec.rb:447:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).not_to have_selector(
^
spec/system/admin/order_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:207:30: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within(".modal") do
^
spec/system/admin/order_spec.rb:235:21: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
login_as_admin
^^
spec/system/admin/order_spec.rb:240:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:247:62: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
context "when using the cancel option in the dropdown" do
^^
spec/system/admin/order_spec.rb:248:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:299:53: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_content "Are you sure?"
^^^^^^^^
spec/system/admin/order_spec.rb:327:36: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("a.delete-item").click
^
spec/system/admin/order_spec.rb:401:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:405:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:598:59: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Resend Confirmation",
^
spec/system/admin/order_spec.rb:617:52: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Cancel Order",
^
spec/system/admin/order_spec.rb:633:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:674:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:735:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:762:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:778:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:780:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:796:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:807:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
# Since the order is completed, the price is not supposed to be updated
^
spec/system/admin/order_spec.rb:813:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:815:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:924:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:959:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:981:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^^
spec/system/admin/order_spec.rb:992:8: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:1002:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1479 files inspected, 81 offenses detected, 81 offenses corrected
207 lines
7.6 KiB
Ruby
207 lines
7.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'system_helper'
|
|
|
|
describe 'shipping methods' do
|
|
include WebHelper
|
|
include AuthenticationHelper
|
|
|
|
before :each do
|
|
@shipping_method = create(:shipping_method)
|
|
end
|
|
|
|
context "as a site admin" do
|
|
before(:each) do
|
|
login_as_admin
|
|
end
|
|
|
|
it "creating a shipping method owned by some distributors" do
|
|
# Given some distributors
|
|
distributor1 = create(:distributor_enterprise, name: 'Alice Farm Hub')
|
|
distributor2 = create(:distributor_enterprise, name: 'Bob Farm Shop')
|
|
|
|
# Shows appropriate fields when logged in as admin
|
|
visit spree.new_admin_shipping_method_path
|
|
expect(page).to have_field 'shipping_method_name'
|
|
expect(page).to have_field 'shipping_method_description'
|
|
expect(page).to have_select 'shipping_method_display_on'
|
|
expect(page).to have_css 'div#shipping_method_zones_field'
|
|
expect(page).to have_field 'shipping_method_require_ship_address_true', checked: true
|
|
|
|
# When I create a shipping method and set the distributors
|
|
fill_in 'shipping_method_name', with: 'Carrier Pidgeon'
|
|
check "shipping_method_distributor_ids_#{distributor1.id}"
|
|
check "shipping_method_distributor_ids_#{distributor2.id}"
|
|
check "shipping_method_shipping_categories_"
|
|
click_button 'Create'
|
|
|
|
expect(page).to have_no_button 'Create'
|
|
|
|
# Then the shipping method should have its distributor set
|
|
expect(flash_message).to include "Carrier Pidgeon", "successfully created!"
|
|
|
|
sm = Spree::ShippingMethod.last
|
|
expect(sm.name).to eq('Carrier Pidgeon')
|
|
expect(sm.distributors).to match_array [distributor1, distributor2]
|
|
end
|
|
|
|
it "deleting a shipping method" do
|
|
visit spree.admin_shipping_methods_path
|
|
|
|
accept_alert 'Are you sure?' do
|
|
page.find('a.delete-resource').click
|
|
end
|
|
expect(page).not_to have_content(@shipping_method)
|
|
expect(Spree::ShippingMethod.where(id: @shipping_method.id)).to be_empty
|
|
end
|
|
|
|
it "checking a single distributor is checked by default" do
|
|
first_distributor = Enterprise.first
|
|
visit spree.new_admin_shipping_method_path
|
|
expect(page).to have_field "shipping_method_distributor_ids_#{first_distributor.id}",
|
|
checked: true
|
|
end
|
|
|
|
it "checking more than a distributor displays no default choice" do
|
|
distributor1 = create(:distributor_enterprise, name: 'Alice Farm Shop')
|
|
distributor2 = create(:distributor_enterprise, name: 'Bob Farm Hub')
|
|
visit spree.new_admin_shipping_method_path
|
|
expect(page).to have_field "shipping_method_distributor_ids_#{distributor1.id}",
|
|
checked: false
|
|
expect(page).to have_field "shipping_method_distributor_ids_#{distributor2.id}",
|
|
checked: false
|
|
end
|
|
|
|
it "handle when updating calculator type for Weight to Flat Rate" do
|
|
visit spree.edit_admin_shipping_method_path(@shipping_method)
|
|
|
|
select2_select 'Weight (per kg or lb)', from: 'calc_type'
|
|
click_button 'Update'
|
|
|
|
select2_select 'Flat Rate (per item)', from: 'calc_type'
|
|
click_button 'Update'
|
|
|
|
expect(@shipping_method.reload.calculator_type).to eq("Calculator::PerItem")
|
|
end
|
|
|
|
it "handle when updating calculator type to 'None'" do
|
|
visit spree.edit_admin_shipping_method_path(@shipping_method)
|
|
|
|
select2_select 'None', from: 'calc_type'
|
|
click_button 'Update'
|
|
|
|
expect(@shipping_method.reload.calculator_type).to eq "Calculator::None"
|
|
end
|
|
end
|
|
|
|
context "as an enterprise user" do
|
|
let(:enterprise_user) { create(:user) }
|
|
let(:distributor1) { create(:distributor_enterprise, name: 'First Distributor') }
|
|
let(:distributor2) { create(:distributor_enterprise, name: 'Second Distributor') }
|
|
let(:distributor3) { create(:distributor_enterprise, name: 'Third Distributor') }
|
|
let(:shipping_method1) { create(:shipping_method, name: 'One', distributors: [distributor1]) }
|
|
let(:shipping_method2) {
|
|
create(:shipping_method, name: 'Two', distributors: [distributor1, distributor2])
|
|
}
|
|
let(:sm3) { create(:shipping_method, name: 'Three', distributors: [distributor3]) }
|
|
let(:shipping_category) { create(:shipping_category) }
|
|
|
|
before(:each) do
|
|
enterprise_user.enterprise_roles.build(enterprise: distributor1).save
|
|
enterprise_user.enterprise_roles.build(enterprise: distributor2).save
|
|
login_as enterprise_user
|
|
end
|
|
|
|
it "creating a shipping method", retry: 3 do
|
|
visit admin_enterprises_path
|
|
within("#e_#{distributor1.id}") { click_link 'Settings' }
|
|
within(".side_menu") do
|
|
click_link "Shipping Methods"
|
|
end
|
|
click_link 'Create One Now'
|
|
|
|
# Show the correct fields
|
|
expect(page).to have_field 'shipping_method_name'
|
|
expect(page).to have_field 'shipping_method_description'
|
|
expect(page).to have_select 'shipping_method_display_on'
|
|
expect(page).to have_css 'div#shipping_method_zones_field'
|
|
expect(page).to have_field 'shipping_method_require_ship_address_true', checked: true
|
|
|
|
# Auto-check default shipping category
|
|
expect(page).to have_field shipping_category.name, checked: true
|
|
|
|
fill_in 'shipping_method_name', with: 'Teleport'
|
|
|
|
check "shipping_method_distributor_ids_#{distributor1.id}"
|
|
find(:css, "tags-input .tags input").set "local\n"
|
|
within(".tags .tag-list") do
|
|
expect(page).to have_css '.tag-item', text: "local"
|
|
end
|
|
click_button "Create"
|
|
|
|
within ".flash-container" do
|
|
expect(page).to have_content 'Shipping Method "Teleport" has been successfully created!'
|
|
end
|
|
expect(page).to have_content "Editing Shipping Method"
|
|
|
|
expect(first('tags-input .tag-list ti-tag-item')).to have_content "local"
|
|
|
|
shipping_method = Spree::ShippingMethod.find_by(name: 'Teleport')
|
|
expect(shipping_method.distributors).to eq([distributor1])
|
|
expect(shipping_method.tag_list).to eq(["local"])
|
|
end
|
|
|
|
it "shows me only shipping methods I have access to" do
|
|
shipping_method1
|
|
shipping_method2
|
|
sm3
|
|
|
|
visit spree.admin_shipping_methods_path
|
|
|
|
expect(page).to have_content shipping_method1.name
|
|
expect(page).to have_content shipping_method2.name
|
|
expect(page).not_to have_content sm3.name
|
|
end
|
|
|
|
it "does not show duplicates of shipping methods" do
|
|
shipping_method1
|
|
shipping_method2
|
|
|
|
visit spree.admin_shipping_methods_path
|
|
|
|
expect(page).to have_selector 'td', text: 'Two', count: 1
|
|
end
|
|
|
|
it "shows me only shipping methods for the enterprise I select" do
|
|
shipping_method1
|
|
shipping_method2
|
|
|
|
visit admin_enterprises_path
|
|
within("#e_#{distributor1.id}") { click_link 'Settings' }
|
|
|
|
within(".side_menu") do
|
|
click_link "Shipping Methods"
|
|
end
|
|
|
|
expect(page).to have_content shipping_method1.name
|
|
expect(page).to have_content shipping_method2.name
|
|
|
|
expect(page).to have_checked_field "enterprise_shipping_method_ids_#{shipping_method2.id}"
|
|
expect(page).to have_checked_field "enterprise_shipping_method_ids_#{shipping_method1.id}"
|
|
|
|
click_link 'Enterprises'
|
|
within("#e_#{distributor2.id}") { click_link 'Settings' }
|
|
|
|
within(".side_menu") do
|
|
click_link "Shipping Methods"
|
|
end
|
|
|
|
expect(page).to have_content shipping_method1.name
|
|
expect(page).to have_content shipping_method2.name
|
|
|
|
expect(page).to have_checked_field "enterprise_shipping_method_ids_#{shipping_method2.id}"
|
|
expect(page).to have_unchecked_field "enterprise_shipping_method_ids_#{shipping_method1.id}"
|
|
end
|
|
end
|
|
end
|