Files
openfoodnetwork/spec/services/order_cycle_form_spec.rb
2023-04-04 09:30:36 +01:00

477 lines
19 KiB
Ruby

# frozen_string_literal: true
require 'spec_helper'
require 'order_management/subscriptions/proxy_order_syncer'
describe OrderCycleForm do
describe "save" do
describe "creating a new order cycle from params" do
let(:shop) { create(:enterprise) }
let(:order_cycle) { OrderCycle.new }
let(:form) { OrderCycleForm.new(order_cycle, params, shop.owner) }
context "when creation is successful" do
let(:params) { { name: "Test Order Cycle", coordinator_id: shop.id } }
it "returns true" do
expect do
expect(form.save).to be true
end.to change(OrderCycle, :count).by(1)
end
end
context "when creation fails" do
let(:params) { { name: "Test Order Cycle" } }
it "returns false" do
expect do
expect(form.save).to be false
end.to_not change(OrderCycle, :count)
end
end
end
describe "updating an existing order cycle from params" do
let(:shop) { create(:enterprise) }
let(:order_cycle) { create(:simple_order_cycle, name: "Old Name") }
let(:form) { OrderCycleForm.new(order_cycle, params, shop.owner) }
context "when update is successful" do
let(:params) { { name: "Test Order Cycle", coordinator_id: shop.id } }
it "returns true" do
expect do
expect(form.save).to be true
end.to change(order_cycle.reload, :name).to("Test Order Cycle")
end
end
context "when updating fails" do
let(:params) { { name: nil } }
it "returns false" do
expect do
expect(form.save).to be false
end.to_not change{ order_cycle.reload.name }
end
end
context "when schedules are present but updating something other than the :schedule_ids" do
let(:params) { { name: "New Order Cycle Name" } }
before { create(:schedule, order_cycles: [order_cycle]) }
it "doesn't delete the schedules" do
expect(order_cycle.schedules).to be_present
form.save
expect(order_cycle.schedules).to be_present
end
end
end
end
describe "updating schedules" do
let(:user) { create(:user, enterprise_limit: 10) }
let!(:managed_coordinator) { create(:enterprise, owner: user) }
let!(:managed_enterprise) { create(:enterprise, owner: user) }
let!(:coordinated_order_cycle) {
create(:simple_order_cycle, coordinator: managed_coordinator )
}
let!(:coordinated_order_cycle2) {
create(:simple_order_cycle, coordinator: managed_enterprise )
}
let!(:uncoordinated_order_cycle) {
create(:simple_order_cycle, coordinator: create(:enterprise) )
}
let!(:coordinated_schedule) { create(:schedule, order_cycles: [coordinated_order_cycle] ) }
let!(:coordinated_schedule2) { create(:schedule, order_cycles: [coordinated_order_cycle2] ) }
let!(:uncoordinated_schedule) { create(:schedule, order_cycles: [uncoordinated_order_cycle] ) }
context "where I manage the order_cycle's coordinator" do
let(:form) { OrderCycleForm.new(coordinated_order_cycle, params, user) }
let(:syncer_mock) {
instance_double(OrderManagement::Subscriptions::ProxyOrderSyncer, sync!: true)
}
before do
allow(OrderManagement::Subscriptions::ProxyOrderSyncer).to receive(:new) { syncer_mock }
end
context "and I add an schedule that I own, and remove another that I own" do
let(:params) { { schedule_ids: [coordinated_schedule2.id] } }
it "associates the order cycle to the schedule" do
expect(form.save).to be true
expect(coordinated_order_cycle.reload.schedules).to include coordinated_schedule2
expect(coordinated_order_cycle.reload.schedules).to_not include coordinated_schedule
expect(syncer_mock).to have_received(:sync!)
end
end
context "and I add a schedule that I don't own" do
let(:params) { { schedule_ids: [coordinated_schedule.id, uncoordinated_schedule.id] } }
it "ignores the schedule that I don't own" do
expect(form.save).to be true
expect(coordinated_order_cycle.reload.schedules).to include coordinated_schedule
expect(coordinated_order_cycle.reload.schedules).to_not include uncoordinated_schedule
expect(syncer_mock).to_not have_received(:sync!)
end
end
context "when I make no changes to the schedule ids" do
let(:params) { { schedule_ids: [coordinated_schedule.id] } }
it "ignores the schedule that I don't own" do
expect(form.save).to be true
expect(coordinated_order_cycle.reload.schedules).to include coordinated_schedule
expect(syncer_mock).to_not have_received(:sync!)
end
end
end
end
context "distributor order cycle" do
let(:order_cycle) { create(:distributor_order_cycle) }
let(:distributor) { order_cycle.coordinator }
let(:supplier) { create(:supplier_enterprise) }
let(:user) { distributor.owner }
let(:payment_method) { create(:payment_method, distributors: [distributor]) }
let(:shipping_method) { create(:shipping_method, distributors: [distributor]) }
let(:distributor_payment_method) { payment_method.distributor_payment_methods.first }
let(:distributor_shipping_method) { shipping_method.distributor_shipping_methods.first }
let(:variant) { create(:variant, product: create(:product, supplier: supplier)) }
let(:params) { { name: 'Some new name' } }
let(:form) { OrderCycleForm.new(order_cycle, params, user) }
let(:outgoing_exchange_params) do
{
enterprise_id: distributor.id,
incoming: false,
active: true,
variants: { variant.id => true },
pickup_time: "Saturday morning",
enterprise_fee_ids: []
}
end
context "basic update i.e. without exchanges or payment/shipping methods" do
it do
expect(form.save).to be true
expect(order_cycle.name).to eq 'Some new name'
end
end
context "updating basics, incoming exchanges, outcoming exchanges, payment_methods
and shipping methods simultaneously" do
before do
params.merge!(
incoming_exchanges: [{
enterprise_id: supplier.id,
incoming: true,
active: true,
variants: { variant.id => true },
receival_instructions: "Friday evening",
enterprise_fee_ids: []
}],
outgoing_exchanges: [outgoing_exchange_params],
selected_distributor_payment_method_ids: [distributor_payment_method.id],
selected_distributor_shipping_method_ids: [distributor_shipping_method.id]
)
end
it "saves everything i.e. the basics, incoming and outgoing exchanges, payment methods and
shipping methods" do
expect(form.save).to be true
expect(order_cycle.name).to eq 'Some new name'
expect(order_cycle.cached_incoming_exchanges.count).to eq 1
expect(order_cycle.cached_outgoing_exchanges.count).to eq 1
expect(order_cycle.distributor_payment_methods).to eq [distributor_payment_method]
expect(order_cycle.distributor_shipping_methods).to eq [distributor_shipping_method]
end
end
context "updating outgoing exchanges and shipping methods simultaneously but the payment
and shipping methods don't belong to the new or any existing order cycle
distributor" do
let(:other_distributor_payment_method) do
create(
:payment_method,
distributors: [create(:distributor_enterprise)]
).distributor_payment_methods.first
end
let(:other_distributor_shipping_method) do
create(
:shipping_method,
distributors: [create(:distributor_enterprise)]
).distributor_shipping_methods.first
end
before do
params.merge!(
outgoing_exchanges: [outgoing_exchange_params],
selected_distributor_payment_method_ids: [other_distributor_payment_method.id],
selected_distributor_shipping_method_ids: [other_distributor_shipping_method.id]
)
end
it "saves the outgoing exchange but ignores the shipping method" do
expect(form.save).to be true
expect(order_cycle.distributors).to eq [distributor]
expect(order_cycle.distributor_payment_methods).to be_empty
expect(order_cycle.distributor_shipping_methods).to be_empty
end
end
context "updating payment methods" do
context "and it's valid" do
let!(:distributor){ create(:distributor_enterprise) }
let!(:payment_method){ create(:payment_method, distributors: [distributor]) }
let!(:payment_method2){ create(:payment_method, distributors: [distributor]) }
let!(:distributor_payment_method){ distributor.distributor_payment_methods.first.id }
let!(:distributor_payment_method2){ distributor.distributor_payment_methods.second.id }
let!(:supplier){ create(:supplier_enterprise) }
context "the submitter is a coordinator" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method] },
order_cycle.coordinator.users.first
)
expect{ form.save }.to change{ order_cycle.distributor_payment_methods.pluck(:id).sort }
.from([distributor_payment_method, distributor_payment_method2])
.to([distributor_payment_method].sort)
end
end
context "submitter is a supplier" do
it "doesn't save the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor],
suppliers: [supplier])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method] },
supplier.users.first
)
expect{ form.save }.to_not change{ order_cycle.distributor_payment_methods.pluck(:id) }
end
end
context "submitter is an admin" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method2] },
create(:admin_user)
)
expect{ form.save }.to change{ order_cycle.distributor_payment_methods.pluck(:id).sort }
.from([distributor_payment_method, distributor_payment_method2])
.to([distributor_payment_method2])
end
end
context "submitter is a distributor" do
context "can update his own payment methods" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method] },
distributor.users.first
)
expect{ form.save }.to change{
order_cycle.distributor_payment_methods.pluck(:id).sort
}
.from([distributor_payment_method, distributor_payment_method2])
.to([distributor_payment_method])
end
end
context "can't update other distributors' payment methods" do
let(:distributor2){ create(:distributor_enterprise) }
it "doesn't save the changes" do
order_cycle = create(:distributor_order_cycle,
distributors: [distributor, distributor2])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method] },
distributor2.users.first
)
expect{ form.save }.to_not change{
order_cycle.distributor_payment_methods.pluck(:id)
}
end
end
end
end
context "with a payment method which doesn't belong to any distributor on the order cycle" do
it "ignores it" do
distributor_i = create(:distributor_enterprise)
distributor_ii = create(:distributor_enterprise)
distributor_payment_method_i = create(
:payment_method,
distributors: [distributor_i]
).distributor_payment_methods.first
distributor_payment_method_ii = create(
:payment_method,
distributors: [distributor_ii]
).distributor_payment_methods.first
order_cycle = create(:distributor_order_cycle,
distributors: [distributor_i])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_payment_method_ids: [distributor_payment_method_ii.id] },
order_cycle.coordinator.users.first
)
expect{ form.save }.not_to change{
order_cycle.distributor_payment_methods.pluck(:id)
}.from([distributor_payment_method_i.id])
end
end
end
context "updating shipping methods" do
context "and it's valid" do
let!(:distributor){ create(:distributor_enterprise) }
let!(:shipping_method){ create(:shipping_method, distributors: [distributor]) }
let!(:shipping_method2){ create(:shipping_method, distributors: [distributor]) }
let!(:distributor_shipping_method){ distributor.distributor_shipping_methods.first.id }
let!(:distributor_shipping_method2){ distributor.distributor_shipping_methods.second.id }
let(:supplier){ create(:supplier_enterprise) }
context "the submitter is a coordinator" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method] },
order_cycle.coordinator.users.first
)
expect{ form.save }.to change{
order_cycle.distributor_shipping_methods.pluck(:id).sort
}
.from([distributor_shipping_method, distributor_shipping_method2])
.to([distributor_shipping_method])
end
end
context "submitter is a supplier" do
it "doesn't save the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor],
suppliers: [supplier])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method] },
supplier.users.first
)
expect{ form.save }.not_to change{
order_cycle.distributor_shipping_methods.pluck(:id).sort
}.from([distributor_shipping_method, distributor_shipping_method2])
end
end
context "submitter is an admin" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method] },
create(:admin_user)
)
expect{ form.save }.to change{
order_cycle.distributor_shipping_methods.pluck(:id).sort
}
.from([distributor_shipping_method, distributor_shipping_method2])
.to([distributor_shipping_method])
end
end
context "submitter is a distributor" do
context "can update his own shipping methods" do
it "saves the changes" do
order_cycle = create(:distributor_order_cycle, distributors: [distributor])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method] },
distributor.users.first
)
expect{ form.save }.to change{
order_cycle.distributor_shipping_methods.pluck(:id).sort
}.from([distributor_shipping_method, distributor_shipping_method2])
.to([distributor_shipping_method])
end
end
context "can't update other distributors' shipping methods" do
let!(:distributor2){ create(:distributor_enterprise) }
let!(:shipping_method3){ create(:shipping_method, distributors: [distributor2]) }
let!(:distributor_shipping_method3){
distributor2.distributor_shipping_methods.first.id
}
it "doesn't save the changes" do
order_cycle = create(:distributor_order_cycle,
distributors: [distributor, distributor2])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method] },
distributor2.users.first
)
expect{ form.save }.not_to change{
order_cycle.distributor_shipping_methods.pluck(:id).sort
}.from [
distributor_shipping_method, distributor_shipping_method2,
distributor_shipping_method3
]
end
end
end
end
context "with a shipping method which doesn't belong to any distributor on the order cycle" do
it "ignores it" do
distributor_i = create(:distributor_enterprise)
distributor_ii = create(:distributor_enterprise)
distributor_shipping_method_i = create(
:shipping_method,
distributors: [distributor_i]
).distributor_shipping_methods.first
distributor_shipping_method_ii = create(
:shipping_method,
distributors: [distributor_ii]
).distributor_shipping_methods.first
order_cycle = create(:distributor_order_cycle,
distributors: [distributor_i])
form = OrderCycleForm.new(
order_cycle,
{ selected_distributor_shipping_method_ids: [distributor_shipping_method_ii.id] },
order_cycle.coordinator.users.first
)
expect(form.save).to be true
expect(order_cycle.distributor_shipping_methods).to eq [distributor_shipping_method_i]
end
end
end
end
end