mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-27 21:06:49 +00:00
d715b6b3bb
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329 LocalisedNumber validation was tightened, but that means negative number were not valid anymore. This commit has been cherry-picked after this fix has already been applied. Now we just change the order of characters in the regex because humans are used to reading the minus at the beginning of the number. But this change doesn't change the logic at all.
76 lines
2.1 KiB
Ruby
76 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Spree::LocalizedNumber do
|
|
describe ".parse" do
|
|
context "with point separator" do
|
|
it "captures the proper amount for a formatted string" do
|
|
expect(described_class.parse('5.67')).to eql 5.67
|
|
end
|
|
end
|
|
|
|
context "with comma separator" do
|
|
it "captures the proper amount for a formatted string" do
|
|
expect(described_class.parse('5,67')).to eql 5.67
|
|
end
|
|
end
|
|
|
|
context "with decimal point" do
|
|
it "captures the proper amount for a formatted string" do
|
|
expect(described_class.parse('1,599.99')).to eql 1599.99
|
|
end
|
|
end
|
|
|
|
context "with decimal comma" do
|
|
it "captures the proper amount for a formatted string" do
|
|
expect(described_class.parse('1.599,99')).to eql 1599.99
|
|
end
|
|
end
|
|
|
|
context "with a numeric input" do
|
|
it "uses the amount as is" do
|
|
expect(described_class.parse(1599.99)).to eql 1599.99
|
|
end
|
|
end
|
|
|
|
context "with a string having 2 digits between separators" do
|
|
it "ignores the left separator" do
|
|
expect(described_class.parse('1,59.99')).to eql 159.99
|
|
end
|
|
end
|
|
end
|
|
|
|
describe ".valid_localizable_number?" do
|
|
context "with a properly formatted string" do
|
|
it "returns true" do
|
|
expect(described_class.valid_localizable_number?('1.599,99')).to eql true
|
|
end
|
|
end
|
|
|
|
context "with a string having 2 digits between separators" do
|
|
it "returns false" do
|
|
expect(described_class.valid_localizable_number?('1,59.99')).to eql false
|
|
end
|
|
end
|
|
|
|
context "with a numeric input" do
|
|
it "returns true" do
|
|
expect(described_class.valid_localizable_number?(1599.99)).to eql true
|
|
end
|
|
|
|
context "with a negative number" do
|
|
it "returns true" do
|
|
expect(described_class.valid_localizable_number?(-1599.99)).to eql true
|
|
end
|
|
end
|
|
end
|
|
|
|
context "with letters" do
|
|
it "returns false" do
|
|
expect(described_class.valid_localizable_number?('invalid')).to eql false
|
|
end
|
|
end
|
|
end
|
|
end
|