mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-30 21:27:17 +00:00
Inspecting 1479 files
...................................................................................................................................................C..C.......................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................C.............................................................................................C...................................................................C.......................................................................................................................................................................C....................................................C.............C...........CC.........C......C.CC.C....................C........................................................
Offenses:
app/controllers/spree/users_controller.rb:36:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/spree/users_controller.rb:51:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/controllers/user_confirmations_controller.rb:27:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
partial("layouts/alert",
^
app/models/enterprise.rb:117:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
validates :instagram,
^
spec/controllers/spree/credit_cards_controller_spec.rb:250:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:stored_credit_card, user_id: user.id,
^
spec/controllers/user_confirmations_controller_spec.rb:45:44: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
session[:confirmation_return_url] =
^
spec/factories/order_factory.rb:40:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
order.payments << build(:payment, amount: order.total,
^
spec/lib/reports/packing/packing_report_spec.rb:59:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/lib/reports/packing/packing_report_spec.rb:63:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
build(:line_item_with_shipment,
^
spec/models/enterprise_spec.rb:521:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(Enterprise.supplying_variant_in([p1.variants.first,
^
spec/models/enterprise_spec.rb:906:77: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:enterprise_relationship, parent: distributor, child: supplier,
^
spec/services/products_renderer_spec.rb:22:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:product, name: "banana bread", primary_taxon_id: cakes.id,
^
spec/services/products_renderer_spec.rb:88:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:90:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:97:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
fruits_supplier.producer_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:99:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/services/products_renderer_spec.rb:109:93: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_apples.product_properties.create!({ property_id: property_conventional.id,
^
spec/services/products_renderer_spec.rb:111:94: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_banana_bread.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:113:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_cherries.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:115:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
product_doughnuts.product_properties.create!({ property_id: property_organic.id,
^
spec/services/products_renderer_spec.rb:117:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
products_renderer = ProductsRenderer.new(distributor, order_cycle, customer,
^
spec/support/request/stripe_stubs.rb:17:81: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
def stub_payment_intent_get_request(response: {}, stripe_account_header: true,
^
spec/support/request/stripe_stubs.rb:172:6: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
{
^
spec/support/request/stripe_stubs.rb:175:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
object: "list",
^
spec/support/request/stripe_stubs.rb:176:25: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
has_more: false,
^
spec/system/admin/bulk_order_management_spec.rb:792:99: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
it "displays only line items whose orders meet the date restriction criteria, when changed",
^
spec/system/admin/bulk_order_management_spec.rb:1071:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1121:82: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
shared_examples "display only group by information for selected variant" do
^^^^^^^^^^
spec/system/admin/bulk_order_management_spec.rb:1143:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/bulk_order_management_spec.rb:1166:12: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^
spec/system/admin/customers_spec.rb:18:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
create(:customer, first_name: 'John', last_name: 'Doe', enterprise: managed_distributor1,
^
spec/system/admin/enterprise_fees_spec.rb:102:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Inherit From Product',
^
spec/system/admin/enterprise_fees_spec.rb:128:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Weight (per kg or lb)',
^
spec/system/admin/enterprise_fees_spec.rb:132:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per item)',
^
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:157:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/enterprise_fees_spec.rb:159:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
select 'Flat Rate (per order)',
^
spec/system/admin/enterprise_fees_spec.rb:222:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:22:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:27:32: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("#admin-menu").click
^^^^^^^
spec/system/admin/flatpickr_spec.rb:32:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:34:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/flatpickr_spec.rb:41:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_cycles/complex_editing_spec.rb:74:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/complex_editing_spec.rb:110:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_select(
^
spec/system/admin/order_cycles/list_spec.rb:147:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:160:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/list_spec.rb:188:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(find('input.datetimepicker',
^
spec/system/admin/order_cycles/simple_spec.rb:447:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).not_to have_selector(
^
spec/system/admin/order_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:207:30: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within(".modal") do
^
spec/system/admin/order_spec.rb:235:21: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
login_as_admin
^^
spec/system/admin/order_spec.rb:240:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:247:62: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
context "when using the cancel option in the dropdown" do
^^
spec/system/admin/order_spec.rb:248:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^
spec/system/admin/order_spec.rb:299:53: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_content "Are you sure?"
^^^^^^^^
spec/system/admin/order_spec.rb:327:36: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
find("a.delete-item").click
^
spec/system/admin/order_spec.rb:401:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:405:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:598:59: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Resend Confirmation",
^
spec/system/admin/order_spec.rb:617:52: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_link "Cancel Order",
^
spec/system/admin/order_spec.rb:633:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:674:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:735:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:762:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:778:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:780:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:796:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:807:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
# Since the order is completed, the price is not supposed to be updated
^
spec/system/admin/order_spec.rb:813:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
within "#order-total" do
^
spec/system/admin/order_spec.rb:815:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:924:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:959:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/order_spec.rb:981:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
before do
^^
spec/system/admin/order_spec.rb:992:8: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
end
^^
spec/system/admin/order_spec.rb:1002:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
spec/system/admin/shipping_methods_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
1479 files inspected, 81 offenses detected, 81 offenses corrected
267 lines
8.5 KiB
Ruby
267 lines
8.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
FactoryBot.define do
|
|
factory :order, class: Spree::Order do
|
|
transient do
|
|
shipping_method { create(:shipping_method, distributors: [distributor]) }
|
|
end
|
|
|
|
user
|
|
bill_address
|
|
completed_at { nil }
|
|
email { user&.email || customer.email }
|
|
|
|
factory :order_ready_for_details do
|
|
distributor { create(:distributor_enterprise, with_payment_and_shipping: true) }
|
|
order_cycle { create(:order_cycle, distributors: [distributor]) }
|
|
|
|
after(:create) do |order|
|
|
order.line_items << build(:line_item, order: order)
|
|
order.update_totals_and_states
|
|
|
|
order.order_cycle.exchanges.outgoing.first.variants << order.line_items.first.variant
|
|
end
|
|
|
|
factory :order_ready_for_payment do
|
|
bill_address
|
|
ship_address
|
|
|
|
after(:create) do |order, evaluator|
|
|
order.select_shipping_method evaluator.shipping_method.id
|
|
OrderWorkflow.new(order).advance_to_payment
|
|
end
|
|
|
|
factory :order_ready_for_confirmation do
|
|
transient do
|
|
payment_method { create(:payment_method, distributors: [distributor]) }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
order.payments << build(:payment, amount: order.total,
|
|
payment_method: evaluator.payment_method)
|
|
order.next!
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
factory :order_with_totals do
|
|
after(:create) do |order|
|
|
create(:line_item, order: order)
|
|
order.line_items.reload # to ensure order.line_items is accessible after
|
|
order.update_totals_and_states
|
|
end
|
|
end
|
|
|
|
factory :order_with_line_items do
|
|
bill_address
|
|
ship_address
|
|
|
|
transient do
|
|
line_items_count { 5 }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
create(:shipment, order: order)
|
|
order.shipments.reload
|
|
|
|
create_list(:line_item, evaluator.line_items_count, order: order)
|
|
order.line_items.reload
|
|
order.update_order!
|
|
end
|
|
|
|
factory :completed_order_with_totals do
|
|
state { 'complete' }
|
|
completed_at { Time.zone.now }
|
|
|
|
distributor { create(:distributor_enterprise) }
|
|
|
|
after(:create) { |order, _evaluator| order.shipments.map(&:refresh_rates) }
|
|
|
|
factory :order_ready_to_ship do
|
|
payment_state { 'paid' }
|
|
shipment_state { 'ready' }
|
|
after(:create) do |order|
|
|
create(:payment, :completed, amount: order.total, order: order)
|
|
|
|
order.shipments.each do |shipment|
|
|
shipment.inventory_units.each { |u| u.update_column('state', 'on_hand') }
|
|
shipment.update_column('state', 'ready')
|
|
end
|
|
order.reload
|
|
end
|
|
end
|
|
|
|
factory :shipped_order do
|
|
after(:create) do |order|
|
|
order.shipments.each do |shipment|
|
|
shipment.inventory_units.each { |u| u.update_column('state', 'shipped') }
|
|
shipment.update_column('state', 'shipped')
|
|
end
|
|
order.reload
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
trait :with_line_item do
|
|
transient do
|
|
variant { FactoryBot.create(:variant) }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
line_item = create(:line_item_with_shipment, order: order,
|
|
variant: evaluator.variant,
|
|
shipping_method: evaluator.shipping_method)
|
|
order.shipments << line_item.target_shipment
|
|
end
|
|
end
|
|
|
|
trait :completed do
|
|
transient do
|
|
payment_method { create(:payment_method, distributors: [distributor]) }
|
|
ship_address { create(:address) }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
create(:payment, state: "checkout", order: order, amount: order.total,
|
|
payment_method: evaluator.payment_method)
|
|
order.recreate_all_fees!
|
|
order.ship_address = evaluator.ship_address
|
|
break unless a = order.next! while !order.delivery?
|
|
order.select_shipping_method(evaluator.shipping_method.id)
|
|
|
|
break unless a = order.next! while !order.completed?
|
|
end
|
|
end
|
|
end
|
|
|
|
factory :order_with_totals_and_distribution, parent: :order_with_distributor do
|
|
transient do
|
|
shipping_fee { 3 }
|
|
end
|
|
|
|
order_cycle { create(:simple_order_cycle) }
|
|
|
|
after(:create) do |order, proxy|
|
|
product = create(:simple_product)
|
|
create(:line_item_with_shipment, shipping_fee: proxy.shipping_fee,
|
|
order: order,
|
|
product: product)
|
|
order.reload
|
|
end
|
|
|
|
trait :completed do
|
|
transient do
|
|
completed_at { Time.zone.now }
|
|
state { "complete" }
|
|
payment_method { create(:payment_method, distributors: [distributor]) }
|
|
ship_address { create(:address) }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
# Ensure order is valid and passes through necessary checkout steps
|
|
create(:payment, state: "checkout", order: order, amount: order.total,
|
|
payment_method: evaluator.payment_method)
|
|
order.ship_address = evaluator.ship_address
|
|
break unless order.next! while !order.completed?
|
|
|
|
order.update_columns(
|
|
completed_at: evaluator.completed_at,
|
|
state: evaluator.state
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
factory :order_with_distributor, parent: :order do
|
|
distributor { create(:distributor_enterprise) }
|
|
end
|
|
|
|
factory :order_with_taxes, parent: :completed_order_with_totals do
|
|
transient do
|
|
product_price { 0 }
|
|
tax_rate_amount { 0 }
|
|
tax_rate_name { "" }
|
|
included_in_price { "" }
|
|
zone { create(:zone_with_member) }
|
|
end
|
|
|
|
distributor { create(:distributor_enterprise) }
|
|
order_cycle { create(:simple_order_cycle) }
|
|
|
|
after(:create) do |order, proxy|
|
|
order.distributor.update_attribute(:charges_sales_tax, true)
|
|
product = FactoryBot.create(:taxed_product, zone: proxy.zone,
|
|
price: proxy.product_price,
|
|
tax_rate_amount: proxy.tax_rate_amount,
|
|
tax_rate_name: proxy.tax_rate_name,
|
|
included_in_price: proxy.included_in_price)
|
|
FactoryBot.create(:line_item, order: order, product: product, price: product.price)
|
|
order.reload
|
|
end
|
|
end
|
|
|
|
factory :order_with_credit_payment, parent: :completed_order_with_totals do
|
|
distributor { create(:distributor_enterprise) }
|
|
order_cycle { create(:simple_order_cycle) }
|
|
|
|
transient do
|
|
credit_amount { 10_000 }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
create(:payment, :completed, amount: order.total + evaluator.credit_amount, order: order)
|
|
|
|
order.reload
|
|
end
|
|
end
|
|
|
|
factory :order_without_full_payment, parent: :completed_order_with_totals do
|
|
distributor { create(:distributor_enterprise) }
|
|
order_cycle { create(:simple_order_cycle) }
|
|
|
|
transient do
|
|
unpaid_amount { 1 }
|
|
end
|
|
|
|
after(:create) do |order, evaluator|
|
|
create(:payment, amount: order.total - evaluator.unpaid_amount, order: order,
|
|
state: "completed")
|
|
order.reload
|
|
end
|
|
end
|
|
|
|
factory :completed_order_with_fees, parent: :order_with_distributor do
|
|
transient do
|
|
payment_fee { 5 }
|
|
shipping_fee { 3 }
|
|
shipping_tax_category { nil }
|
|
end
|
|
|
|
ship_address { create(:address) }
|
|
order_cycle { create(:simple_order_cycle) }
|
|
|
|
after(:create) do |order, evaluator|
|
|
create(:line_item, order: order)
|
|
product = create(:simple_product)
|
|
create(:line_item, order: order, product: product)
|
|
|
|
payment_calculator = build(:calculator_per_item, preferred_amount: evaluator.payment_fee)
|
|
payment_method = create(:payment_method, calculator: payment_calculator)
|
|
create(:payment, order: order,
|
|
amount: order.total,
|
|
payment_method: payment_method,
|
|
state: 'checkout')
|
|
|
|
create(:shipping_method_with, :shipping_fee, shipping_fee: evaluator.shipping_fee,
|
|
distributors: [order.distributor],
|
|
tax_category: evaluator.shipping_tax_category)
|
|
|
|
order.reload
|
|
break unless order.next! while !order.completed?
|
|
order.reload
|
|
end
|
|
end
|
|
end
|