mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-26 20:56:48 +00:00
25b7f1749c
I changed the text to focus on the resolution: the user needs to choose a tax category or a different calculator. I associated the error to the model to prevent the attribute name from being included in the error message. Alternatively, we could have changed the name of the attribute to match the UI. But this error affects the combination of two attributes, none of them is invalid on its own. I'm using Rails' default lazy lookup for error messages which results in shorter code and a standard structure. I also added a simple spec.
70 lines
2.1 KiB
Ruby
70 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class EnterpriseFee < ApplicationRecord
|
|
include CalculatedAdjustments
|
|
|
|
acts_as_paranoid
|
|
|
|
belongs_to :enterprise
|
|
belongs_to :tax_category, class_name: 'Spree::TaxCategory'
|
|
|
|
has_many :coordinator_fees, dependent: :destroy
|
|
has_many :order_cycles, through: :coordinator_fees
|
|
|
|
has_many :exchange_fees, dependent: :destroy
|
|
has_many :exchanges, through: :exchange_fees
|
|
|
|
FEE_TYPES = %w(packing transport admin sales fundraising).freeze
|
|
PER_ORDER_CALCULATORS = ['Calculator::FlatRate',
|
|
'Calculator::FlexiRate',
|
|
'Calculator::PriceSack'].freeze
|
|
|
|
validates :fee_type, inclusion: { in: FEE_TYPES }
|
|
validates :name, presence: true
|
|
validates :enterprise_id, presence: true
|
|
|
|
before_save :ensure_valid_tax_category_settings
|
|
|
|
scope :for_enterprise, lambda { |enterprise| where(enterprise_id: enterprise) }
|
|
scope :for_enterprises, lambda { |enterprises| where(enterprise_id: enterprises) }
|
|
|
|
scope :managed_by, lambda { |user|
|
|
if user.has_spree_role?('admin')
|
|
where(nil)
|
|
else
|
|
where('enterprise_id IN (?)', user.enterprises.select(&:id))
|
|
end
|
|
}
|
|
|
|
scope :per_item, lambda {
|
|
joins(:calculator).where('spree_calculators.type NOT IN (?)', PER_ORDER_CALCULATORS)
|
|
}
|
|
scope :per_order, lambda {
|
|
joins(:calculator).where('spree_calculators.type IN (?)', PER_ORDER_CALCULATORS)
|
|
}
|
|
|
|
def self.clear_all_adjustments(order)
|
|
order.all_adjustments.enterprise_fee.destroy_all
|
|
end
|
|
|
|
private
|
|
|
|
def ensure_valid_tax_category_settings
|
|
# Setting an explicit tax_category removes any inheritance behaviour
|
|
# In the absence of any current changes to tax_category, setting
|
|
# inherits_tax_category to true will clear the tax_category
|
|
if tax_category_id_changed?
|
|
self.inherits_tax_category = false if tax_category.present?
|
|
elsif inherits_tax_category_changed?
|
|
self.tax_category_id = nil if inherits_tax_category?
|
|
end
|
|
|
|
if inherits_tax_category? && PER_ORDER_CALCULATORS.include?(calculator_type)
|
|
errors.add(:base, :inherit_tax_requires_per_item_calculator)
|
|
throw :abort
|
|
end
|
|
|
|
true
|
|
end
|
|
end
|