mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-01-26 20:56:48 +00:00
2013750732
This naming scheme removes some duplication which is nice, but it's a little strange and results in a longer name overall. I don't like it very much because: - filenames don't include the component's actual name. This makes it slightly harder to find them in my text editor (but I'd probably get used to that) - the namespace and class naming isn't exactly right. This is _the_ vertical_ellipsis_menu, not a subcomponent. - the stimulus controller name is now longer, adding more cruft to the HTML. Lots of discussion here: https://github.com/ViewComponent/view_component/discussions/67 People tried to come up with a better way (and I was tempted to try myself). It seems this approach won. I guess it's not so bad if your component names are shorter.
5 lines
282 B
Plaintext
5 lines
282 B
Plaintext
.vertical-ellipsis-menu{ "data-controller": "vertical-ellipsis-menu--component" }
|
|
%i.fa.fa-ellipsis-v{ "data-action": "click->vertical-ellipsis-menu--component#toggle" }
|
|
.vertical-ellipsis-menu-content{ "data-vertical-ellipsis-menu--component-target": "content" }
|
|
= content
|