Maikel
2c25ab0f09
Merge pull request #13199 from cyrillefr/FixRubocopLintIssuesIII
...
Fixes some rubocop linting offenses - part III
2025-03-11 13:58:22 +11:00
Ahmed Ejaz
37de45b60e
Merge pull request #13189 from chahmedejaz/bugfix/13019-page-redirect-from-shopfront
...
Page is redirected to root after login from shopfront page
2025-03-09 06:14:44 +05:00
cyrillefr
9bb617d748
Fixes some rubocop linting offenses - part III
2025-03-06 23:42:53 +01:00
David Cook
d3b7db0082
Merge pull request #13186 from cyrillefr/FixRubocopLintIssuesII
...
Fixes some rubocop linting offenses - part II
2025-03-06 11:33:56 +11:00
Maikel
2e4b59daaf
Remove orphaned comment
2025-03-06 11:28:25 +11:00
David Cook
45eedd1e89
Simplify expresssion
...
It's worth noting that a falsy value won't get cached (as before).
But I didn't take the time to investigate if that makes a difference or not.
2025-03-06 10:14:24 +11:00
David Cook
633cdaca56
Remove unused method
...
I believe it's unused since e4d307fe5e
2025-03-06 09:49:50 +11:00
Ahmed Ejaz
b61c9500f9
13019: fix redirect issue
2025-03-05 01:35:46 +05:00
Konrad
6d67a913d9
Merge pull request #13147 from dacook/cleanup
...
Speed up super admin dashboard
2025-03-04 18:09:20 +01:00
Konrad
fcc9e3dc8b
Merge pull request #13171 from cyrillefr/EnterpriseFeesPageTrueInsteadOfBlankOption
...
Remove true as select default first option
2025-03-04 18:07:24 +01:00
David Cook
9adf3a22af
Show only first 25 enterprises
...
I thought about reducing it further, but maybe people are used to having a large list. Let's see how this performs
2025-03-03 14:46:24 +01:00
David Cook
b9aada47e0
Remove superfluous %div from haml ID elements
...
Div is the default element in HAML, so we don't need to specify it.
2025-03-03 14:46:24 +01:00
David Cook
5a1190cdda
Remove superfluous %div from haml elements with class
...
Div is the default element in HAML, so we don't need to specify it. https://haml.info/docs/yardoc/file.REFERENCE.html#implicit-div-elements
2025-03-03 14:46:24 +01:00
cyrillefr
446b948889
Fixes some rubocop linting offenses - part II
2025-03-03 14:03:47 +01:00
Maikel
5bef8b7dde
Merge pull request #13178 from cyrillefr/FixRubocopLintIssuesI
...
Fixes some rubocop linting offenses
2025-02-28 10:40:56 +11:00
Filipe
feccef0b36
Merge pull request #13157 from drummer83/email_styled_password
...
Create styled email for reset password instructions
2025-02-27 16:53:04 -06:00
Filipe
cf3213cf96
Merge pull request #13168 from dacook/dfc-product-import-select-all-12301
...
[DFC Orders] Select/deselect all on DFC Product Import
2025-02-27 16:43:37 -06:00
Filipe
9a0bcac3c2
Merge pull request #13156 from drummer83/orders_input_align
...
Align inputs on orders list and adjust position of checkboxes for reports
2025-02-27 16:04:16 -06:00
cyrillefr
027d4ccbad
Fixes some rubocop linting offenses - part I
...
- Lint/RedundantSafeNavigation
- Lint/SelfAssignment
- Lint/UselessMethodDefinition
2025-02-27 16:28:00 +01:00
Maikel
462886447a
Merge pull request #13126 from mkllnk/oidc-error
...
Direct people to refresh OIDC connection when needed
2025-02-24 15:45:48 +11:00
Filipe
bd893eb3d5
Merge pull request #13139 from drummer83/reply-to-email-address
...
Add a 'reply to' email address where it makes sense and has been missing
2025-02-21 13:09:42 -06:00
cyrillefr
96d6718e6d
Remove true as select default first option
2025-02-21 14:20:59 +01:00
Konrad
7cd3c32787
Merge pull request #13164 from rioug/fix-user-controlled-method-execution
...
Fix user controlled method execution
2025-02-21 12:59:40 +01:00
Filipe
9baed8536c
Merge pull request #13121 from rioug/13054-out-of-stock-autoremove
...
Autoremove/update item from the cart if stock changed during checkout
2025-02-20 22:35:40 -06:00
Filipe
f715c366ea
Merge pull request #13160 from chahmedejaz/task/13097-add-columns-in-packing-reports
...
Add shipping method and shipment state to packing reports
2025-02-20 19:49:03 -06:00
Filipe
f7b471da08
Merge pull request #13148 from mkllnk/dfc-variants
...
Add DFC product groups with variants
2025-02-20 18:53:00 -06:00
Konrad
48688311d1
Merge pull request #13165 from chahmedejaz/bugfix/unable-to-view-images-in-dev-env
...
Fix base urls for assets in development
2025-02-20 07:56:09 +01:00
David Cook
7444ddccd1
Wait, There's A Lifecycle Callback For That
2025-02-20 12:52:27 +11:00
David Cook
7acc78b6d8
Revert "Delegate events to the parent element"
...
This reverts commit e31c16df43
2025-02-20 12:49:25 +11:00
David Cook
e31c16df43
Delegate events to the parent element
...
Ok so I wasn't as smart as I thought I was. The stimulus controller knows when its element is added/removed from the DOM (and calls connect/disconnect appropriately). But if any child elements are added, they don't automatically have my new event handlers.
So I borrowed jQuery's event delegation concept, and listen for any events that 'bubble' up to the controller element, and delegate them as needed.
Alternatively, maybe I could have used a Mutation Observer, but I think it's best to avoid where possible.
Or of course, we could just revert my change and keep the 'data-action's in the HTML. I'm curious to hear opinions on this.."
2025-02-20 12:46:27 +11:00
David Cook
4cb1b0a48e
Add total count of selected items
...
I noticed there's a controller for that too, so might as well make use of it. The orders page has it at the top, because that's where the bulk action menu is. But on this page, the action is the import button so I put it there.
2025-02-20 12:15:53 +11:00
David Cook
6e7766a2c2
Increase font size
2025-02-20 12:15:53 +11:00
David Cook
57fb855147
Ensure label reaches to edge of table cell
...
Best viewed with whitespace ignored
2025-02-20 12:15:49 +11:00
David Cook
b370b207b5
Automatically bind toggleCheckbox action
2025-02-20 12:14:49 +11:00
David Cook
b92c046119
Automatically bind toggleAll action
...
We are already specifying the element's role ('all') in the HTML. Its behaviour should be predefined; there's no need to also specify in the HTML.
The eventhandler doesn't need to be cleand up on disconnect, because they are removed along with the DOM object.
2025-02-20 11:24:21 +11:00
David Cook
c2e54104d0
Add select/deselect all checkbox
...
There's A Controller For That.
(But I think it makes the HTML ugly..)
2025-02-20 10:56:53 +11:00
Maikel Linke
691e988fbb
Fix Roadie dev config to inline CSS in emails
...
Roadie doesn't work with asset host:
* https://github.com/Mange/roadie-rails?tab=readme-ov-file#known-issues
And we don't need it.
2025-02-19 13:29:34 +11:00
Ahmed Ejaz
216348d361
fix base urls for assets in development
2025-02-19 05:09:19 +05:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
Gaetan Craig-Riou
0ae855047d
Fix User controlled method execution
...
Add white list for the fire endpoint to limit which action can be taken.
Add specs for fire endpoint
2025-02-18 14:42:26 +11:00
Maikel Linke
516759062f
Import variants for the same product group
...
When importing another catalog, it's probably referring to external
product groups. Storing the external link allows us to group several
variants and replicate the same structure within OFN.
2025-02-18 13:08:48 +11:00
Maikel Linke
fbdc6c9bd0
Split growing supplied product builder
2025-02-18 13:08:46 +11:00
Maikel Linke
61b54e922a
Remove impossible error rescue
...
This block got duplicated in a previous PR.
2025-02-18 12:20:01 +11:00
Maikel Linke
4027ce0c05
Style links within flash errors
...
The default aqua link colour looked aweful on orange/red background. I
tried a few different standard colours but couldn't get it right. So I
reverted to the web standard link style: underline. That's looks pretty
good. I personally think that we should use the more for links.
2025-02-18 12:15:17 +11:00
Maikel Linke
ffe4084b7f
Link to OIDC settings from error message
...
The colour of the link is really bad though.
2025-02-18 12:15:13 +11:00
Maikel Linke
bb503e12a3
Direct people to refresh OIDC connection
...
Not the best UX but the easiest next step to implement. Next we should:
* Include link in error message instead of redirecting straight there.
Otherwise users may feel disoriented.
* Provide a custom error message?
2025-02-18 12:14:12 +11:00
Gaetan Craig-Riou
db0547543e
Use the new OutOfStockModalComponent
...
It will now redirect to the shop page if the out of stock check results
in an empty order
2025-02-18 10:47:10 +11:00
Gaetan Craig-Riou
4a2f22e56d
Add OutOfStockModalComponent
...
It encapsulate the logic for the out of stock modal
2025-02-18 10:47:03 +11:00
Gaetan Craig-Riou
9d59f87b30
Dispatch "closing" event when closing modal
...
This allow for any other controller to trigger an action when the modal
is closed
2025-02-17 16:50:49 +11:00
Gaetan Craig-Riou
4a63efd342
Remove redundant ||
2025-02-17 16:50:18 +11:00
