cyrillefr
0aecb6873a
Requested changes
...
- 2 new methods for reading either current/desired on hand/on demand
depending on variant state. Goal is to get rid of send method in View
- referring in on_hand/on_demand is in fact irrelevant. In the piece of
code, only desired on_hand/on_demand can be called as we are only in
new variant (non persisted) mode
- View does not use send method anymore, replaced by current_or_desired
- refactor of the spec -> 2 examples in one to get more speed.
2025-02-12 16:01:21 +01:00
cyrillefr
6d6164c8f6
Keep stock selection when error on saving
...
- added 2 not to be persisted attributes aimed at dealing with the UI
- added them to the permitted list
- updated view to switch mode about on_hand/on_demand
that is: from an already persisted variant or not
- Not persisted deals with on_*_desired not to be persisted fields
- Persisted mode deals with regular on_* fields
- the corresponding spec for both on_hand/on_demand
2025-02-12 16:01:21 +01:00
Maikel Linke
079d09b8b8
Report simple values easily
2025-02-11 15:36:07 +11:00
Maikel Linke
fa7edbb073
Alert ensures to pass metadata correctly
2025-02-11 15:27:58 +11:00
Maikel Linke
ea6efa9164
Simplify default country code lookup
...
The code was using the code from the environment variables to load a
reocrd from the database to then return the initial code again.
The only use of `DefaultCountry.code` is currently in the geocoder JS
compilation. Now it doesn't need the database anymore.
2025-01-28 13:22:26 +11:00
Konrad
01036e6321
Merge pull request #13087 from mkllnk/stock-location
...
Remove class Spree::StockLocation
2025-01-25 12:41:37 +01:00
Maikel
c258bee44d
Merge pull request #13065 from mkllnk/dfc-amend-nothing
...
Admin updates can trigger new backorders until the order cycle is closed
2025-01-22 16:32:23 +11:00
Maikel Linke
64608beaa8
Remove DefaultStockLocation created in setup
2025-01-22 12:01:57 +11:00
Maikel Linke
aa9daed66e
Remove unused StockLocation#stock_items
...
And the reverse association.
2025-01-22 11:20:05 +11:00
Maikel Linke
06d9d96f54
Fix error on removed product from catalog
2025-01-17 12:21:28 +11:00
François Turbelin
14334b02bf
Add new field on enterprise admin form
2025-01-13 16:54:17 +01:00
Maikel Linke
c1198c8e1f
UNSAFE Style Rails/CompactBlank
2025-01-10 09:14:34 +11:00
Maikel Linke
2297b650f8
Skip amending backorder if there's none
2025-01-09 12:10:07 +11:00
Maikel Linke
ddaeff7c53
Use DfcCatalog in offer broker
2025-01-07 11:03:34 +11:00
Gaetan Craig-Riou
ab57618e59
Merge pull request #13044 from mkllnk/dfc-store-order-links-only
...
Remove old, replaced backorder lookup
2025-01-06 10:11:34 +11:00
Filipe
e2e2285f81
Merge pull request #13027 from chahmedejaz/bugfix/13026-reset-variant-unit-name
...
Changing a variant unit scale from items to weight/volume does not remove variant unit name
2024-12-19 18:27:39 -06:00
Maikel Linke
60b62d41d6
Remove old, replaced backorder lookup
2024-12-17 13:48:03 +11:00
Maikel Linke
d5c3e94b24
OfferBroker needs only catalog URL, no other URLs
2024-12-12 15:45:42 +11:00
Maikel Linke
bf41658d32
Fix nil error when amending backorder
2024-12-11 12:40:46 +11:00
Maikel Linke
fcbaefb2c8
Update each backorder only once in bulk cancel
2024-12-11 12:40:46 +11:00
Maikel Linke
9ca1b48d2e
Move backorder amendment out of order callback
...
Triggering it for each order is inefficient when we cancel them in bulk.
The callback doesn't allow us to optimise this.
2024-12-11 12:40:46 +11:00
Maikel Linke
7d7253cf0e
Re-use BackorderUpdater to complete backorder
2024-12-11 12:40:46 +11:00
Maikel Linke
4fa4eb1b4e
Move backorder update code to re-usable class
2024-12-11 12:40:46 +11:00
Ahmed Ejaz
3e031ab735
13026: reset variant unit name if unit is not items
2024-12-11 03:14:11 +05:00
Maikel
4c71ea3866
Merge pull request #12994 from mkllnk/dfc-update-voc
...
Add new DFC vocabulary for order states
2024-12-04 12:57:03 +11:00
Maikel
de938f6f10
Merge pull request #12949 from rioug/12859-use-VINE-voucher
...
[City OFN Voucher] A shopper can use a VINE voucher
2024-12-03 14:04:44 +11:00
Maikel
697f430156
Merge pull request #12992 from mkllnk/errors
...
Add simpler Alert.raise interface to notify Bugsnag
2024-12-03 13:29:11 +11:00
Maikel Linke
c4c95d472e
Use defined DFC orders states
2024-11-29 16:16:42 +11:00
Gaetan Craig-Riou
f5b9ca361c
Use the voucher adjustment amount for redeeming
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
1e6fbadd8b
Fix Vine::VoucherRedeemerService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d102652c03
Fix Vine::VoucherValidatorService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
1b50217242
Re worked the Vine::ApiService to raise exception on error
...
Log Client and Server error, and re raise exception for the caller
to handle
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d413a142c9
Update various voucher related file to use the new Vouchers::Vine
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
48ad7ed8a0
Add voucher used by multiple enterprise and recycle code scenario
...
Plus optimise code with `find_or_initialize_by` as suggested in review
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d7313ffec9
Per review, improve Vine::VoucherValidatorService
...
plus specs
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
0569b30e0d
Refactor Vine related services
...
Move them under Vine module to keep the code nicely organised
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9399c7e129
Add VineVoucherRedeemerService
...
It handles redeeming a voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
b30096317c
VineApiService, add voucher_redemptions
...
It is used to redeem a voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
f9fb7bf399
Add VineVoucherValidatorService and spec
...
It handles validating and creating vine voucher
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7cbe77668a
VineApiService, add voucher_validation
...
It is used to validate a voucher using the given short code
2024-11-28 13:35:01 +01:00
Filipe
a493d70f5c
Merge pull request #12950 from macanudo527/unlock_bigdecimal
...
Fix rounding issues by upgrading decimal maths library
2024-11-25 19:18:19 -06:00
Maikel Linke
af33fc357e
Use shorter Alert syntax
...
I still think that some of these objects won't be visible in Bugsnag but
I don't want to test any more on cases that were broken before and may
not be relevant now.
2024-11-21 15:58:56 +11:00
Maikel Linke
6a8cc410d2
Replace broken order data
...
Bugsnag expects a string as value, not an ActiveRecord object. The
result was just "filtered" data, not showing any of the order's
attributes.
Since wanting to share the order data seems a common pattern, I added a
convenience method for it.
2024-11-21 15:58:55 +11:00
Maikel Linke
0d8df5d2a8
Replace Bugsnag calls with Alert.raise
2024-11-21 15:58:55 +11:00
Maikel Linke
73a1698aad
Add live test for Bugsnag
...
Needs human to review Bugsnag account.
2024-11-21 15:28:19 +11:00
Maikel Linke
97d41c230e
Add simpler Bugsnag wrapper
2024-11-21 15:28:19 +11:00
Maikel Linke
a8fb6492f4
Lookup backorder for updates with saved link
2024-11-19 15:53:59 +11:00
Neal Chambers
7a5074cc90
Refactor option_value_value_unit_scaled for correct unit value scaling and update sales tax report spec for clarity
2024-11-13 16:28:18 +09:00
Neal Chambers
0797314360
Fix inaccuracies introduced with truncation
2024-11-13 16:28:18 +09:00
Gaetan Craig-Riou
eb66244b74
Fix Bugsnag call to notify
...
Make sure we add metadata as expected:
https://docs.bugsnag.com/platforms/ruby/rails/reporting-handled-errors/#add_metadata
2024-11-06 14:01:48 +11:00
