David Cook
23f7f2974a
Merge pull request #13618 from deivid-rodriguez/remove-unnecessary-sleeps
...
Remove unnecessary explicit sleeps
2025-10-20 16:06:44 +11:00
Rachel Arnould
c4c266246c
Merge pull request #13507 from rioug/tag-rules-remove-angular
...
[Variant Tags] Remove angular from tag rule admin page
2025-10-15 23:16:05 +02:00
David Rodríguez
d6c044fd5b
Remove unnecessary explicit sleeps
...
Capybara helpers already wait for the content to show up (and we already
have a default of 10 seconds configured), so I don't think waiting more is
actually the problem in these specs.
But if we wanted to wait more, I think it's better to pass the `:wait`
option to capybara matchers, because that's a "maximum waiting value"
but we'll still proceed earlier if the content shows up.
Using the same idea, I changed the positive assertions to happen first,
because negative assertions do spend "max wait time" waiting, while
positive assertions only wait until the content shows up.
2025-10-15 13:09:52 +02:00
Maikel Linke
bf661159c6
Notify data proxy of permission changes
2025-10-10 16:18:21 +11:00
David Cook
60ee33053d
Apply suggestions from code review
2025-10-08 14:15:56 +11:00
Maikel Linke
5b383237ea
Deactivate Puffing Billy to avoid hanging specs
2025-10-08 13:26:37 +11:00
Filipe
ff2e0f4d45
Merge pull request #13533 from chahmedejaz/task/13435-sort-products-by-on-hand-amount
...
Sort product list by 'on hand' amount
2025-09-29 15:07:00 +01:00
Gaetan Craig-Riou
ede7650fc9
Replace space by -, to match angular tag functionality
2025-09-29 09:36:12 +10:00
Gaetan Craig-Riou
42f7f2606b
Remove reordering testing
...
This functionality has been removed
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
771573af1c
Fix system spec to work with refactored screen
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
25f6db09a5
TagListInputComponent removed dependency on the form
...
This allows us to use the component in a context where there is no form
object defined.
2025-09-24 10:38:47 +10:00
Filipe
bfcadfd7c0
Merge pull request #13404 from cyrillefr/UnsavedChangesMustAppearOnRemovingSingleTagFromOrderCycle
...
Fixes Save button does not enable when removing only tag in OC
2025-09-15 13:27:26 +01:00
Ahmed Ejaz
c326aa6b23
Add comprehensive specs for sorting functionality
2025-09-15 01:59:40 +05:00
filipefurtad0
589315780c
Adds coverage to homepage alert HTML content
2025-09-04 19:07:29 +01:00
Filipe
ddb8b2d08f
Merge pull request #13496 from dacook/fix-link
...
Fix link to enterprise payment methods tab
2025-08-28 19:17:37 +01:00
Maikel Linke
94b75540e4
Replace Timecop with Rails' time helpers
...
Rails 4.1 added time helpers but we never bothered using them. But now
I'm getting rid of the Timecop dependency and use standard helpers.
Beware though that the new helpers always freeze time. When you travel
to a certain date then the clock stops ticking while Timecop maintained
the passing of time.
The freezing of time could cause problems if you are trying to enforce a
timeout. But all current specs don't seem affected.
In most cases, the freezing will make it easier to avoid flaky specs.
2025-08-22 16:57:04 +10:00
David Cook
f79c1879bd
Test that you can actually get to Stripe to connect your account
...
Well.. almost.
2025-08-20 13:06:59 +10:00
David Cook
646d538a3d
Fix broken link
...
This link would go to the enterprise edit screen, but didn't successfully select the payment methods panel.
Ideally, the spec would try to follow the link and verify that you can see the Connect with Stripe button. But it opens the link in a new tab and I'm not sure how to test that.
2025-08-20 11:54:47 +10:00
Maikel Linke
3a72aefc1c
Fail test when timeout reached
...
In this example it didn't matter but if we re-use the helper then it
needs to raise an error after the timeout has been reached.
2025-08-12 09:54:48 +10:00
Maikel Linke
ca34d24847
Replace long waits with better polling
...
Capybara polls under the hood as well. So we do something similar here
but tailored to the tested code. This reduced the test run time on my
machine from 35 seconds to 15 seconds.
2025-08-11 17:07:44 +10:00
Maikel Linke
342ef4e9eb
Complete smoke test of DFC data sharing
...
Working within a shadow root of the web component isn't well supported
by Capybara and I needed to find some workarounds. It's not pretty but
it works (on my machine). *fingers crossed*
2025-08-08 14:00:41 +10:00
Maikel Linke
210201514e
Add gem capybara-shadowdom to access web component
2025-08-08 14:00:41 +10:00
Maikel Linke
2d3f18a71b
Load DFC Permissions module in system spec
...
But we can't access the inside of the component yet.
2025-08-08 14:00:41 +10:00
cyrillefr
8011449ce7
Adding a spec with one single tag
...
- need to add ids to ru the spec
2025-07-14 18:15:01 +02:00
Gaetan Craig-Riou
1c4febd332
Enable inventory for variant override test
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
33bac6f816
Fix specs to take into account inventory feature
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
b253950075
Add feature flag for variant override specs
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
b19b987ed0
Remove variant rule type when inventory disabled
2025-07-09 11:35:26 +10:00
Gaetan Craig-Riou
f30b899569
Disable inventory option for product import
2025-07-09 11:35:26 +10:00
Ahmed Ejaz
4b19d38c58
Refactor variant creation in hub actions spec to use supplier association for clarity
2025-06-29 19:13:44 +05:00
Ahmed Ejaz
c648249160
Refactor order view specs to improve clarity in expectations
2025-06-21 16:19:31 +05:00
Ahmed Ejaz
8d407b1dc9
Fix lint issues
2025-06-21 16:19:31 +05:00
Ahmed Ejaz
fe1b8aaab3
Add hub actions spec for producer order management functionality
2025-06-21 16:19:31 +05:00
Ahmed Ejaz
ade35f2fa2
Fixes specs and update code respectively
2025-06-21 16:19:31 +05:00
filipefurtad0
229a87cf72
Removes debugger superfluous debuger flag
2025-06-14 13:28:41 +01:00
Carlos Chitty
63d284e81a
Use Orders::WorkflowService#complete! and #advance_to_payment in specs to replace code causing Style/NestedModifier rubocop offenses
...
Rewrite the loop "break unless a = order.next! while !order.delivery?" to correct the offenses. Not adding a helper because the change was only needed in a couple of places.
2025-06-04 12:46:58 -04:00
Konrad
d7c39fcab7
Merge pull request #13297 from filipefurtad0/fix_#13264_BOM
...
Fixes bad display from Producer name on BOM page
2025-05-23 18:56:36 +02:00
Filipe
93ac10bb75
Merge pull request #13262 from cillian/remove-angular-on-enterprise-images-and-white-label-sections
...
Remove Angular from the Settings > Images section
2025-05-16 20:03:55 +01:00
Konrad
6432eceee5
Merge pull request #13313 from cyrillefr/FilterSelectionListNotDisplayingFullNames
...
Fixes dotted shipping method names bad display in select (filters)
2025-05-16 19:58:13 +02:00
Konrad
af3bb4c419
Merge pull request #13310 from mkllnk/reset-products
...
Fix product reset on import
2025-05-16 18:49:20 +02:00
Filipe
97ceed6cbe
Merge pull request #13263 from chahmedejaz/bugfix/13180-oc-search-on-bom
...
Fix Order Cycle search on BOM page is not working for more than 5 OCs
2025-05-16 10:59:55 +01:00
Filipe
3efa2832de
Merge pull request #13257 from ashishp91/13221-make-shipped-orders-uneditable
...
13221 - Don't allow shipped orders to be editable
2025-05-15 19:23:33 +01:00
Filipe
371d0fbf79
Merge pull request #13281 from rioug/13172-search-by-tags
...
[Variant tags] Search products by tags
2025-05-14 07:38:59 +01:00
David Cook
ffea1cca81
Replace JB's method with mine
...
Obviously I'm biased, but I like mine better.
2025-05-13 14:52:20 +10:00
David Cook
d62740da10
Update helper to exclude line items
...
_scrolls down_ Oh... JB already did that 😆
Nice to see we were thinking along the same lines.
2025-05-13 14:52:06 +10:00
David Cook
fa9ed1a66b
Add expectation for other line items
2025-05-13 14:42:46 +10:00
David Cook
3b1f267465
Declare which line items are being expected.
2025-05-13 14:41:03 +10:00
David Cook
cf30b792f9
Refactor: move shared code to context
2025-05-13 14:40:41 +10:00
David Cook
6daf94875a
Rename varianbles based on OC number
...
It was a bit confusing that they don't line up.
2025-05-13 14:23:51 +10:00
cyrillefr
e61d951dcf
Requested changes - translation useless
...
- also useless in specs
2025-05-12 14:46:27 +02:00
