6694 Commits

Author	SHA1	Message	Date
Andy Brett	fade1696e2	update variant spec based on new validation behavior	2020-12-22 19:46:47 -08:00
Andy Brett	79aaa38173	update outdated spec ... This spec was added as part of cbac916e66 - now that we're updating the unit_value to be 1, we expect this not to fail	2020-12-22 19:46:40 -08:00
Matt-Yorkley	3d4f0ebb7b	Ensure variants don't end up with invalid data when a product's variant_unit is changed ... Fixes an issue where a product's variant_unit value is changed from "weight" to "items" and some of the product's variants can be left in an invalid state, which in turn breaks cloning of order cycles (with fatal errors).	2020-11-11 20:24:21 +00:00
Luis Ramos	b281e7e9e5	Merge pull request #6312 from mkllnk/variant-override-loading ... Avoid loading variant overrides for no reason	2020-11-06 03:59:33 +00:00
Luis Ramos	bd4da3b5ce	Merge pull request #6247 from cillian/deep-munge-issue ... Patch Rails :deep_munge issue so empty array parameters don't get converted to nil	2020-11-05 13:25:39 +00:00
Pau Pérez Fabregat	8e3f0d2152	Merge pull request #6134 from Matt-Yorkley/webmock-helper ... Improve Webmock debugging	2020-11-05 13:11:02 +01:00
Maikel Linke	4b1f5ae060	Avoid loading variant overrides for no reason	2020-11-05 14:31:19 +11:00
Luis Ramos	eada388534	Add handle_extensions to get Spree.translations (archaic spree js translations) in handlebars templates ... This is all legacy from spree that can be cleaned up at some point, we only have two handlebars templates in OFN	2020-11-04 12:15:45 +00:00
Luis Ramos	5c4ea1a6be	Fix tax rates spec	2020-11-04 12:15:45 +00:00
Luis Ramos	72c454a211	Fix reference to Spree bug	2020-11-04 12:15:45 +00:00
Luis Ramos	543a9592c7	Adapt spec to routes without spree	2020-11-04 12:15:45 +00:00
Luis Ramos	2ce96f4bbe	Registration path is working correctly again without spree	2020-11-04 12:15:45 +00:00
Luis Ramos	4125fe1690	Fix problem with string matchers	2020-11-04 12:15:45 +00:00
Luis Ramos	ab53db0c61	Merge ability and ability decorator	2020-11-04 12:15:45 +00:00
Luis Ramos	b7aa04353c	Fix requires of product duplicator	2020-11-04 12:15:45 +00:00
Luis Ramos	1bce516a45	Make specs load product duplicator ... This makes the ofn version of the product duplicator be used instead of the spree one	2020-11-04 12:15:45 +00:00
Luis Ramos	f6195f1159	Remove duplicate_extra logic from ProductDuplicator	2020-11-04 12:15:23 +00:00
Luis Ramos	503c17f896	Move Spree::ProductDuplicator to Spree::Core namespace	2020-11-04 12:15:23 +00:00
Luis Ramos	72a39fdf54	Add required factory from spree_core	2020-11-04 12:15:23 +00:00
Luis Ramos	4b8515358c	Remove reference to FactoryGirl, it's FactoryBot that is used in OFN	2020-11-04 12:15:23 +00:00
Luis Ramos	cf7d8067df	Fix easy rubocop issues	2020-11-04 12:15:23 +00:00
Luis Ramos	d4e4669e49	Run transpec	2020-11-04 12:15:23 +00:00
Luis Ramos	e9f76cb339	Remove some dead code (Config.track_inventory_levels), remove variant.cost_price= so that localized number is seen, and fix specs	2020-11-04 12:15:23 +00:00
Luis Ramos	b68c5ee0f9	Remove dead code (prototypes) and fix specs	2020-11-04 12:15:23 +00:00
Luis Ramos	072cd2bd54	Run rubocop autocorrect in specs	2020-11-04 12:15:23 +00:00
Luis Ramos	8cb75fc6d8	Bring models from spree_core: Spree::Product and Spree::Variant! ... EPIC COMMIT ALERT :-)	2020-11-04 12:15:23 +00:00
Pau Pérez Fabregat	4911bb6613	Merge pull request #6274 from luisramos0/rubocop ... Use rubocop auto correct to fix a number of issues	2020-11-02 22:13:36 +01:00
Luis Ramos	eea73aa989	Merge pull request #5919 from luisramos0/injector_refactor_for_rails41 ... [Rails 4.1, works in master] Convert relations with to_a so that they work in rails 4.1	2020-10-31 09:33:27 +00:00
Luis Ramos	c2c12b34f9	Fix more rubocop issues with auto correct	2020-10-30 17:10:23 +00:00
Luis Ramos	c71ebc38bb	Fix Layout/ArgumentAlignment	2020-10-30 17:06:08 +00:00
Luis Ramos	b0e889be2a	Fix Style/RandomWithOffset	2020-10-30 16:50:37 +00:00
Luis Ramos	b3196295e6	Fix Style/RaiseArgs	2020-10-30 16:50:37 +00:00
Luis Ramos	75cec3b606	Fix issue Style/HashSyntax	2020-10-30 16:50:37 +00:00
Luis Ramos	92417d849c	Fix rubocop issue Rails/DynamicFindBy	2020-10-30 16:50:37 +00:00
Luis Ramos	bf5fcde885	Fix Lint/UnusedMethodArgument	2020-10-30 16:50:37 +00:00
Luis Ramos	40f8c785a2	Fix Lint/UnusedBlockArgument	2020-10-30 16:50:37 +00:00
Luis Ramos	403384dbb1	Fix rubocop isssues, trailing whitespaces and empty lines	2020-10-30 16:50:37 +00:00
Luis Ramos	c30cba8bfe	Fix issue Layout/SpaceInsideHashLiteralBraces	2020-10-30 16:50:37 +00:00
Luis Ramos	e8138e8c23	Fix rubocop issues in models/payment_spec	2020-10-30 16:50:37 +00:00
Luis Ramos	4845cde20f	Fix rubocop issue Layout/HashAlignment	2020-10-30 16:50:37 +00:00
Luis Ramos	a8265aff89	Fix rubocop issue Layout/FirstHashElementIndentation	2020-10-30 16:50:37 +00:00
Luis Ramos	9cb3b0b14a	Fix rubocop issue Layout/FirstArrayElementIndentation	2020-10-30 16:50:37 +00:00
Luis Ramos	06433b1be3	Fix rubocop issue Layout/ExtraSpacing	2020-10-30 16:50:37 +00:00
Luis Ramos	d4c52ce122	Fix rubocop issue Layout/EmptyLinesAroundBlockBody	2020-10-30 16:50:37 +00:00
Luis Ramos	eb4e732c1a	Fix rubocop issue Layout/EmptyLines	2020-10-30 16:50:37 +00:00
Luis Ramos	3fe2684270	Fix rubocop issue Layout/BlockAlignment	2020-10-30 16:50:37 +00:00
Luis Ramos	3e6e338e3d	Fix rubocop issue Layout/ArgumentAlignment	2020-10-30 16:50:37 +00:00
Luis Ramos	cf3f511f4d	Add directive spec to validate the dialog template is loaded on element click	2020-10-30 15:09:13 +00:00
Luis Ramos	1d1067ebc1	Add coverage to T&Cs file opening on a new tab and also for the upload timestamp now displayed in the page	2020-10-30 15:09:13 +00:00
Luis Ramos	ceee89fad0	Make Checkout form submit read terms_and_conditions_accepted from the checkout form checkbox	2020-10-30 15:09:13 +00:00