Gaetan Craig-Riou
ef1f3207f7
Update spec/system/admin/products_v3/update_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
b0433bd8f5
Re add test for invalid cloned products
...
There is no easy way to make the original product invalid, but we can
make sure the cloned product will be invalid. The cloned product add
"COPe OF " in front of the product's name, so by starting with a name
that's long enough, the cloned product will have a name longer that 255
char and will then be invalid.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
755a394704
Fix spec to remove reliance on browser's message
...
Client side validation messages depend on the browser's locale, which
we have no controll over. Now we just check a message is set.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
04e14bf38b
Per review, check value are saved in the database
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
7c2c614f90
Update spec/models/spree/variant_spec.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
3bb2232bc1
Remove non updatable check when updating a product
...
After the product redactor it only checked for the "description" on
product, which is actually skipped when doing an update.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
0695b434a2
Fix rebase issue
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
9db417319d
Improve variant related validation when creating product
...
I disabled Metrics/AbcSize for ensure_standard_variant as I don't think
that's hard to understand the code. And utimately it will be removed
once product actually becomes optional.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
83a619b097
Fix bulk order management page
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
fa986f3fc2
Fix orders and fulfillment report
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
977b6e6c2a
Fix minor differences in local env and CI
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
f7446749ff
Fix Unit price system spec
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
844cab458e
Post rebase fix product import system spec
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
8ec1f61cd7
Fix legacy bulk edit product system spec
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
893b541dca
Fix product system spec
...
The pending spec are to be fix after a rebase, master currently as
some changes which will make this easier
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4ae392490b
Fix variant system spec
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
25171413ef
Update Spree::Price parsing to match LocalizedNumber.parse
...
Spree::Price parsing was returning 0.0 when given a an empty string as
price, resulting in a variant being valid even if no price was given. It
only happened if `Spree::LocalizedNumber` wasn't used.
Spree::LocalizedNumber` return nil if given a blank number.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4ad6971121
Fix Bulk product edit system spec after rebase
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
d55950a3c5
Fix rebase issue
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
45075a0ccd
Fix rebase typo
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
144a09916c
Use instance_double instead of double
...
Instance double, amongst other thing, verifies that any methods being
stubbed would be present on an instance of the class
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
00dfe6810f
Fix ProductDuplicator
...
There isn't away I could think of to create an invalid product, so I
removed those test
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
cc85fed7cc
Add localizeCurrency and specs
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
45b0686130
Add PriceParser and UnitPrices and specs
...
This is in preparation for removing angular from the variant update
page.
Converted using https://www.codeconvert.ai/coffeescript-to-javascript-converter
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4cd83d3fd4
Prettify javascript
...
Also update .prettierignore so that spec files get prettified as well
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
768825d689
Fix Bulk Edit product part 2
...
Note, the empty entry for unit scale need a css fix , currently showing
at half height
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
e8234ee4a0
Fix Bulk products edit page , part 1
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
6ff9650eaf
Fix legacy bulk edit products UI
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
cd74a73680
Consolidate angular option value namer spec
...
Merge the two spec files into the correct one.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
36c4d24c93
Fix angular option value namer
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
c8bf23bdc2
Fix UnitPrice spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
df82dd0759
Fix API v0 variants controller spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
5ec39f994a
Fix spree admin products controller spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
8a31153d6d
Fix API v0 products controller spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
4109fbde70
Fix variant controller spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
37ae217afc
Fix product set spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
4fd115897a
Refactor ProductImport::EntryValidator
...
Move comparaison function to ProductImport::SpreadsheetEntry
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
e22804712e
Fix product importer
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
e2c762f06b
Refactor, use instance_double in variant spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
1ad7123a9d
Fix Spree::LineItem
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
d0fe1585d7
Move variant unit attributes to variant 2
...
Update Spree::Product and spec
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
f58a3a859f
Move variant unit attributes to variant 1
...
Update Spree::Variant model and spec
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
3b89cd5957
Fix option value namer
...
Uses the variant variant_unit, variant_unit_name, variant_unit_scale
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
e33ed5141b
Fix weigths and measures
...
Use variant_unit, variant_unit_scale from the variant
2024-10-14 14:56:46 +11:00
Maikel Linke
95ff0d8d4a
Fail gracefully on DFC product import errors
2024-10-11 12:10:23 +11:00
Maikel Linke
7d2d14320f
Spec that connector update fixed bug
2024-10-11 09:54:29 +11:00
Maikel Linke
86c91143b7
Update more variant data on import
2024-10-10 16:59:04 +11:00
Maikel Linke
260e7ba817
Update products when importing them multiple times
...
Instead of creating a new variant every time.
2024-10-10 16:57:58 +11:00
Maikel Linke
71ca292c92
Synchronise stock with DFC catalog during checkout
...
This will delay the checkout request by a few seconds if there's stock
to sync. But we minimise the chance of missing reduced stock from orders
on another platform.
We still have a gap between the checkout and placing a backorder. In
that time we can't guarantee enough stock. But let's tackle that after
the pilot.
2024-10-09 14:47:07 +11:00
Maikel Linke
664f324db6
Sync stock of multiple linked catalogs
...
And the logic becomes a bit simpler.
2024-10-08 16:37:35 +11:00