Ahmed Ejaz
93a3130851
12973: add specs
2024-12-05 16:18:21 -06:00
Maikel
de938f6f10
Merge pull request #12949 from rioug/12859-use-VINE-voucher
...
[City OFN Voucher] A shopper can use a VINE voucher
2024-12-03 14:04:44 +11:00
Gaetan Craig-Riou
73819a4638
Fix unique validator for vouche code
...
Paranoia doesn't support unique validation including deleted records:
https://github.com/rubysherpas/paranoia/pull/333
We use a custom validator, ScopedUniquenessValidator to avoid the issue
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
a2c4c44eea
Move Vine voucher to Vouchers::Vine
...
A Vine voucher is really a specific type of FlatRate voucher but because
a Vine voucher can be used by mutiple enterprise, it can be considered
different enough to warrant it's own class.
It still share a lot of the behaviour of a FlatRate voucher, so to avoid
duplication, all the shared functionality have been moved to a
Vouchers::FlatRatable concern.
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7726c7d129
Per review, rename not_vine scope to local
...
- use IS DISTINCT FROM instead of two conditions
- added spec for scope
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
0569b30e0d
Refactor Vine related services
...
Move them under Vine module to keep the code nicely organised
2024-11-28 13:35:01 +01:00
Ahmed Ejaz
3d09ac01cc
12968: fix existing specs
...
- As per the new changes, unit_type change will create a new product rather than give errors.
- on bulk-update screen as well, two products can have same name with different unit_type
2024-11-25 17:29:27 +05:00
Ahmed Ejaz
283706114e
12968: update condition to match variant with unit scale
2024-11-25 16:36:13 +05:00
Maikel Linke
a8fb6492f4
Lookup backorder for updates with saved link
2024-11-19 15:53:59 +11:00
Maikel Linke
4610141ed8
Add shortcut to order's exchange
2024-11-19 15:53:59 +11:00
Maikel Linke
597d9ad314
Add semantic links to Exchange
2024-11-19 15:53:59 +11:00
Maikel Linke
1ce0b25bb0
Switch SemanticLink to use new association
...
And ActiveRecord magic does the rest when used correctly.
2024-11-19 15:53:58 +11:00
Maikel Linke
c07ec6cdfd
Polymorphically associate SemanticLinks to variant
2024-11-19 15:53:58 +11:00
Maikel Linke
271475893d
Remove unused stock aggregation
2024-11-01 16:46:35 +11:00
Filipe
0d97f992b9
Merge pull request #12943 from mkllnk/sanitise
...
Sanitise HTML attributes in the database
2024-10-31 17:32:56 -06:00
David Cook
3756e368c8
Merge pull request #12921 from rioug/12908-error-when-tax-refund
...
Add Bugsnag notification if we reach tax rate refund code
2024-10-30 14:51:40 +11:00
Maikel Linke
d2e5087668
Remove redundant HTML sanitisation
...
We don't need to run the sanitiser each time we read an attribute. It's
a waste of time.
2024-10-24 08:47:11 +11:00
Maikel Linke
90589ae868
Spec restock after order cancellation
2024-10-23 16:35:59 +11:00
Maikel Linke
167a69d2ef
Spec change in order state more precisely
2024-10-23 14:46:12 +11:00
Maikel Linke
09524e266f
Fix method name description
2024-10-23 14:42:02 +11:00
Gaetan Craig-Riou
3f22e8cca7
Fix Bugsnag payload data
2024-10-21 11:13:42 +11:00
Gaetan Craig-Riou
f024aff45d
Add Bugsnag notification if we reach tax rate refund code
...
The original Spree code allow for a tax adjustment to be considered a
refund in a specific scenario:
- instance is using inclusive tax
- instance that applies different tax rate in different tax zones
This scenario should not happen with how our instances are configured
More info: https://github.com/openfoodfoundation/openfoodnetwork/pull/6565#discussion_r566535431
2024-10-16 11:37:21 +11:00
Filipe
97b6289263
Merge pull request #12787 from rioug/move-variant-unit-attributes-to-variant
...
[Product Refactor] Move variant unit sizes to variant
2024-10-15 19:58:45 +01:00
Rachel Arnould
f54552f939
Merge pull request #12886 from rioug/12855-VINE-connected-app
...
[Citi OFN Voucher] Add VINE connected app
2024-10-14 15:32:09 +02:00
Gaetan Craig-Riou
b0433bd8f5
Re add test for invalid cloned products
...
There is no easy way to make the original product invalid, but we can
make sure the cloned product will be invalid. The cloned product add
"COPe OF " in front of the product's name, so by starting with a name
that's long enough, the cloned product will have a name longer that 255
char and will then be invalid.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
7c2c614f90
Update spec/models/spree/variant_spec.rb
...
Co-authored-by: David Cook <david@redcliffs.net >
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
3bb2232bc1
Remove non updatable check when updating a product
...
After the product redactor it only checked for the "description" on
product, which is actually skipped when doing an update.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
9db417319d
Improve variant related validation when creating product
...
I disabled Metrics/AbcSize for ensure_standard_variant as I don't think
that's hard to understand the code. And utimately it will be removed
once product actually becomes optional.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
25171413ef
Update Spree::Price parsing to match LocalizedNumber.parse
...
Spree::Price parsing was returning 0.0 when given a an empty string as
price, resulting in a variant being valid even if no price was given. It
only happened if `Spree::LocalizedNumber` wasn't used.
Spree::LocalizedNumber` return nil if given a blank number.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
d55950a3c5
Fix rebase issue
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
45075a0ccd
Fix rebase typo
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
00dfe6810f
Fix ProductDuplicator
...
There isn't away I could think of to create an invalid product, so I
removed those test
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4fd115897a
Refactor ProductImport::EntryValidator
...
Move comparaison function to ProductImport::SpreadsheetEntry
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
e22804712e
Fix product importer
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
e2c762f06b
Refactor, use instance_double in variant spec
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
1ad7123a9d
Fix Spree::LineItem
2024-10-14 14:56:47 +11:00
Gaetan Craig-Riou
d0fe1585d7
Move variant unit attributes to variant 2
...
Update Spree::Product and spec
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
f58a3a859f
Move variant unit attributes to variant 1
...
Update Spree::Variant model and spec
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
b14a1e72f3
Handle api secret
...
The VINE Api require a secret and an API key to be used. The secret is
used to sign the request. The secret is linked to the API key so we need
to store it along side the key.
2024-10-07 15:09:58 +11:00
Gaetan Craig-Riou
224738e0a1
Per review, clean up code
2024-10-07 15:09:51 +11:00
Maikel Linke
4b1d7d8a41
Remove dead permission to access StockLocation
...
We don't have any UI to edit stock locations. So this ability is unused.
2024-10-03 08:24:15 +10:00
Maikel Linke
1e3c18f3f6
Remove unneeded method StockLocation#propagate_variant
2024-10-03 08:24:15 +10:00
Gaetan Craig-Riou
f980cb45f6
Add logic for ConnectedApps::Vine#connect and disconnect
2024-10-02 16:44:27 +10:00
Maikel Linke
ac3730096f
Update specs to assume backorderable default
2024-10-02 15:13:00 +10:00
Maikel
196956140e
Merge pull request #12856 from mkllnk/dfc-order
...
Place backorders for linked products via DFC integration
2024-10-01 10:51:00 +10:00
Cillian O'Ruanaidh
f474afaceb
Merge in latest :master and resolve conflict in app/models/enterprise.rb
2024-09-27 10:11:26 +01:00
Maikel Linke
95e620a78b
Add lookup of variants by semantic id
2024-09-25 10:55:40 +10:00
Filipe
a5d17b4da9
Merge pull request #12459 from mkllnk/description-html
...
Sanitise HTML in long description of enterprise
2024-09-19 16:12:45 -06:00
Filipe
562a24524b
Merge pull request #12848 from rioug/12770-product-preview
...
Product preview
2024-09-19 15:20:18 -06:00
David Cook
296997d558
Test to ensure report abilities
2024-09-17 13:23:14 +10:00
