David Cook
29d3b34776
Increase dropdown height
2024-03-06 17:12:15 +11:00
David Cook
8612f7baab
Only add extra padding on alignment edge
...
Saves a few precious pixels on the other edge.
2024-03-06 14:10:54 +11:00
David Cook
e770f10f2b
Tomselect has minimum width
2024-03-06 14:10:54 +11:00
David Cook
cbcf388acc
Ensure gap between fields wrapped over a line
2024-03-06 14:10:51 +11:00
David Cook
38766f5256
Show variant_unit_name for 'items'
2024-03-06 13:41:22 +11:00
David Cook
e52b8daf50
Refactor: DRY
2024-03-06 13:41:22 +11:00
David Cook
bfd6319cf2
Mark tom-select as changed
...
Thankfully I was able to use basic DOM features, so there's no coupling of the logic with tom-select.
It wasn't going to be simple to get tom-select to listen for the 'changed' class on the original select, so I found a simple solution with a CSS sibling selector instead.
2024-03-06 13:41:22 +11:00
David Cook
af748158aa
Hide chevron until hover to allow a bit more space for text
2024-03-06 13:41:22 +11:00
David Cook
864b876a9a
Add tom-select with naked style
...
The rem units are converted to em to make the padding relative to the chevron size. This means different font sizes will Just Work.
2024-03-06 13:41:22 +11:00
David Cook
8f0e9c9f5c
Remove unnecessary selector
...
I can't see any reason that fieldsets, which are containers, should share styles with inputs. Maybe font styles, but everything looks fine still.
2024-03-06 13:01:44 +11:00
David Cook
958288b223
Move input styles to form stylesheet
...
A better way to arrange it, and as a bonus it makes the selectors simpler, yay!
2024-03-06 13:01:44 +11:00
David Cook
5cfac3d2c7
Add comments
2024-02-29 10:10:57 +11:00
cyrillefr
f62b32a3b9
Requested changes after review
...
- modified css to increase clicking area
- modified spec to more straightfoward and more user oriented link
2024-02-28 08:15:34 +01:00
cyrillefr
884d6f15ff
Replace a divs controller by an html details one
...
- checked_controller close details element on checkboxes
- dropdown_controller.js is to rebuild controller from many divs
to be hidden and visible to an html detail elmnt one
- details html element styling
2024-02-25 16:43:57 +01:00
Konrad
2477a63f36
Merge pull request #12103 from basilawwad/selecting-OC-should-redirect-to-shop
...
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected.
2024-02-19 21:51:19 +01:00
basilawwad
08111f9a2c
added shop target and activateshoppanel function
...
Remove Pending Message
Update shopping_spec.rb
Update shopping_spec.rb
2024-02-16 09:27:21 +03:00
David Cook
915a5ce66b
Listen for changes on added fields
...
Finally, we can add new variants!
Requires updated stimulus-rails-nested-form
2024-02-16 08:51:49 +11:00
David Cook
3706b6d1da
Make actions target optional
...
This is to make testing simpler, but it is strictly optional anyway.
2024-02-15 17:32:08 +11:00
David Cook
765ee0ed78
refactor js
2024-02-15 17:32:08 +11:00
David Cook
6e5154b922
add stimulus-rails-nested-form
...
The official instructions (https://www.stimulus-components.com/docs/stimulus-rails-nested-form ) don't quite work, because of an issue with this component (https://stackoverflow.com/a/76715129 ). So we work around for now by using the umd file instead.
2024-02-15 17:32:08 +11:00
David Cook
7e186091ff
Ensure un-changed field error state shows
...
When there is a required field that can't be empty. I knew these complex styles would come back to bite me.
◉ Best viewed with whitespace ignored
2024-02-15 10:36:45 +11:00
David Cook
c65771eac6
Add new 'naked' button
...
I couldn't think of a better name.
2024-02-15 10:36:45 +11:00
David Cook
50b325c944
Annotate and arrange scss
2024-02-15 10:36:45 +11:00
Konrad
8751cc37f3
Merge pull request #12126 from cyrillefr/Replace-remote_toggle_controller-with-generic-toggle_control_controller
...
Replace remote_toggle with method inside generic controller
2024-02-15 00:32:05 +01:00
Rachel Arnould
164bac63e0
Merge pull request #12130 from dacook/buu/modal-styles-11065
...
[BUU] Image modal styles
2024-02-14 16:12:32 +01:00
Filipe
850918dac5
Merge pull request #12112 from chahmedejaz/bugfix/12085-fix-customer-search-autofill-issue
...
Fix Customer Search Autofill Issue
2024-02-12 12:29:28 +00:00
David Cook
5e4dd3864f
Update image and modal size
...
Using a new 'fit' modal size.
On smaller screens, we need to allow the image to shrink. That's a good general rule, but I was hesitant to make it a global rule..
2024-02-07 12:48:44 +11:00
cyrillefr
f8cb98f43e
Replace remote_toggle with method inside generic controller
...
- put former remote toggle ctrller toggle method
in new toggleAdvancedSettings in more generic toggle ctrller
- modified acordingly the 2 associated views
- put former test code in more generic ctrller test file
- deleted now useless ctrller + test files
2024-02-06 17:02:23 +01:00
David Cook
6189feadaa
Prevent modal covered by scrollbar
...
Using units relative to the document, rather than the screen.
I don't think that remaining min-height should be there at all, but reveal-modal is used a lot so I don't know for sure.
2024-02-06 14:56:39 +11:00
David Cook
8c6d3a27ec
Move modal action styles to parent component
...
They were already being shared with a HelpModalComponent in fact.
2024-02-06 14:34:36 +11:00
Rachel Arnould
d4d5449fba
Merge pull request #12107 from dacook/buu/fixes
...
[BUU] Style and behaviour updates
2024-02-05 11:33:06 +01:00
Ahmed Ejaz
a6431bdec6
12085: fix customer search autofill issue
2024-02-02 01:58:35 +05:00
David Cook
262823bddd
Ensure On Demand field doesn't overflow following cell
2024-02-01 11:56:40 +11:00
David Cook
079925bc9a
Fix for styling with a blank value
...
It's not usually valid, but can still be entered. I wasn't able to fix the positioning of the :after psuedo element without having a child text node. Maybe it's possible to add an empty child text node, but I didn't think it worth getting down to that level..
2024-02-01 11:31:14 +11:00
David Cook
133a9e6c7f
Show popout when press printable character
2024-02-01 11:18:15 +11:00
David Cook
da82b12ca7
Prevent negative values for stock on hand
...
Using browser validation. I didn't use model validation because the on_hand pseudo-attribute doesn't support it.
But.. it turned out to not be so simple. Browser validation can't work if the field is hidden, and breaks the javascript. So now I made the javascript smarter, and the end result is more helpful I think.
2024-02-01 11:18:15 +11:00
David Cook
3d941dcc1f
Adjust popout position
...
Now it's lined up perfectly with the number input.
2024-02-01 11:18:15 +11:00
David Cook
ae1fabae38
Tweak padding according to design
2024-02-01 11:18:15 +11:00
cyrillefr
e6c0afa477
Replace toggle_controller with method inside generic ctrller
...
- move toggle method from toggle_controller inside toggle_control
ctrller
- change corresponding html attributes in view
- mode corresponding spec in toggle_controller ctrller spec
- delete now unused toggle controller + spec
2024-01-25 10:16:02 +01:00
Konrad
d15395a252
Merge pull request #12052 from dacook/hotkeys
...
Hotkey fix
2024-01-24 23:34:50 +01:00
cyrillefr
ca4aa645f7
Delete now ununsed stimulus controller toggle_button_disabled
...
- also delete one comment about replacing this controller with another
2024-01-18 10:10:49 +01:00
David Cook
b4f1709dcd
Remove console.log
...
Oops.
2024-01-17 17:25:24 +11:00
David Cook
6ed74b2bc1
Ensure keyboard shortcut fires event handlers correctly
...
A StimulusReflex form handler was being ignored, resulting in an error.
Note that this method can support angular forms, the submit buttons just need to be updated to type='submit' (why they are not already boggles me).
2024-01-17 17:24:24 +11:00
cyrillefr
8eb5ac990e
Replace toggle_button_disable ctrller with generic toggle_control ctrller
...
- add enableIfPresent method in toggle_control_controller.js to handle enabling on toggle
- add testing in the corresponding spec
- replace in view previous ctrler with intended generic toggle-control
2024-01-16 20:35:21 +01:00
David Cook
627863bdf7
Fix up button colour variables
2024-01-16 13:45:02 +11:00
David Cook
c67f0c52a2
Show edit button only when hover image
...
This required some branching in the haml, which would be nice to avoid. But we have more work to do here so we'll refactor at the end.
2024-01-16 13:45:02 +11:00
David Cook
6ed96bae85
Submit image when selected
...
This could have been done with a tiny amount of inline JS, but I went this way in case I needed any special logic for UJS. It turns out we don't.. but it still looks a bit cleaner this way.
2024-01-16 13:44:34 +11:00
David Cook
137489f492
Refactor: move basic modal styles to generic parent component
...
The style was already being shared with a sibling component.
Now we can instantiate a plain old 'modal'.
2024-01-16 12:53:07 +11:00
David Cook
ca73a9ab62
Reduce space used by image
2024-01-16 12:53:07 +11:00
David Cook
1f61b03796
Add image with edit button
...
With a new 'mini' button style.
For now, it's just a shortcut to the image edit page.
2024-01-16 12:50:31 +11:00
