Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
David Cook
864b95612a
Show error message on variant_unit_name
...
Now passing options through to the error tag
2024-03-06 13:41:22 +11:00
Konrad
2477a63f36
Merge pull request #12103 from basilawwad/selecting-OC-should-redirect-to-shop
...
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected.
2024-02-19 21:51:19 +01:00
basilawwad
08111f9a2c
added shop target and activateshoppanel function
...
Remove Pending Message
Update shopping_spec.rb
Update shopping_spec.rb
2024-02-16 09:27:21 +03:00
Konrad
a30da1f656
Merge pull request #12093 from cillian/generate-invoice-button-warning
...
Display a warning when clicking the generate invoice button if an ABN is required but not present
2024-01-31 21:52:15 +01:00
Konrad
9e6b8e0624
Merge pull request #12047 from rioug/12021-enterprise-fee-tax-on-invoice
...
Include Tax on enterprise fees on the invoice
2024-01-31 15:32:54 +01:00
Cillian O'Ruanaidh
f960dec0eb
Display a warning when clicking the generate invoice button if an ABN is required but not present
2024-01-26 14:28:42 +00:00
Gaetan Craig-Riou
b28e63174d
Update display_line_items_taxes
...
Make sure we add the correct enterprise fee tax amount based on tax
being included in the price or not.
2024-01-23 10:36:43 +11:00
Gaetan Craig-Riou
a77ba5b0b1
Include enterprise fee tax in the line item tax
2024-01-22 13:08:39 +11:00
Konrad
bed405794f
Merge pull request #11762 from binarygit/send-shipment-email-optionally
...
send-shipment-email-optionally
2024-01-18 12:02:00 +01:00
binarygit
75ca1dddf1
Fix tests and rubocop warnings
2024-01-14 15:06:02 +05:45
binarygit
267e749369
Show same dialog box when shipping order through the actions dropdown
2024-01-14 15:06:02 +05:45
Maikel Linke
78e42ec664
Show Connected Apps only to enterprise managers
...
Super-admins also saw that tab but connecting an app doesn't work unless
you are a manager of that enterprise.
2024-01-11 12:20:40 +11:00
Maikel
d197251262
Merge pull request #12026 from dacook/rubocop-autocorrect
...
Autocorrect Rubocop issues
2024-01-11 09:04:49 +11:00
David Cook
18c2b2512b
Safely autocorrect Style/RedundantLineContinuation
...
Inspecting 1530 files
.................................................................................................................................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................
Offenses:
app/helpers/shop_helper.rb:48:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
no_open_order_cycles?(order_cycles) &&
^
app/helpers/shop_helper.rb:48:44: C: [Corrected] Style/RedundantLineContinuation: Redundant line continuation.
no_open_order_cycles?(order_cycles) && \ ...
^
spec/system/admin/configuration/content_spec.rb:35:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_selector :link, "markdown link", href:
^
spec/system/admin/configuration/content_spec.rb:35:65: C: [Corrected] Style/RedundantLineContinuation: Redundant line continuation.
expect(page).to have_selector :link, "markdown link", href: \ ...
^
1530 files inspected, 4 offenses detected, 4 offenses corrected
2024-01-10 09:29:37 +11:00
Dung Bui
ab6a7e307b
remove unused helpers
2024-01-04 00:19:15 +07:00
Gaetan Craig-Riou
9609ba4268
Don't show the banner if no ToS file uploaded
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
aaa8f3f572
Per review, move logic to display ToS banner to a helper
...
It easier to understand when we can see the logic to display the banner
in the view.
2023-12-22 13:20:14 +01:00
Konrad
5f7760c3cc
Merge pull request #11803 from rioug/11801-remove-raw-from-email-template
...
Remove raw from various template
2023-12-22 13:10:33 +01:00
Konrad
4973b5c07c
Merge pull request #11789 from duleorlovic/11784_contact_tab
...
Fix open Contact tab from "customers only" message
2023-12-19 15:05:41 +01:00
Gaetan Craig-Riou
4a32df7ef5
Remove seemingly useless method
...
Left over from Spree, it looks like a weird way to cast somehing to a
string
2023-12-18 14:38:16 +11:00
Dusan Orlovic
120e299653
Use activate instead of changeActivePanel/ChangeActiveTab
...
Remove shop-tabs controllers since we can listen on `"data-action":
"orderCycleSelected@window->tabs-and-panels#activateDefaultPanel"`
Test for cases:
* activate by clicking on tab
* activateDefaultPanel on orderCycleSelected event
* activateFromWindowLocationOrDefaultPanelTarget to activate tab based
on achor in URL
2023-12-16 10:00:17 +01:00
Maikel Linke
d4ce3965b1
Connected apps can be enabled per user or enterprise
2023-12-15 11:22:15 +11:00
Maikel Linke
af2b65256f
Add new enterprise settings tab Connected Apps
2023-12-15 11:22:15 +11:00
David Cook
f99b0b19e7
Disable another OutputSafety warning
...
This one is a little more concerning: what if a model error message includes the user-submitted value? But this is for the admin interface only, and I'm not sure if we have model error messages that do that. So it's probably fine (it's certainly been like this a long time already).
2023-12-13 14:21:27 +11:00
David Cook
0e95b3211b
Disable most OutputSafety warnings
...
These all seem to require html_safe/raw, so we'll permit it.
Some of the spree code is a bit strange and could probably be improved, but I think it's ok for now.
2023-12-13 14:19:19 +11:00
David Cook
dc9fd669a2
Remove unnecessary html_safe calls
...
The tag generator methods should already be returning html_safe strings.
2023-12-13 14:11:02 +11:00
Arun Guleria
d60216787b
11599 Remove whitespace trailing
2023-12-08 09:05:00 +05:30
Arun Guleria
4e408d404b
11599-Change page title on checkout pages
2023-12-08 09:05:00 +05:30
Mohamed ABDELLANI
9ce62cf6af
replace link_to with contant_tag
2023-11-28 15:02:03 +01:00
David Cook
2960f7570e
Merge pull request #11741 from abdellani/fix-product-with-ml-unit-display-dl
...
Fix product with ml unit display dl
2023-11-17 09:41:44 +11:00
Ahmed Ejaz
edc827bdc8
#11606 , adds long time formatting for en.yml
2023-11-16 20:57:40 +01:00
Mohamed ABDELLANI
e10d441153
load GeneralSettingsHelper#all_units from WeightsAndMeasures::UNITS
2023-11-13 09:29:31 +01:00
Mohamed ABDELLANI
fb24678654
update units list on Spree::Admin::GeneralSettingsHelper#all_units
...
added a test to make sure that all units on WeightsAndMeasures::UNITS are list on all_units
2023-11-13 09:29:31 +01:00
Maikel Linke
f6903518c3
Remove orphaned JSON data in admin pages
...
This was left over data from commit:
- 79ba223e12
2023-11-03 15:16:22 +11:00
David Cook
671dc570ec
Refactor: with form builder
2023-10-24 15:21:14 +11:00
Konrad
d7b234c062
Merge pull request #11593 from rioug/11363-vouchers-fix-tax-included-in-price-amount
...
[Vouchers] Fix tax included in price amount
2023-10-13 18:22:11 +02:00
Maikel Linke
f83e78a5b8
Clarify adjustment data only for display
...
We are not creating a new adjustment here.
2023-10-12 15:16:38 +11:00
Maikel Linke
74c8f06e80
Simplify helper with extracted method
2023-10-12 14:17:41 +11:00
Mohamed ABDELLANI
13b366e7ff
list send invoice and print invoice under actions even when the invoice feature is enabled
2023-10-08 21:47:17 +02:00
David Cook
836f5a1fb3
Remove unused withError class
...
It added specificity but had no use.
I reviewed a couple of screens to make sure:
- /admin/orders/Rx/customer
- /admin/properties/new
I have to confess I don't know how Spree::Admin::BaseHelper is included, or where it's used.
Best viewed with whitespace ignored.
2023-10-06 14:15:07 +02:00
Gaetan Craig-Riou
8d639c14cb
Add a fake adjustment voucher tax on admin order page
...
When tax are included in price, voucher tax is stored in the voucher
adjustment and not as its own adjustment. So we add a "fake adjustment"
for display purposes.
2023-10-02 15:58:12 +11:00
Gaetan Craig-Riou
8254bd9625
Take into account voucher tax part when displaying tax included in price
2023-10-02 15:58:12 +11:00
Neal Chambers
4ffd3759cc
Fix Style/HashSyntax
2023-09-12 23:19:05 +09:00
Neal Chambers
416d6e538a
Fix Style/HashSyntax
2023-09-09 09:00:38 +09:00
Gaetan Craig-Riou
8face3d182
Merge pull request #11488 from macanudo527/fix_helperinstancevariable_2
...
Fix Rails/HelperInstanceVariable 2
2023-09-08 19:51:39 +10:00
Filipe
ccabf5936d
Merge pull request #11505 from drummer83/master
...
[Super admin] Highlight 'Configuration' tab on 'Terms of Service' page
2023-09-07 18:00:18 +01:00
drummer83
a7ddf99ee4
Fix typo
2023-09-06 23:20:12 +02:00
Neal Chambers
2da9ffd3cb
Delete Unused Helper Functions
2023-09-06 22:36:51 +09:00
Neal Chambers
b1e40ed605
Fix Rails/HelperInstanceVariable
2023-09-06 22:36:46 +09:00