Luis Ramos
53d901b41b
Merge pull request #5064 from luisramos0/fix_sample_data
...
Fix sample data and custom paper_trail config on order_cycles and schedules on rails 4
2020-04-04 18:29:26 +01:00
Luis Ramos
59bb956677
Merge pull request #5010 from Matt-Yorkley/remove_simple_form
...
Remove simple_form
2020-04-04 11:53:06 +01:00
Luis Ramos
ac0a62e962
Merge pull request #5050 from Matt-Yorkley/bullet_tweaks
...
Performance tweaks 2
2020-03-25 18:32:49 +00:00
Luis Ramos
2e4f8003b6
Fix group factory in rails 4
...
params[:address] was breaking the creation of the EnterpriseGroup
2020-03-25 15:32:16 +00:00
Matt-Yorkley
c82c54873c
Pluck :id when querying active distributors for serializer data
2020-03-23 22:38:55 +01:00
Matt-Yorkley
0b878dd0a2
Use named scope for finding line_items in a set of orders
2020-03-21 09:45:35 +01:00
Matt-Yorkley
45c204017f
Improve reports performance
...
Add the scoping from the search filters for reports into the logic of building sets like `editable_line_items` before combining them into the query to reduce the number of `line_item` ids in the IN clause.
2020-03-21 09:45:33 +01:00
Luis Ramos
0f2e23d225
Merge pull request #4968 from lin-d-hop/customer-balances
...
Revert changes that broke existing usage of this report
2020-03-17 18:06:35 +00:00
Matt-Yorkley
45b5e838b7
Remove simple_form
...
It looks like we don't use this at all. Discovered during the Spree 2.1 upgrade.
2020-03-17 17:03:48 +01:00
Luis Ramos
ffbb5934d7
Merge pull request #4989 from luisramos0/specs_in_engines
...
Adapt task that runs engine specs
2020-03-16 19:17:04 +00:00
Luis Ramos
5da47b3f19
Merge pull request #4757 from luisramos0/stripe_sca_extra
...
StripeSCA - Handle further SCA auth request when checking out
2020-03-16 16:45:28 +00:00
Luis Ramos
b14e4237cc
Make the task that runs engines specs run from the main app, not inside the engine
...
Right now and for some time the engines are not independent of the main_app. We should aim for that but it will naturally take a while to disentangle the code
2020-03-16 16:20:36 +00:00
Pau Pérez Fabregat
2a5311493f
Merge pull request #4969 from luisramos0/oc_apli
...
Fix spec in rails 4 branch by making code in OrderCycleFormApplicator a bit more resilient
2020-03-12 12:51:23 +01:00
Luis Ramos
03246d425d
Make this method handle the case where the variants hash passed is nil
...
This fixes a spec in the rails 4 branch
2020-03-10 18:41:26 +00:00
Luis Ramos
7585e3d1d6
The variants_to_a method was dead but actually we can use it to make the code simpler
2020-03-10 18:40:46 +00:00
lin-d-hop
e4bd7c4e30
Revert changes that broke existing usage of this report
2020-03-10 10:59:18 +00:00
Pau Pérez Fabregat
50cdda7c63
Merge pull request #4802 from luisramos0/too_many
...
Last batch to fix error "subquery with too many columns" in rails 4 branch
2020-03-10 09:20:44 +01:00
Luis Ramos
b54b981740
Improve readability of PaymentIntentValidator and cover with specs
2020-03-02 17:30:12 +00:00
luisramos0
6877485c90
Extract AuthorizeResponsePatcher from stripeSCA gateway
2020-03-02 17:30:12 +00:00
luisramos0
95c1b7f7a6
Extract PaymentIntentValidator from StripeSCA gateway
2020-03-02 17:30:12 +00:00
Luis Ramos
c37218fdc5
Merge pull request #4719 from luisramos0/stripe_card_to_pm
...
Make StripeSCA payment method work with existing credit cards (the ones saved through the Stripe Charges API)
2020-03-02 17:22:07 +00:00
Luis Ramos
dad21a52b2
Merge pull request #4672 from luisramos0/stripe_sca_method
...
Add new Stripe payment method compatible with the new Stripe Payment Intents API
2020-03-02 17:19:05 +00:00
Pau Pérez Fabregat
97a65d760f
Merge pull request #4527 from luisramos0/subs_logs
...
Improve Subscriptions logging
2020-03-02 15:48:45 +01:00
Luis Ramos
60e12063cd
Merge pull request #4758 from luisramos0/fix_incomplete_stripe
...
Make the payment methods filter handle misconfigured stripe payment methods
2020-02-25 18:47:09 +00:00
luisramos0
404e7c1f37
Make credit card cloner clone the payment method even if the customer is not given
...
This makes the payments without saving card work again in the frontoffice as well as the payments taken by the seller in the backoffice
2020-02-21 14:11:13 +00:00
Luis Ramos
ccb4c77d1f
Adapt credit card cloner to not clone card if it's a card to be used only once
...
Adapt stripe_sca specs to new cloner logic
2020-02-21 10:56:32 +00:00
luisramos0
5ef1510fc7
Adapt CreditCard cloner to clone not 'cards of the platform account to payment_methods of the connected accounts' but instead 'cards or payment_methods of the platform account to payment_methods of the connected accounts'
...
This process mimicks the existing process of generating a token on the connected account from a card on the platform account. In the Payment Intents API we need to create a payment method in the connected account, a token is not enough
2020-02-21 10:56:32 +00:00
luisramos0
1afd712ff4
Make StripeSCA store cards (and delete them) on the Stripe platform account and not the Stripe Connected account (the sellers accounts)
...
This is important so that cards can be re-used across sellers in OFN
2020-02-21 10:56:32 +00:00
luisramos0
3fb1df9bb3
Rename CardCloner to CreditCardCloner because it's dependent on Spree:CreditCard attributes
2020-02-21 10:56:32 +00:00
luisramos0
14c03ead31
Extract CardCloner to separate class
2020-02-21 10:56:32 +00:00
luisramos0
b3ac5d8f41
Improve code readability a little
2020-02-21 10:52:56 +00:00
luisramos0
4e84310d63
Add StripeSCA where StripeConnect is treated as an exception in the setting up of process of a payment method and subscriptions
...
Here we are copy pasting and adding stripe SCA because we are planning to delete the StripeConnect that will be replaced by the stripe sca implementation
2020-02-21 10:52:56 +00:00
luisramos0
b8457ebece
Make profile storer a bit easier to read
2020-02-21 10:52:56 +00:00
Luis Ramos
6bb04f6cc6
Adapt stripe_sca_spec to actual stripe SCA API
2020-02-21 10:52:55 +00:00
luisramos0
ac8f3c811f
Fix rubocop issues in some stripe integration related files
2020-02-21 10:52:55 +00:00
luisramos0
ec7b91bb68
Make ProfileStorer a bit easier to read
2020-02-21 10:52:29 +00:00
luisramos0
db1065a69e
Make saving a card on checkout work with the payment intents api by making profile storer work with the slightly different api responses from stripe
2020-02-21 10:52:29 +00:00
luisramos0
5724c3bb0a
Add code from ActiveMerchant v1.98.0 that supports the Stripe Payment Intents API
...
This commit can be reverted once we upgrade to v1.98.0
2020-02-21 10:52:29 +00:00
Luis Ramos
d99cba3b6e
Merge pull request #4709 from mkllnk/4172-js-pluralize
...
Pluralize common variant unit names
2020-02-19 22:28:54 +00:00
Luis Ramos
1eba17f048
Make select column explicit to avoid too many columns sql error
2020-02-18 18:32:52 +00:00
luisramos0
01d69c89aa
Add some log messages to help debug problems in subscription placement and subscription confirmation processes
2020-02-07 10:06:58 +00:00
luisramos0
a2801e40a2
Improve readability of proxy_order_syncer and add some log messages
2020-02-07 10:06:58 +00:00
luisramos0
b0f2e01c70
Delete extra inventory_units that are for some unknown reason connected to shipments of orders to delete but not to orders to delete
2020-02-05 16:30:14 +11:00
Luis Ramos
a8b48a561f
Merge pull request #4733 from lin-d-hop/master
...
Fixing incorrect payment and balance calculation
2020-02-04 18:11:48 +00:00
Luis Ramos
ea75714561
Merge pull request #4635 from luisramos0/main_app_routes
...
Replace use of spree.root_path and root_url with main_app.root_path and main_app.root_url
2020-02-04 16:02:48 +00:00
luisramos0
6e78ae762a
Make it work even if preferred_enterprise_id is null
2020-02-04 10:01:18 +00:00
Maikel Linke
9535c5647f
Make pluralisation code an independent lib
...
I considered moving the code to a service but I think that this code
can be completely independent of the Open Food Network use case. It
would be easy to move to a gem. The downcasing may need reconsidering
for general use.
2020-01-31 09:48:32 +11:00
Maikel Linke
1cce106977
Use our unit name pluralization in Ruby
...
This code will be used for the shop front and reports.
2020-01-31 09:48:32 +11:00
lin-d-hop
baf1ecb436
Fixing incorrect payment and balance calculation
...
Corrections and added specs
2020-01-29 16:06:06 +00:00
Matt-Yorkley
7d36c3b5aa
Make some private methods public in orders_and_fulfillments_report.rb
...
Fixes errors for "call to private method ..."
2020-01-15 13:05:36 +01:00