Luis Ramos
de061b4c54
Make it a keyword argument so it's easier to read
2020-08-31 18:47:24 +01:00
Luis Ramos
c7a5dd65cf
Ensure all specs that change stripe_connect_enable set the value back to what it was before, which should be the default value false
...
This will speed up specs as it ensures the stripe is always disabled and its JS script is not loaded
2020-08-31 18:38:50 +01:00
Luis Ramos
42d5344179
Fix checkout spec by fixing wrong default value
2020-08-31 17:40:34 +01:00
Luis Ramos
12d18b2825
Add specs to checkout_spec to validate terms and conditions link
2020-08-31 17:40:34 +01:00
Luis Ramos
ad111e837e
Add spec to test terms and conditions link on checkout page
2020-08-31 17:40:34 +01:00
Luis Ramos
746533d3f6
Improve spec titles
2020-08-31 17:40:34 +01:00
Luis Ramos
4ef4a58532
Merge two describe sections with same before method and call it what it is: guest checkout
2020-08-31 17:40:34 +01:00
Luis Ramos
685a5465f1
Simplify checkout stripe spec
2020-08-31 17:40:34 +01:00
Luis Ramos
70e9ef93bb
Extract stripe spec from checkout spec so we can expand stripe tests in checkout
2020-08-31 17:40:34 +01:00
Luis Ramos
86ad31eb5c
Reuse checkout form filling code from CheckoutHelper in checkout paypal spec
2020-08-31 17:40:34 +01:00
Luis Ramos
edfd0fd95c
Move checkout helpers to checkout_helper
2020-08-31 17:40:34 +01:00
Luis Ramos
d1f5828d13
Rename checkout_workflow to checkout_helper
2020-08-31 17:40:34 +01:00
Luis Ramos
785f8ada4d
Refactor checkout_spec by removing unnecessary initial describe section
2020-08-31 17:40:34 +01:00
Pau Pérez Fabregat
6e1dd78e9f
Merge pull request #5828 from luisramos0/ent_user
...
Clean up AuthenticationWorkflow spec helper
2020-08-04 12:07:54 +02:00
Luis Ramos
f31d790714
Add auth spec to cover case where user tries to reset password before confirming their email
2020-07-31 09:05:42 +01:00
Luis Ramos
0f29806198
Adapt code to devise 3.2 where the reset_password_token stored in the db is a encrypted version of the token sent in the email
...
In this particular case, the user confirmations controller is redirecting to the reset password page but it doesnt know what is the raw reset_password_token
So we regenerate the reset password token so that it can know what's the raw value for the redirect
The method User#regenerate_reset_password_token is a proxy to the protected method in Devise::Recoverable
2020-07-31 09:05:42 +01:00
Luis Ramos
a2ebc614d9
Rename AuthenticationWorkflow to AuthenticationHelper
2020-07-27 15:32:35 +01:00
Luis Ramos
10b07aabd9
Rename quick_login_as to login_as
2020-07-27 15:32:35 +01:00
Maikel Linke
b0ac188430
Make broken spec fail reliably and set it pending
...
This spec has been broken for a long time, at least eight months. But it
regularly passed because the search filter is applied with a delay and
in that time the content matches. And once the filter is applied, no
products are shown and the negative matchers pass.
2020-07-17 09:28:17 +10:00
Luis Ramos
9c8318d828
Merge pull request #5613 from luisramos0/calculators
...
Move all Calculators from spree to OFN and out of the Spree namespace
2020-07-13 15:16:15 +01:00
Matt-Yorkley
d78db16abe
Merge pull request #5718 from Matt-Yorkley/available-locales-bug
...
Available locales bug
2020-07-08 12:30:18 +02:00
Luis Ramos
5e8438c446
Move all calculators outside the spree namespace
2020-07-07 17:26:23 +01:00
Matt-Yorkley
3d955a952c
Merge pull request #5674 from mkllnk/caching_spec
...
Fix flaky caching spec
2020-07-06 21:56:02 +02:00
Matt-Yorkley
0c2fd4bfd2
Fix ensure_valid_locale_persisted and change public interface of service
2020-07-03 16:39:24 +02:00
Matt-Yorkley
cc7b5e2df3
Add pending test for setting locale from cookies during login
...
This test currently fails
2020-07-03 16:39:23 +02:00
Luis Ramos
d9ab7a8d49
Merge pull request #5667 from mkllnk/shopping-spec
...
Stabilise shopping specs and open them for change
2020-07-02 23:51:25 +01:00
Matt-Yorkley
4e08d2049f
Ensure a valid locale is persisted during login
...
This action has to be performed here and not in I18nHelper, as spree_current_user is not initialized yet during the other checks / setting the selected locale value in the app
2020-07-02 15:33:19 +02:00
Matt-Yorkley
3326366c6e
Add specs for applying stored locales during login
2020-07-02 14:35:58 +02:00
Matt-Yorkley
11da385624
Enable pending checkout spec
2020-06-30 11:30:16 +02:00
Matt-Yorkley
abe96c6f32
Add specs for updating existing default addresses during checkout
...
These specs fail with the "NULL values for created_at / updated_at" errors we've been seeing.
2020-06-30 11:30:14 +02:00
Maikel Linke
e567348a69
Ensure that enough time passes for caching spec
2020-06-26 14:24:01 +10:00
Maikel Linke
4b25c2d49a
Correct typo in file naming
2020-06-26 14:21:21 +10:00
Maikel Linke
d7c9bb2e5a
Navigate more efficiently in spec
...
The spec is not supposed to test the navigation to the shop. Going
directly to the shop reduces the test execution time by 7%.
2020-06-26 09:55:57 +10:00
Maikel Linke
70347148a1
Stabilise shopping specs and open them for change
...
The way we add items to the cart will change. Encapsulating that code in
a common place will make the mobile ux work clearer and avoid merge
conflicts.
The waiting for background requests has also been improved and made more
consistent which should make these specs more reliable.
2020-06-26 09:55:57 +10:00
Maikel Linke
a0c7dc2ccb
Remove leftover empty spec context
2020-06-26 09:55:57 +10:00
Luis Ramos
f848a89a00
Rename update_attributes to update #rails4
2020-06-22 16:51:43 +01:00
Luis Ramos
46a1c1cf26
Fix rubocop issue
2020-06-22 13:08:54 +01:00
Luis Ramos
8a9dae0ee2
Run rubocop autocorrect
...
This is the result of bundle exec rubocop --auto-correct
2020-06-22 12:23:10 +01:00
Matt-Yorkley
444097c75f
Merge pull request #5559 from luisramos0/display_only_shop
...
Make display only shops work again
2020-06-19 11:12:55 +02:00
Matt-Yorkley
5a480439ca
Remove test for items from previous orders looking in cart dropdown
...
This feature has been removed
2020-06-18 22:21:55 +02:00
Matt-Yorkley
042b4fc395
Remove tests for viewing previous order items in cart dropdown
...
This behavior has been removed
2020-06-18 22:21:55 +02:00
Matt-Yorkley
8ac971651c
Fix flaky spec
2020-06-18 22:21:55 +02:00
Matt-Yorkley
459e53f43d
Adjust specs for new cart display
2020-06-18 22:21:55 +02:00
Matt-Yorkley
64b5bde952
Wait for page to actually load after visit shops_path
2020-06-17 12:47:08 +02:00
Matt-Yorkley
86fe032cdb
Update calls to #update_attributes! (Rails 4 Rubocop violation)
2020-06-17 12:37:20 +02:00
Matt-Yorkley
640c9e6d2b
Re-enable flaky spec
2020-06-17 12:36:42 +02:00
Matt-Yorkley
cf214251fa
Set flaky caching spec to pending
2020-06-16 12:59:58 +02:00
Luis Ramos
02b351b9d5
Make display only shops work again, this will show the product list when the OC is open but ship and pay methods are not available
...
Add spec to cover display only shops, it's oficially a feature now :-)
2020-06-12 20:15:08 +01:00
Luis Ramos
48985bbcd1
Use patch instead of put, because it's rails 4
...
Extend the registration process spec to cover package selection
2020-06-01 13:41:37 +01:00
Luis Ramos
f34f693620
Merge branch 'master' into 3-0-stable-may-22
2020-05-22 22:54:19 +01:00
