Pau Pérez Fabregat
426c536750
Merge pull request #5677 from luisramos0/remove_spree_root_path
...
Bring ControllerHelpers from Spree and remove spree root path
2020-07-21 16:15:21 +02:00
Eduardo
bda47d97ee
add view specs to admin edit page
2020-07-20 21:08:04 -03:00
Luis Ramos
62a3b6b720
Merge pull request #5406 from kristinalim/fix/5300-optimistic_locking_in_stock_items
...
5300 Avoid race conditions in Spree::StockItem
2020-07-17 22:24:59 +01:00
Maikel Linke
b0ac188430
Make broken spec fail reliably and set it pending
...
This spec has been broken for a long time, at least eight months. But it
regularly passed because the search filter is applied with a delay and
in that time the content matches. And once the filter is applied, no
products are shown and the negative matchers pass.
2020-07-17 09:28:17 +10:00
Maikel
4e3502cce7
Merge pull request #5766 from mkllnk/5764-fix-pin-payments
...
5764 Provide credit card brand to Pin Payments
2020-07-16 10:28:18 +10:00
Luis Ramos
2605c4249b
Simplify spec, the 2 minutes wait is not necessary anylonger
2020-07-15 14:54:53 +01:00
Luis Ramos
3599cb2047
Make unauthorized in ControllerHelpers::Auth the same as in Spree::Admin::BaseController
...
It adapts the method in ControllerHelpers::Auth to also use the after_login mechanism.
Ideally we would remove one of the two after_login mechanisms after_login and spree_user_return_to but they might still be in use.
2020-07-15 14:54:53 +01:00
Luis Ramos
8fac1bc9ca
Move unauthorized view to HomeController only, all other calls to unauthorized will go through Auth which will redirect to the home controller IF the user is logged in or to login if user is not logged in
2020-07-15 14:54:52 +01:00
Luis Ramos
7f1797de58
Adapt specs to the move of unauthorized route from the spree routes to the main app routes
2020-07-15 14:54:52 +01:00
Luis Ramos
1666ffb191
Remove try_spree_current_user
...
This can be done because the method is defined in OFN's ApplicationController, so spree_current_user is available in all controllers
2020-07-15 14:53:35 +01:00
Pau Perez
70afcee3fc
Fix Spree's spec clashing with a customization
...
`#save_requested_by_customer` is an accessor we added and thus, the
Spree's spec didn't consider.
2020-07-15 14:18:36 +02:00
Matt-Yorkley
c009fed6be
Update StrongParams for Pin Payments
2020-07-15 14:00:19 +02:00
Maikel Linke
25155cab18
Provide credit card brand to Pin Payments
...
Spree replaced the Ruby code providing the credit card brand with a
jquery plugin providing it on the checkout screen.
I re-added Ruby code because it's easier and more robust than updating
the user interface with new Javascript.
2020-07-15 17:13:46 +10:00
Luis Ramos
5835a0ee3a
Transpec mailer specs
2020-07-14 14:20:30 +01:00
Luis Ramos
e96d9c1f45
Fix mailer specs brought from spree_core
2020-07-14 14:19:19 +01:00
Luis Ramos
5162964936
Fix easy rubocop issues
2020-07-14 13:46:01 +01:00
Luis Ramos
d12495f3db
Merge decorators with original classes brought from spree and merge order_mailer specs
2020-07-14 13:38:11 +01:00
Luis Ramos
c6cd695b3c
Bring remaing mailers from spree_core
2020-07-14 13:28:11 +01:00
Luis Ramos
9c8318d828
Merge pull request #5613 from luisramos0/calculators
...
Move all Calculators from spree to OFN and out of the Spree namespace
2020-07-13 15:16:15 +01:00
Luis Ramos
ebf9be41bb
Transpec specs
2020-07-11 17:02:03 +01:00
Luis Ramos
95ffff5087
Fix specs brought from spree
2020-07-11 16:59:35 +01:00
Luis Ramos
03bb1f053a
Fix easy rubocop issues
2020-07-11 16:43:42 +01:00
Luis Ramos
2e3702550d
Bring a number of files from spree_core needed in OFN
2020-07-11 16:09:13 +01:00
Luis Ramos
aed384183b
Move Spree::OrderUpdater to OrderManagement engine
2020-07-11 15:44:23 +01:00
Luis Ramos
7e355a3248
Remove hash rockets
2020-07-11 15:44:23 +01:00
Luis Ramos
a8a81f8023
Merge and fix OrderUpdater spec with Spree::OrderUpdater spec
2020-07-11 15:44:23 +01:00
Luis Ramos
a929d82580
Transpec order_updater_spec
2020-07-11 15:44:23 +01:00
Luis Ramos
1f39731068
Modernize and fix spec brought from spree
2020-07-11 15:44:23 +01:00
Luis Ramos
d2f0d96174
Bring Spree::OrderUpdater spec
2020-07-11 15:44:23 +01:00
Luis Ramos
7b30008e8b
Run transpec
2020-07-11 15:41:26 +01:00
Luis Ramos
50e6ce92b3
Fix easy rubocop issues
2020-07-11 15:41:26 +01:00
Luis Ramos
a78d615936
Bring money_spec from spree_core
2020-07-11 15:41:26 +01:00
Luis Ramos
724a88344e
Run transpec
2020-07-11 15:41:26 +01:00
Luis Ramos
9a09f420c1
Modernize spec
2020-07-11 15:41:26 +01:00
Luis Ramos
12a5a266fd
Fix easy rubocop issues
2020-07-11 15:41:26 +01:00
Luis Ramos
eb4d648a23
Comment this very flaky spec for now
2020-07-10 19:27:31 +01:00
Luis Ramos
7a9f9a5624
Log bugsnag and still send failed payment email when any exception is caught during the confirmation process
2020-07-10 13:14:05 +01:00
Pau Perez
683794636b
Rename spec file
2020-07-10 11:57:36 +02:00
Pau Perez
2f4648342f
Merge decorator specs with Spree's ones
...
They are now isolated from each other.
2020-07-10 11:50:20 +02:00
Pau Perez
562f397b22
Isolate Spree's specs into their own context
...
This way we don't mix contexts while merging in our own decorator tests.
2020-07-10 11:46:59 +02:00
Pau Perez
8fbbb0bb64
Bring back our card factory modification
...
Merging Spree's an our factory didn't really work.
2020-07-10 11:42:56 +02:00
Pau Perez
3fb6193098
Move adjustments logic from decorator into model
2020-07-10 10:41:44 +02:00
Pau Perez
861726200c
Move localize_number from decorator to model
2020-07-10 10:41:44 +02:00
Pau Perez
48910aeb77
Move #refund! to the processing.rb
2020-07-10 10:41:44 +02:00
Pau Perez
eafaa97b0e
Temporarily skip spec
...
I'll move on to other easier issues and get back to it when we're in
a better position.
2020-07-10 10:41:44 +02:00
Pau Perez
31d0d4bcae
Fix error "no parent is saved"
...
The exact error is
```
ActiveRecord::RecordNotSaved:
You cannot call create unless the parent is saved
```
raised from app/models/spree/payment_decorator.rb:29:in `ensure_correct_adjustment'
2020-07-10 10:41:44 +02:00
Pau Perez
9935df9f2d
Move Pin payment method from decorator into model
2020-07-10 10:41:44 +02:00
Pau Perez
0ad8dcc2c5
Fix payment log entries specs
...
The tight coupling between doesn't give other option but to check the
private method is called. The specs successfully stub
`log_entries#create` but for some reason the model instance that gets
evaluated it's not the stubbed one.
2020-07-10 10:41:44 +02:00
Pau Perez
a01f601363
Fix yet another spec
2020-07-10 10:41:44 +02:00
Pau Perez
e1ea5dbcb3
Fix all but the 7 last payment specs
2020-07-10 10:41:44 +02:00
