Carlos Chitty
58a16d89a3
Correct Style/RedundantInitialize rubocop offense
2025-03-26 11:16:24 -04:00
Carlos Chitty
9c8e0899d1
Correct Style/CaseEquality rubocop offense
2025-03-26 11:16:20 -04:00
Carlos Chitty
ba693e3ecf
Autocorrect rubocop offense Style/RedundantAssignment
2025-03-25 13:33:50 -04:00
Gaetan Craig-Riou
11e08dcc26
Revert "Update line items enterprise fee instead of deleting and recreating "
2025-03-19 09:40:02 +11:00
Gaetan Craig-Riou
afb25a5209
Merge pull request #13209 from cyrillefr/FixRubocopLintIssuesIV
...
Fixes some rubocop linting offenses - part IV
2025-03-18 09:43:01 +11:00
cyrillefr
e26d591d24
Fixes some rubocop linting offenses - part VI
2025-03-12 21:23:49 +01:00
Gaetan Craig-Riou
f2c3ab8b03
Per review, improve test expectation
2025-03-11 10:37:49 +11:00
Gaetan Craig-Riou
12a54dd8f0
Move #recreate_all_fees! spec to HandleFeesService
...
Spree::Order just delegate Orders::HandleFeesService so there is no
point testing fees in the order spec
2025-02-19 15:13:35 +11:00
Gaetan Craig-Riou
e87477b679
Refactor EnterpriseFee.clear_all_adjustments
...
Renamed to clear_order_adjustments, it doesn't clear line item
adjustment
2025-02-10 16:28:19 +11:00
Gaetan Craig-Riou
0f1b81cc3e
Refactor spec
2025-02-10 16:10:13 +11:00
Filipe
32c4b4557b
Merge pull request #13086 from rioug/fix-tax-rate-refund
...
Remove tax rate refund code path
2025-01-30 21:54:30 -06:00
Filipe
e2161660b3
Merge pull request #13090 from mkllnk/replace-spree-roles
...
Replace spree roles
2025-01-30 21:30:56 -06:00
Gaetan Craig-Riou
900b751559
Revert change from d58aa2b14f44fa15b67a18cf3457eccaaca5a56c
...
Turns out there seem to be a legitimate use for this code, see
spec/system/admin/adjustments_spec.rb ie, adding a manual discount to an
order using an adjustment.
2025-01-27 11:02:50 +11:00
Gaetan Craig-Riou
cd7e92c6ca
Fix various spec
2025-01-27 11:02:41 +11:00
Gaetan Craig-Riou
6b7373e4cf
Clean up spec syntax
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
6e8eb443c1
Consolidate .adjust specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
42df158669
Fix TaxRate#compute_amount
...
Remove the code path that can create a tax refund, it is unlikely to
happen with the configuration our instances are using. Instead return 0
do that no adjustment gets created
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
5e42a9be55
Fix TaxRate spec to work with the zone changes
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
a953e3dde3
Fix Spree::Zone spec and factory
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
75c0752340
Sree::Zone, require at least one member
...
Add validations and specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
bcb4525cdd
Clean up spec, use describe instead of context
...
Although `describe` and `context` are functionally equivalent, they
don't convey the same message
2025-01-27 11:01:07 +11:00
Konrad
01036e6321
Merge pull request #13087 from mkllnk/stock-location
...
Remove class Spree::StockLocation
2025-01-25 12:41:37 +01:00
David Cook
f6bd1c49ee
Apply suggestions from code review
2025-01-24 14:52:54 +11:00
Filipe
5d360730c7
Merge pull request #13023 from rioug/12907-fix-checkout-shipping-fee
...
[Checkout] Shipping fees update, remove order callback
2025-01-23 18:50:31 -06:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Maikel Linke
70ebe7b964
Remove stock location from specs
2025-01-22 11:52:25 +11:00
Maikel Linke
f098327808
Remove now useless wrapper method
2025-01-22 11:31:27 +11:00
Maikel Linke
87d20877ad
Remove Shipment#stock_location
2025-01-22 11:20:05 +11:00
Maikel Linke
33c6f3b94f
Remove StockLocation#stock_item
2025-01-22 11:20:05 +11:00
Maikel Linke
aa9daed66e
Remove unused StockLocation#stock_items
...
And the reverse association.
2025-01-22 11:20:05 +11:00
Maikel Linke
450576a938
Remove unused StockLocation#count_on_hand
2025-01-22 11:20:04 +11:00
Maikel Linke
1650ccd55a
Remove unused StockLocation#backorderable?
2025-01-22 11:20:04 +11:00
Maikel Linke
531c068347
Remove StockLocation#fill_status, now on Variant
2025-01-22 11:20:04 +11:00
Maikel Linke
a4b92f289c
Move fill_status spec to prepare removal from StockLocation
2025-01-22 11:20:04 +11:00
Maikel Linke
68a0f8df1f
Remove detour via StockLocation updating stock
2025-01-22 11:20:04 +11:00
Maikel Linke
248110cfb3
Make stock location association optional
...
Prepare for removal
2025-01-22 11:20:04 +11:00
Maikel Linke
917e0ff01a
Remove unnecessary storage of currency
2025-01-21 20:11:05 +01:00
Gaetan Craig-Riou
fcd366cc06
Fix spec
...
Payment needs to be linked to the order, in order for the payment
callback to update `order.payment_total`
2025-01-21 10:52:32 +11:00
Gaetan Craig-Riou
d7ae91c23e
Per review, specify the actual expected value
2025-01-20 16:21:19 +11:00
Gaetan Craig-Riou
17e7f7d26d
Small linting fix
2025-01-20 16:16:00 +11:00
Gaetan Craig-Riou
c71ae35685
Fix payment_total calculation
...
For payment that complete during the checkout (Paypal, Stripe) the
amount was recorded twice against `order.payment_total`. This is because
the `payment_total` gets updated in an afer_save Payment callback when a
payment is completed, and then once more when we process payment in
`Spree::Order#process_each_payment`.
This is an existing issue on master, but it was hidden by the
`update_shipping_fees!` callback, it trigerred an update of the order's
total, which then updated `order.payment_total` with the correct value.
Now that we removed the callback, the bug showed up.
Note, I updated the stripe specs for consistency even though they are
currently disabled.
2025-01-20 16:07:32 +11:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
Gaetan Craig-Riou
9e7e40a5a8
Update spec to properly test shipping fee update
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
f9bd720341
Add spec for #update_shipping_fees!
...
And update related specs
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
20df5c23e8
Remove before save callback to update shipping fees
...
It should be handled in the controller, it's currently handled in
`Spree::OrderContents#remove`. As long as we don't manually remove line
item from an order we should be good.
Currently it gets trigerred each time the order is saved, which seems to
happen mutiple time when we finalize an order. It's a bit useless to
recalculated the fees over and over
Context, it was added here : 217eda8362
2025-01-15 15:44:24 -06:00
Filipe
5fdd0e5d42
Merge pull request #12954 from rioug/fix-shipment-not-updated
...
Ensure shipment gets updated when an order is updated
2024-12-26 15:56:12 -06:00
Maikel Linke
54f83b45c8
Replace has_spree_role? with simpler admin?
...
We have only one role, so let's get rid of the unneeded method.
Now we are in a better place to get rid of Spree::Role and replace it
with a simple boolean.
2024-12-19 09:19:01 +11:00
Ahmed Ejaz
3e031ab735
13026: reset variant unit name if unit is not items
2024-12-11 03:14:11 +05:00
Ahmed Ejaz
93a3130851
12973: add specs
2024-12-05 16:18:21 -06:00
Gaetan Craig-Riou
cedf040b47
Per review, test on create and update
2024-12-04 22:15:56 +11:00
