10111 Commits

Author	SHA1	Message	Date
Matt-Yorkley	42d04b6581	Update OrderAvailableShippingMethods service	2023-08-14 21:02:47 +01:00
Matt-Yorkley	c18c525d9f	Save shipping category selection to new variant when creating a new product	2023-08-14 21:02:47 +01:00
Konrad	99daab07b7	Merge pull request #11297 from mkllnk/require-belongs-to--part2 ... Require belongs_to associations by default	2023-08-12 17:09:03 +02:00
Rachel Arnould	5afe45d922	Merge pull request #11382 from jibees/11273-buu-remove-new_products_page-feature-toggle ... 🔧 Remove `new_products_page` and all associated controllers/components/...	2023-08-11 11:43:49 +02:00
Gaetan Craig-Riou	9c9a6234e1	Per review, clean up voucher specs ... Add explicit 'order.item_total' to make specs more readable	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	054eac0822	Use a better describe ... Co-authored-by: David Cook <david@redcliffs.net>	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	3f63cfbc27	Fix Rubocop warning	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	e8b374d0f2	Remove left over comment	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	2828bd098d	Refactor VoucherAdjustment service ... We are taking advantage of having a FlatRate and a PercentageRate model to simplify the code a little	2023-08-11 15:41:34 +10:00
Gaetan Craig-Riou	29a38467d2	Fix admin pages to work with refactored vouchers	2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou	46e04ca7ee	Refactor voucher: 3 percentage rate voucher	2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou	def594ab81	Refactor voucher: 2 FlatRate voucher	2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou	204f3933d0	Refactor voucher: 1 base voucher class ... Refactor voucher to use a single table inheritance. It will simplify the code and remove a bunch of conditional	2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou	959e2308dd	Add system specs for percentage based voucher ... Similar to tax included in price scenario, adds a test for percentage based voucher to check the adjustments are recalculated when needed. Plus fix tax incluced in price specs to use new factory	2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou	cdb33aa0d0	Add calculation for percentage voucher ... It include calculation for order with taxes included in the price	2023-08-11 14:30:48 +10:00
Gaetan Craig-Riou	cc9069e9c6	Add voucher type to admin screen ... Plus specs	2023-08-11 14:19:26 +10:00
Gaetan Craig-Riou	619285ad4a	Add voucher_type to voucher ... And update related specs voucher_type doesn't do anything for now.	2023-08-11 14:19:25 +10:00
Gaetan Craig-Riou	1be8daaf86	Add specs to cover re calculation ... It is important that the calculated voucher adjustments don't change if they are recalculated and it is equally important that they are updated if the order has changed	2023-08-11 14:19:25 +10:00
Maikel Linke	a34a351cee	Stabilise flaky spec with deterministic row order	2023-08-11 10:14:47 +10:00
Maikel	146b09dc57	Spec EnterpriseFee tax_category association ... Co-authored-by: David Cook <david@redcliffs.net>	2023-08-11 10:14:47 +10:00
Maikel Linke	efbf1d6b8f	Stabilise flaky assertion on PDF text ... The PDF reader can't always place text elements in the right place. So something that should be in one line can be in multiple lines and those lines can be in a different order. I'm asserting the moving parts separately as done in other places of this spec.	2023-08-11 10:14:47 +10:00
Maikel Linke	1b6eeb0928	Reduce line length of PaymentMethod class ... Rubocop was complaining. So I found code that could be simplified and specced it before refactoring.	2023-08-11 10:14:47 +10:00
Maikel Linke	e6c679cb34	Apply belongs_to_required_by_default to all models ... Unless they state otherwise. The new standard also changes the default behaviour of the Shoulda matcher in Rspec. It now defaults to asserting that an association is required. That needed some spec updates. In one case, Spree::Product, I also had to update the model because the presence validation was somehow not recognised by the Shoulda matcher. The error message may change slightly but the outcome should be the same.	2023-08-11 10:14:47 +10:00
Maikel Linke	4dd2955400	Require EnterpriseRelationshipPermission.belongs_to by default ... I had to change some specs to keep them simple but I don't think anything is broken. In one case, it would have needed a lot more setup to make the spec work. But in production, the permissions are never used with ModelSet, for example.	2023-08-11 10:13:48 +10:00
Maikel Linke	4b630f187b	Require EnterpriseGroup.belongs_to by default	2023-08-11 10:13:10 +10:00
Maikel Linke	13b2f37884	Require EnterpriseFee.belongs_to by default	2023-08-11 10:13:09 +10:00
Maikel Linke	87ccfc94ef	Require Enterprise.belongs_to by default ... And remove a duplicate spec.	2023-08-11 10:13:09 +10:00
Konrad	60212f92c3	Merge pull request #11270 from rioug/9553-removing-cutomer-tag-when-search-for-tag ... Fix removing customer tag when using search bar for said tag	2023-08-11 00:11:55 +02:00
Konrad	c3414143e6	Merge pull request #11222 from Matt-Yorkley/checkout-controller ... Reduce controller size	2023-08-10 23:28:57 +02:00
Konrad	f59e681826	Merge pull request #11259 from cillian/single-line-voucher-code ... Don't allow multi-line voucher codes	2023-08-10 23:09:55 +02:00
Jean-Baptiste Bellet	3b68674896	Remove new_products_page and all associated controller/components/ ... new_products_page` is dead, long live `admin_style_v3` !	2023-08-10 10:02:45 +02:00
jibees	f58fedfc86	Merge pull request #11376 from mkllnk/flaky-voucher-spec ... Stabilise flaky checkout spec with voucher	2023-08-10 09:10:59 +02:00
Maikel	8db8d6de8d	Merge pull request #11372 from Matt-Yorkley/remove-variant-position ... Remove unused variant :position attribute	2023-08-10 11:48:55 +10:00
Maikel Linke	04bba2adf1	Stabilise flaky checkout spec with voucher ... While applying a voucher the spec tried to proceed the checkout before the voucher update completed rendering. It failed when the machine was slow. With rspec-slow-repeate I got 100% fail rate before and 100% pass after this change.	2023-08-10 10:05:01 +10:00
Mohamed ABDELLANI	620dd70dd7	rename 'new invoice' button to 'create or update invoice'	2023-08-10 09:35:13 +10:00
Matt-Yorkley	a33b6e0ec9	Update variant sorting	2023-08-09 18:30:56 +01:00
Matt-Yorkley	e65efe0f85	Remove unused variant :position attribute	2023-08-09 18:24:46 +01:00
Rachel Arnould	4505beff98	Merge pull request #11327 from bouaik/fix-display-invoice-tab-for-completed-resumed-canceled-only ... Fix display invoice tab for completed, resumed and canceled orders only	2023-08-09 18:37:02 +02:00
Rachel Arnould	2b108dfeee	Merge pull request #11116 from abdellani/fix-show-date-only-on-invoices-list ... render date without time on invoices list	2023-08-09 14:33:40 +02:00
Konrad	89d8fa0306	Merge pull request #11346 from Matt-Yorkley/remove-multiple-taxons ... [Product Refactor] Remove multiple taxons	2023-08-09 11:19:11 +02:00
Maikel	b50fa216eb	Merge pull request #11117 from rioug/10857-voucher-error-moving-between-summary-and-cart-take2 ... [vouchers] error moving between summary and cart pages	2023-08-09 11:14:52 +10:00
David Cook	a9ca07f4fb	fixup Update specs ... Delete empty describe block	2023-08-08 11:36:31 +01:00
Matt-Yorkley	321047d663	Update specs	2023-08-08 11:36:31 +01:00
Matt-Yorkley	e4a49f5d02	Update product duplication	2023-08-08 11:36:31 +01:00
Matt-Yorkley	8d01e1f024	Update taxon specs	2023-08-08 11:36:31 +01:00
Matt-Yorkley	3898af2c37	Update factories and tests	2023-08-08 11:36:31 +01:00
Matt-Yorkley	a93809b75f	Remove associated abilities	2023-08-08 11:36:31 +01:00
Gaetan Craig-Riou	6f10907555	Fix rubocop warnings	2023-08-08 15:37:05 +10:00
Gaetan Craig-Riou	4e468c81f9	Handle updating customer attribute when directive is destroyed ... Handle any customer attribute not just tags	2023-08-08 15:29:22 +10:00
Gaetan Craig-Riou	41dbad629b	Add system spec to cover deleting data when filtering ... covers tag scenario and code scenario	2023-08-08 15:29:22 +10:00