Maikel
014fb69d4b
Merge pull request #10964 from macanudo527/fix_linelength_bundle1
...
Fix Layout/LineLength - Bundle 1
2023-06-26 12:10:39 +10:00
Maikel
e065910d2d
Merge pull request #10939 from Matt-Yorkley/master-variants
...
Remove master variants
2023-06-23 13:42:58 +10:00
David Cook
3bff7a9f13
Fix query
...
With deep nesting syntax.
I chose the longer alias 'left_outer_joins' because it's more explicit, and matches the use up on line 121.
2023-06-23 09:11:03 +09:00
Neal Chambers
1e4034534c
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
Matt-Yorkley
776eac9f52
Add image error Bugsnag notifications
2023-06-20 14:14:19 +01:00
Matt-Yorkley
c6ec13443e
Drop next_invoice_number method from Spree::Order
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0ed7599267
extract methods related to invoices from the order model to the OrderInvoiceComparator
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
61d58df56f
fix linter issues
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
d86173c509
add feature toggle
...
seperate the invoice templates that rely on presenters from the old ones.
2023-06-18 21:03:13 +02:00
Mohamed ABDELLANI
0fbf88190e
Generate invoice model
...
There are three main components:
1. The invoice model
2. order serializers: serialize the order for the invoice
3. data presenters: the object that will be use to access the order's serialize data
2023-06-18 21:03:13 +02:00
Matt-Yorkley
ae24b2d688
Update ScopeVariantsForSearch logic to match both product and variant SKUs
2023-06-16 21:26:28 +01:00
Matt-Yorkley
733dd3c428
Disable variant is_master column
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1daab8994d
Remove is_master and not_master scopes
2023-06-16 21:23:44 +01:00
Matt-Yorkley
85059bfb26
Remove master variant validation conditionals
2023-06-16 21:23:44 +01:00
Matt-Yorkley
1922598d2d
Reorganise associations, validations, scopes and callbacks for clarity
2023-06-16 21:23:44 +01:00
Matt-Yorkley
3ef7d2c9ff
Remove master variant from product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
7dc1091bc2
Migrate product image from master variant to product
2023-06-16 21:23:44 +01:00
Matt-Yorkley
d8649fc9fb
Migrate master variant :sku to product
2023-06-16 21:21:40 +01:00
Matt-Yorkley
6b9b5ea347
Stop storing unit_value and unit_description on master variant
2023-06-16 21:21:40 +01:00
Matt-Yorkley
8c0b8dad85
Stop using master variant for storing :display_as value
2023-06-16 21:21:40 +01:00
Matt-Yorkley
1b06c20197
Stop using master variant as a potential store for prices
2023-06-16 21:21:40 +01:00
Matt-Yorkley
d4188da7c1
Simplify product images delegation mess
2023-06-16 21:21:40 +01:00
Matt-Yorkley
42a5a48816
Remove dead code
2023-06-16 21:21:40 +01:00
Matt-Yorkley
7068df5d4b
Merge pull request #10804 from Matt-Yorkley/public-images
...
Update ActiveStorage image processing
2023-06-15 15:49:11 +01:00
Matt-Yorkley
5ad37ce6a5
Return default image url on ActiveStorage errors in image loading
2023-06-14 12:53:20 +01:00
Matt-Yorkley
b510668ecf
Render direct URLs for s3 images
2023-06-14 10:56:10 +01:00
Matt-Yorkley
551d0d3a93
Simplify calling #url_for in models
2023-06-14 10:56:10 +01:00
Matt-Yorkley
a898915724
Use named image variants
2023-06-14 10:56:10 +01:00
Matt-Yorkley
e54cff2274
Set images to public-read
...
Defining an alternate s3 configuration set to `public: true` means we can use it selectively. It sets the objects to `acl: "public-read"` by default (read-only) and means any image tags for those assets can use direct public links in the src attribute (without hitting the ActiveStorage::Representation endpoint). The default non-public service will still be used by default for any other files on instances using s3.
2023-06-14 10:56:10 +01:00
Maikel Linke
d88781a083
Start to adopt new default to require belongs_to
...
Newer version of Rails have this option as default. We can slowly
transition to opt in gradually, model by model. Once all models are
covered, we can change the default and remove the setting from the
models again.
The style violation was added to the todo file because it's temporary.
We have 60 models using `belongs_to`. And changing them all at once
breaks some specs. So let's do it gradually.
2023-06-14 15:06:59 +10:00
Matt-Yorkley
4e7fab6914
Delete dead code Checkout#find_transition
...
This method is only called from tests and nowhere else in the codebase. We may as well remove it.
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
907c65d98c
run create_tax_charge! after transition to payment state
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
c2aaf88e98
remove checkout controller
2023-06-13 14:58:16 +01:00
Gaetan Craig-Riou
41b3ddae08
Merge pull request #10714 from macanudo527/fix_linelength
...
Fix Style/LineLength
2023-06-12 09:53:23 +10:00
Matt-Yorkley
24200de8dd
Require localized_number in Payment class
...
There seems to be some contexts (jobs for subscriptions) where the Payment class loads but LocalizedNumber is an undefined constant. It lives in the /lib directory so it's not auto-loaded.
2023-06-09 18:16:37 +01:00
Neal Chambers
9a8551e3ea
Shorten Where Statement
2023-06-09 16:39:29 +09:00
Matt-Yorkley
f4261b85b8
Merge pull request #10940 from Matt-Yorkley/order-tidyup
...
Order class tidyup
2023-06-08 15:06:59 +01:00
Matt-Yorkley
bf051fc35b
Pull checkout-workflow-related callback methods out into the Checkout module which defines checkout state changes
2023-06-07 18:54:20 +01:00
Matt-Yorkley
760bf269ca
Pull validations-related methods out into a separate module
2023-06-07 18:54:20 +01:00
Matt-Yorkley
e88843c733
Ensure order number is generated nicely on new records
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Matt-Yorkley
7c72969792
Move Order #state_changed method out into Checkout concern (alongside order states logic)
2023-06-05 23:54:04 +01:00
Matt-Yorkley
a62e51c0d0
Remove Order #refresh_shipment_rates method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
1a7d70772a
Make Order #products_available_from_new_distribution method private
2023-06-05 23:54:04 +01:00
Matt-Yorkley
3dd4e7ef03
Delegate order updater method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
8a27dd84fe
Make Order #disallow_guest_order method private
2023-06-05 21:30:49 +01:00
Matt-Yorkley
05a715a43a
Remove Order #distribution_set? method
2023-06-05 21:30:46 +01:00
Matt-Yorkley
17b10d10c0
Make Order #deliver_order_confirmation_email method private
2023-06-05 21:30:43 +01:00
Matt-Yorkley
10dbeb32b2
Remove Order #credit_cards method
2023-06-05 21:30:40 +01:00
Matt-Yorkley
b3bd112cdb
Remove Order #shipped_shipments method
2023-06-05 21:30:36 +01:00
