Matt-Yorkley
d55079f474
Extract comment-method
2021-07-25 22:47:40 +01:00
Matt-Yorkley
5da545c751
Improve adjustment listing in UI
2021-07-25 22:47:40 +01:00
Matt-Yorkley
cb039fd880
Delete dead code Adjustment#display_included_tax
2021-07-09 21:49:36 +01:00
Matt-Yorkley
12c9914d1b
Delete old Adjustment scopes #with_tax and #without_tax
2021-07-09 21:49:36 +01:00
Matt-Yorkley
0876f2ae0d
Remove tax rate guessing from TaxRateFinder
...
🎉
2021-07-09 21:49:36 +01:00
Matt-Yorkley
f2e63fff2e
Delete dead code TaxRate: #compute_tax and #with_tax_included_in_price
...
🎉
2021-07-09 21:49:36 +01:00
Matt-Yorkley
33fc5bbaa2
Delete dead code TaxRate#compute_tax
...
🎉
2021-07-09 21:49:36 +01:00
Matt-Yorkley
b3f5780862
Refactor OrderTaxAdjustmentsFetcher
...
Note: we're only dealing with tax adjustments here, and each adjustment has a single associated tax rate, not multiple.
2021-07-09 21:49:35 +01:00
Matt-Yorkley
c60554a14a
Update display of associated tax amounts
2021-07-09 21:49:35 +01:00
Matt-Yorkley
ad1b9f3f2f
Update Adjustment#has_tax?
2021-07-09 21:49:35 +01:00
Matt-Yorkley
c16e008ba1
Delete dead code Adjustment#set_absolute_included_tax!
2021-07-09 21:49:35 +01:00
Matt-Yorkley
9215d3292b
Remove edit/delete buttons for shipping and payment adjustments
2021-07-09 21:49:35 +01:00
Matt-Yorkley
ea9724a671
Remove dead code #adjustment_tax_amount and #no_tax_adjustments?
2021-07-09 21:49:35 +01:00
Matt-Yorkley
02fc3089d6
Remove dead code OrderTaxAdjustmentsFetcher#all
2021-07-09 21:49:35 +01:00
Matt-Yorkley
18e5fd19fa
Update admin adjustment edit forms
2021-07-09 21:49:35 +01:00
Matt-Yorkley
f037bda1de
Replace callback for applying tax to an admin adjustment
...
🎉
2021-07-09 21:49:35 +01:00
Matt-Yorkley
0c369b618d
Remove code that guesses what the tax rate might be
...
🎉
2021-07-09 21:49:35 +01:00
Matt-Yorkley
65eb33ad9e
Only update totals and states in AdjustmentsController
...
Avoids unnecessary updating of all other adjustments
2021-07-09 21:49:35 +01:00
Matt-Yorkley
e8d610f9df
Remove dead code AdjustmentsController#enable_updates
2021-07-09 21:49:35 +01:00
Guido Oliveira
9bc41cf04f
Add translations to shopfront sorting placeholders
2021-07-07 14:39:10 -03:00
Andy Brett
46cd05c54a
Merge pull request #7712 from guidoDutra/1861-enable-shopfront-sorting-by-producer
...
Enable sorting by producer in shopfront
2021-07-06 09:27:42 -07:00
Andy Brett
ff3784ad3f
Merge pull request #7851 from apricot12/view_deleted_payments_in_admin
...
Allow viewing of payments made with deleted pyment methods in admin
2021-07-06 07:24:42 -07:00
Andy Brett
3e860f6d54
Merge pull request #7781 from andrewpbrett/decouple-payments
...
Decouple payments
2021-07-01 18:07:01 -07:00
Matt-Yorkley
a0b9eff2c1
Merge pull request #7699 from guidoDutra/1971-inventory-page-field-validation
...
Add validation to inventory page fields
2021-07-01 16:59:20 +02:00
Nihal Mohammed
5e7d4bf0c3
Allow viewing of payments made with deleted pyment methods in admin
2021-07-01 19:29:16 +05:30
Pau Pérez Fabregat
f6e0b9af0e
Merge pull request #7646 from apricot12/advanced_settings_button_OC_edits
...
Add advanced settings button to incoming and outgoing pages in OC cyc…
2021-07-01 15:37:16 +02:00
Andy Brett
e9a00eb0d4
Merge pull request #7310 from cillian/resumed-order-actions-menu
...
Make sure the Resend Confirmation and Send/Print Invoice links display for resumed orders
2021-06-30 10:43:07 -07:00
Nihal Mohammed
18282a6f73
Add advanced settings button to incoming and outgoing pages in OC cycle edit
2021-06-30 09:50:38 -07:00
Nihal Mohammed
c335ec3b29
# This is a combination of 5 commits.tree d6d4f31283e42c44c9c4d116567ce7b1a99a13ab
...
parent b680697af6
author Nihal Mohammed <mnihal64@outlook.com > 1621004464 +0530
committer Nihal Mohammed <mnihal64@outlook.com > 1621022463 +0530
# This is a combination of 4 commits.
# This is the 1st commit message:
Add advanced settings button to incoming and outgoing pages in OC cycle edit
# This is the commit message #2 :
Remove extra header text
# This is the commit message #3 :
Moved repeating code blocks to partial
# This is the commit message #4 :
Refactored code
# This is the commit message #5 :
Delete _advanced_settings_hidden.html.haml
2021-06-30 09:50:38 -07:00
Cillian O'Ruanaidh
2bb406fe6a
Don't show the Notifications setting for profile only enterprises in the Users settings section
...
If a enterprise has only set up a profile they won't be getting any order notification emails so showing this setting could be confusing.
#1797
2021-06-30 09:48:08 -07:00
Andy Brett
a97b5b7c90
rename payment state machine events to be verbs
2021-06-29 11:54:51 -07:00
Andy Brett
9b1da14380
mark payment failed after failed authorization
2021-06-29 11:54:51 -07:00
Andy Brett
f61fbee52a
refactor to advance_to_state method
...
this leaves `advance_order!` as is since it's not directly touched by this PR and the metaprogramming looks like it would decrease readability
2021-06-29 11:54:51 -07:00
Andy Brett
aa8067f96b
process payments separately from completing the order
2021-06-29 11:54:48 -07:00
Andy Brett
d2701226b6
complete order immediately before adding payment
2021-06-29 11:45:33 -07:00
Andy Brett
1a6257257a
Merge pull request #7608 from luisramos0/rails61
...
[Rails 6.1] Upgrade to rails 6.1
2021-06-29 10:21:15 -07:00
Andy Brett
e24d2e5077
address deprecation warning
2021-06-29 09:17:31 -07:00
Andy Brett
7b87476986
Merge pull request #7804 from Matt-Yorkley/default-taxrate-check
...
Ignore potential error in dev where default tax rate is nil
2021-06-28 10:35:09 -07:00
Andy Brett
07a2a584c3
remove calls to ssl_allowed as well
2021-06-24 12:06:34 -07:00
Andy Brett
334b9b520a
removed deprecated calls to force_ssl; rely on config.force_ssl
2021-06-24 11:58:33 -07:00
Andy Brett
df0c98d013
Merge branch 'master' into rails61
2021-06-24 08:02:58 -07:00
Nihal Mohammed
edca260af4
Hide shipped orders from BOM and update specs
2021-06-24 18:26:39 +05:30
Andy Brett
e37a065f10
Merge pull request #7281 from coopdevs/refactor-subs-placement-job
...
Refactor subs placement job
2021-06-23 11:47:50 -07:00
Andy Brett
ca7b1f047b
Merge pull request #7780 from apricot12/new_payment_method_html_bug
...
Fix HTML bug on new payment method page
2021-06-23 08:58:45 -07:00
Pau Perez
1f3560e964
Pass in the order when it's already initialized
...
At `CapQuantity`'s instantiation time the proxy's order is not yet
initialized, and so `CapQuantity` was checking against nil all the time.
This went unnoticed because the job's specs were not integration-level
tests and were stubbing way too many things.
2021-06-23 13:47:42 +02:00
Pau Perez
827faef690
Fix call to #record_and_log_error
2021-06-21 10:30:12 +02:00
Pau Perez
b69aeae892
Rename PlaceOrder to PlaceProxyOrder
...
As discussed in
https://github.com/openfoodfoundation/openfoodnetwork/pull/7281#discussion_r650183813 .
2021-06-21 10:30:12 +02:00
Pau Perez
f92ca964db
Improve service name
...
As discussed in
https://github.com/openfoodfoundation/openfoodnetwork/pull/7281#discussion_r650069982 .
2021-06-21 10:30:12 +02:00
Pau Perez
8bcb19f293
Split method into higher-level smaller methods
2021-06-21 09:49:07 +02:00
Pau Perez
f61cdb6608
Extract CapQuantityAndStoreChanges service
...
This is a responsiblity of its own that makes the job's tests really
complex.
2021-06-21 09:49:07 +02:00