Luis Ramos
7cc034c2bc
Merge pull request #4136 from mkllnk/4018-synchronise-checkout
...
Lock variants during checkout to avoid race condition
2019-11-27 15:40:28 +00:00
Maikel Linke
4288428c70
Separating concurrency spec as it's entirely different
2019-11-19 18:18:01 +11:00
Maikel Linke
dc122a9450
Fix infinite loop in spec
...
The spec was setting the order's state to "complete" but didn't save
that state to the database. The new locking mechanism is was reloading
the order which loaded the cart state again. And since the order.next
method was mocked to just return true, the controller was trying to do
that in an infinite loop.
2019-11-19 18:18:01 +11:00
Maikel Linke
ec1b5a7a92
Test concurrent checkouts
...
When two people tried to buy the same item at the same time, it was
possible to oversell the item and end up with negative stock.
Parallel checkouts could also lead to other random failures. This spec
is testing that scenario by starting two threads which would run into a
race condition unless they use effective synchronisation. The added spec
fails if the synchronisation is removed from the CheckoutController.
2019-11-19 18:18:01 +11:00
luisramos0
5fdb86ae43
Make simple create redirect to OC list but normal create to jump to incoming settings
2019-11-12 12:00:48 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
Luis Ramos
ea8eb0ee14
Merge pull request #4371 from luisramos0/payment_methods
...
Move Payment methods from spree_backend to OFN
2019-11-08 14:26:21 +00:00
Luis Ramos
52ab6c52bf
Merge pull request #4057 from luisramos0/remove_spree_api_2
...
Remove dependency to spree_api - step 2 - routes and views
2019-11-06 13:23:32 +00:00
Luis Ramos
db8e2891d4
Merge pull request #4417 from Matt-Yorkley/shopfront_patchination
...
Ensure variants returned in #variant_relation are DISTINCT
2019-11-01 12:16:01 +00:00
Matt-Yorkley
67a5a1cdc2
Fix incorrectly ordered entries with duplicate product names in OC and custom taxon ordering applied
2019-10-31 12:14:14 +00:00
Matt-Yorkley
9723e2cd49
Add failing spec for taxon ordering issue
2019-10-31 12:07:16 +00:00
luisramos0
f45eb35eb1
Make user_registrations_controller_spec keep I18n.locale as it was before the spec, so that other specs wont fail
2019-10-30 10:43:46 +00:00
Luis Ramos
3e7bd7dc19
Merge pull request #4376 from luisramos0/ghosts
...
Remove product from Order Cycles if product supplier changes
2019-10-28 21:17:48 +00:00
luisramos0
b5a521476b
Remove unused method from api/base_controller
2019-10-28 16:00:36 +00:00
luisramos0
b29983ac60
Add AMS versions of the error responses in api/base_controller and cover not_found case with a unit test
2019-10-28 16:00:36 +00:00
luisramos0
91188c5724
Adapt api/base_controller_spec from spree/api/base_controller_spec
2019-10-28 16:00:36 +00:00
luisramos0
bf291ec318
Move spree/api/base_controller_spec to api/base_controller_spec
2019-10-28 16:00:36 +00:00
Luis Ramos
02c0b89fa0
Merge pull request #4345 from Matt-Yorkley/shopfront_pagination
...
Shopfront pagination
2019-10-21 16:02:12 +01:00
Matt-Yorkley
7b0c55e15a
Ensure producer properties are included in properties results
2019-10-18 21:15:13 +01:00
Matt-Yorkley
cbe2477d04
Fix property filters and improve test coverage
2019-10-18 21:15:13 +01:00
Matt-Yorkley
d45403f1d4
Add specs for Api::OrderCyclesController
2019-10-18 21:15:13 +01:00
Matt-Yorkley
ab330e882e
Remove product cache
2019-10-18 21:15:11 +01:00
luisramos0
49f98422fd
Remove product from Order Cycles if supplier changes as with a new supplier the rules/permissions to add a product to an Order Cycle may be different
2019-10-17 17:47:15 +01:00
Luis Ramos
ad247e2116
Merge pull request #4268 from luisramos0/add_order_endpoint
...
Add api/orders/{order_number} API endpoint
2019-10-16 21:22:27 +01:00
Luis Ramos
d7223c508a
Merge pull request #4289 from luisramos0/spree_be_config_general
...
Move general_settings, mail_methods and image_settings from spree_backend to OFN
2019-10-16 12:08:36 +01:00
luisramos0
1eafb1a3fe
Bring specs from spree_backend to payment methods controller spec
2019-10-15 18:49:35 +01:00
luisramos0
e48ac64d37
Prepare spec to integrate some specs coming from spree_backend
2019-10-14 23:17:43 +01:00
Luis Ramos
35d76ac991
Merge pull request #4298 from luisramos0/variant_edit
...
Make unit description visible in the variant edit page even for products which variant_unit is items
2019-10-13 19:54:41 +01:00
Matt-Yorkley
da7456e6e0
Remove old shop/products route, action, and spec
2019-10-09 17:27:00 +01:00
luisramos0
713769b497
Fix rubocop issues in mail_methods_controller_spec
2019-10-02 21:26:09 +01:00
luisramos0
495de37620
Fix more rubocop issues in image_settings_controller_spec
2019-10-02 21:26:09 +01:00
luisramos0
05d24cf11a
Transpec image_setting_controller_spec
2019-10-02 21:26:09 +01:00
luisramos0
edd84530af
Fix simle rubocopo issues in image_settings ctrl spec
2019-10-02 21:26:09 +01:00
luisramos0
6677543de0
bring 2 specs from spree_backend to cover image_settings page and mail_methods page
2019-10-02 21:26:09 +01:00
luisramos0
50731e929e
Remove some attributes from test as they are already verified subsequently
2019-09-25 09:54:33 +01:00
luisramos0
baa09b88f7
Fix issue with nil current_order where shipping_method serializer requires a current_order to calculate the shipping fees
2019-09-25 09:52:10 +01:00
luisramos0
2f60a85593
Improve spec/controllers/api/orders_controller_spec, make it more readable
2019-09-23 23:50:42 +01:00
luisramos0
24afa21885
Revert "Change products controller to clear variants unit description if variant_unit is items"
...
This reverts commit 1a4e83d633
2019-09-22 16:31:26 +01:00
luisramos0
3c412b7b7d
Transpec spec/controllers/api/taxonomies_controller_spec, spec/controllers/api/taxons_controller_spec and spec/models/enterprise_spec
2019-09-19 20:34:30 +01:00
luisramos0
4d37aaac64
Use have_http_status and remove check for error message, that's something for the base_controller test to test
2019-09-19 16:32:09 +01:00
luisramos0
19e28cb14a
Make spec/controllers/api/orders_controller_spec more simple assuming adjustments will always come in the same order
2019-09-19 16:32:09 +01:00
luisramos0
2921ee19e1
Add api/order/{order_number} ednpoint and its new order detailed serializer
2019-09-19 16:32:09 +01:00
Luis Ramos
ed1c154b78
Merge pull request #4252 from luisramos0/remove_clear_ship_address
...
On checkout of pickup orders, set ship_address to shipping_address_from_distributor instead of empty Spree::Address.default
2019-09-17 13:18:20 +01:00
luisramos0
fb65c64c68
Keep the ship_address clearing logic (this time reusing the OrderUpdate method) thus making the restart_checkout process work for these cases (because order.ship_address is not empty)
...
OrderUpdater#shipping_address_from_distributor uses order.address_from_distributor to set order.ship_address when order is not delivery: this will clear the ship address as it was done previously without setting an empty address like Spree::Address.default
2019-09-09 22:05:20 +01:00
luisramos0
e9b5551c0f
Adpat shipment controller to move out of Spree namespace
2019-09-08 12:17:36 +01:00
luisramos0
7cec24f1d4
Move shipments route, controller and ctrl spec from spree/api to api
2019-09-08 12:17:36 +01:00
luisramos0
26f5ece7c0
Add a few relevant attributes to shipment serializer and fix some details in shipment controller spec
2019-09-08 12:15:33 +01:00
luisramos0
a21a4aba5d
Convert spree/api/shipments from rabl to AMS and adapt its spec
2019-09-08 12:15:33 +01:00
Luis Ramos
e3ce2a7486
Merge pull request #4104 from luisramos0/convert_taxons_to_ams
...
Convert spree/api/taxons views from rabl to AMS
2019-09-06 00:04:10 +01:00
Matt-Yorkley
ff2db0c5f8
Update spec routes, namespacing, and test content
...
Resolving new issues after a big merge
2019-09-02 14:35:00 +01:00
