David Cook
0225db6840
Refactor without setter methods
...
This class was originally built to flexibly accept paramters in any order. It also allowed you to specify multiple of the same type of parameter, with the later one overriding the earlier.
This is too flexible and likely to cause mistakes. And besides, we don't use that feature!
2025-05-05 12:59:27 +10:00
Filipe
d2fa2e612c
Merge pull request #13113 from chahmedejaz/task/13031-allow-producers-to-edit-orders
...
Allow producer to edit their products on hubs' orders
2025-04-21 11:28:36 +01:00
Filipe
cb9db54cd3
Merge pull request #13240 from rioug/13100-do-not-remove-fee-product-removed-from-OC
...
[Enterprise Fees] Keep fees on product when a product is removed from the order cycle
2025-04-20 21:57:56 +01:00
Ahmed Ejaz
3474734418
implement spree_current_user let! so that user creation doesn't get captured in the scoper queries
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
ccfd0edbf1
fix lint issues
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
bf6934db94
add specs
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
20146a8e11
update respective specs
2025-04-13 21:35:55 +05:00
Filipe
c3cb51441f
Merge pull request #13192 from dacook/display-customer-contacts-in-reports-13129
...
[FF] Add option to display customer contact details to suppliers in reports
2025-04-08 20:34:44 +01:00
Filipe
a7c77dc894
Merge pull request #13084 from abdulazizali77/bugfix/11529-report-by-enterprise-fee-from-lineitems
...
Fetch variant enterprise fees from order lineitems adjustments #11529
2025-04-01 16:13:51 +01:00
Gaetan Craig-Riou
3744ba9198
create_*_adjustment now return the adjustment
2025-04-01 13:46:34 +11:00
Gaetan Craig-Riou
d83f8ded0d
Remove Module from spec and some stylying
...
Also remove unnecessary use of `__send__`
2025-04-01 13:46:34 +11:00
David Cook
e02ef08b06
Consolidate translations for hidden field
...
The string '< Hidden >' was agreed on as a good default, so we will use the hidden_field key.
I also moved the definition in en.yml up to the more general area at the start of admin.reports section (before it was hidden between report-specific keys.
2025-03-31 16:24:07 +11:00
David Cook
19b6cbcc9b
Packing reports: Display phone numbers to suppliers
2025-03-31 16:16:27 +11:00
David Cook
f40a00dde3
Expand spec to cover existing behaviour
...
And use let to avoid extra db query
2025-03-31 16:16:27 +11:00
David Cook
47b6888fe6
Display customer emails & phone numbers to suppliers
...
when permitted.
The MaskDataService is used by the report framework, so this should affect all reports. It would be nice to test all reports, but I figured it wasn't worth it (already we only test one report for masking names).
2025-03-31 16:16:27 +11:00
Gaetan Craig-Riou
11e08dcc26
Revert "Update line items enterprise fee instead of deleting and recreating "
2025-03-19 09:40:02 +11:00
Filipe
b3c7968e50
Merge pull request #13144 from rioug/13100-removed-fee-when-product-removed
...
Update line items enterprise fee instead of deleting and recreating
2025-03-14 10:12:50 +00:00
cyrillefr
9bb617d748
Fixes some rubocop linting offenses - part III
2025-03-06 23:42:53 +01:00
Ahmed Ejaz
434434f451
13127 - add shipment state in the oc customer total report
2025-03-04 04:09:04 +05:00
Gaetan Craig-Riou
2fc393037a
Add order_cycle_per_item_enterprise_fee_applicators_for
...
It retrieves all the per item fees associated with an order cycle and
create the appropriate Fee Applicator.
2025-02-19 15:11:24 +11:00
Gaetan Craig-Riou
c6fab57827
Remove Module from spec and some stylying
...
Also remove unnecessary use of `__send__`
2025-02-19 15:11:24 +11:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
filipefurtad0
77b857a30d
Adds test case when the hub is owner of the fee
2025-02-12 21:22:19 -06:00
filipefurtad0
48f5df349a
Adds test case on included tax
2025-02-12 21:22:19 -06:00
filipefurtad0
85ec771e27
Adds coverage on supplier option to charge tax
2025-02-12 21:22:19 -06:00
Ahmed Ejaz
e8b185256e
13013: add specs
2025-01-31 17:34:34 +05:00
Filipe
e2161660b3
Merge pull request #13090 from mkllnk/replace-spree-roles
...
Replace spree roles
2025-01-30 21:30:56 -06:00
Konrad
01036e6321
Merge pull request #13087 from mkllnk/stock-location
...
Remove class Spree::StockLocation
2025-01-25 12:41:37 +01:00
David Cook
e38d305ca1
Merge pull request #13089 from mkllnk/haml-up-remove
...
Remove unneeded HAML upgrade script
2025-01-24 14:23:56 +11:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Maikel Linke
64608beaa8
Remove DefaultStockLocation created in setup
2025-01-22 12:01:57 +11:00
Maikel Linke
917e0ff01a
Remove unnecessary storage of currency
2025-01-21 20:11:05 +01:00
Abdul Aziz Ali
a15cb58ab5
fetch variant enterprise fees from order lineitems adjustments #11529
2025-01-21 06:53:42 +08:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
Maikel Linke
18ec97992d
Remove unneeded HAML upgrade script
...
We updated a long time ago and I now copied those scripts to a Gist to
share with others:
* https://gist.github.com/mkllnk/bab2d474d686a2e3b88914129aee63e1
2025-01-15 12:55:13 +11:00
Maikel Linke
c1198c8e1f
UNSAFE Style Rails/CompactBlank
2025-01-10 09:14:34 +11:00
Konrad
8e0c0392d9
Merge pull request #12991 from murjax/remove-sku-11973
...
Remove product SKU from product pages and report
2025-01-07 21:14:39 +01:00
Maikel Linke
5db8cb452e
Leverage Rails' caching when checking for admin
...
The privileges of a user should never change within a request
life cycle. The `spree_roles` association is very small, between 0 and 2
items are quickly searched in memory without the need of additional
database queries.
From memory, I've seen a lot of spree_roles queries in log files per
request. This should reduce it to one.
2024-12-19 10:12:31 +11:00
Ahmed Ejaz
c331d57cdb
13008: add tax category in all products report
2024-12-04 03:36:42 +05:00
Maikel
de938f6f10
Merge pull request #12949 from rioug/12859-use-VINE-voucher
...
[City OFN Voucher] A shopper can use a VINE voucher
2024-12-03 14:04:44 +11:00
Maikel
697f430156
Merge pull request #12992 from mkllnk/errors
...
Add simpler Alert.raise interface to notify Bugsnag
2024-12-03 13:29:11 +11:00
Gaetan Craig-Riou
12cf62c2ff
Refactor, add OrderManagement::Order::Updater#update_voucher
...
Move the logic to update a voucher and associated order to
`OrderManagement`
2024-11-28 13:35:01 +01:00
Filipe
a493d70f5c
Merge pull request #12950 from macanudo527/unlock_bigdecimal
...
Fix rounding issues by upgrading decimal maths library
2024-11-25 19:18:19 -06:00
Maikel Linke
61e7c1db07
Replace obsolete ErrorLogger
2024-11-21 15:58:55 +11:00
Ryan Murphy
bab7756017
Remove product SKU from product pages and report
2024-11-20 19:12:29 -05:00
Filipe
22f3afc7f7
Merge pull request #12930 from chahmedejaz/task/12878-add-variant-name-in-od-report
...
Report Orders and Distributors should display variant
2024-11-20 12:23:36 -06:00
Ahmed Ejaz
6b3b29ac39
12776: refactor spec
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
9bcdac8f30
12776: rename vat to tax
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
e2d999da8d
12776: use EnterpriseFeeCalculator in specs
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
298c0e8d7f
fix reported issues:
...
- wrong enterprise fees
- always 0 tax on fees
2024-11-15 11:09:56 +01:00
