Mohamed ABDELLANI
a3fd7b77c8
notify if any distributors doesn't have an abn
2024-06-24 14:46:01 +01:00
Ahmed Ejaz
72640cfc2a
12346: refactor orders_controller spec
2024-06-24 14:43:17 +05:00
Ahmed Ejaz
ff10a36e4a
12346: refactor bulk_line_items_controller spec
2024-06-24 14:25:34 +05:00
cyrillefr
980ce95ab2
Requested changes
...
- replace direct instance variable use by instance getter use
2024-06-24 10:37:43 +02:00
Gaetan Craig-Riou
c4470f76e3
Merge pull request #12593 from filipefurtad0/regression_spec_12591
...
Adds regression spec for #12591
2024-06-24 14:46:29 +10:00
Gaetan Craig-Riou
cd768a1fe9
Merge pull request #12585 from mkllnk/flaky-caching
...
Ensure all assets are compiled on test page visit
2024-06-24 14:44:11 +10:00
Gaetan Craig-Riou
c756afa1cc
Merge pull request #12571 from filipefurtad0/adds_spec_on_abn_restriction
...
Adds test case to assure acceptance criteria from #12374 and #12373
2024-06-24 14:41:31 +10:00
Gaetan Craig-Riou
67cac1f4d6
Fix search to return expected data
...
As explained in Reporting::ReportTemplate::ReportsHelper, 'search' and
`query_result` are not supposed to return the same things
2024-06-24 14:04:35 +10:00
Ahmed Ejaz
afd09091a2
12346 - fix broken specs
2024-06-22 02:11:39 +05:00
cyrillefr
659111932c
Fixes Rails/RelativeDateConstant offense
...
- Cop: Rails/RelativeDateConstant
- raises offense if Constant is relative data (ie: since, ago)
- Reason: relative data will be evaluated only once
- BUT here, Date should not be evaluated in a class method, and have a different
- value for each call. But the data should be the same for an instance
- Therefore: move the ago in init method
- Cf. https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsrelativedateconstant
- Since there is no constant to be called form a class, but a date from an instance, the
spec has been modified accordingly. The RemoveTransientData.new.call had to be splitted.
2024-06-21 23:07:16 +02:00
Ahmed Ejaz
9dd427ab7f
12346 - fix rubocop rails/pluckInWhere errors
2024-06-22 01:54:54 +05:00
Ahmed Ejaz
98e0b0e703
12346 - fix rubocop rails/pluck errors
2024-06-22 01:45:58 +05:00
Maikel
0dd7f264b9
Merge pull request #12542 from anansilva/12448-sanitise-html-custom-tab
...
Sanitize HTML in custom tab content [read only]
2024-06-21 08:35:26 +10:00
filipefurtad0
1d55c05900
Update all locales with the latest Transifex translations
2024-06-20 11:17:26 -06:00
Konrad
f9e1ff9238
Merge pull request #12567 from mkllnk/flash-css-fix-v3
...
Error messages don't block bottom of page clicks
2024-06-20 17:22:02 +02:00
Ana Nunes da Silva
d2c6db0d04
Sanitize CustomTab#content
2024-06-20 11:56:09 +02:00
Konrad
25d375bf8e
Merge pull request #12577 from cyrillefr/WhiteLabelButtonAlwaysInactive
...
Update button should change status on modified white label
2024-06-20 11:39:58 +02:00
Ahmed Ejaz
349862c72e
11987: fix specs
2024-06-20 13:41:41 +05:00
Ahmed Ejaz
86c87962f9
11987: add missing translation
2024-06-20 13:09:48 +05:00
Ahmed Ejaz
4b9141f66d
11987 - add products table mutation listner
2024-06-20 12:44:55 +05:00
David Cook
d80e1efa7b
Add includes for more efficient querying
2024-06-20 17:02:47 +10:00
David Cook
54d068ee08
Add spec for db queries
2024-06-20 17:02:47 +10:00
David Cook
141a883e4d
Refactor report
...
So it turns out that all these features are built into the report framework.
LineItems includes complete_not_canceled_visible_orders.
It even takes care of masking non-editable orders.
2024-06-20 17:02:47 +10:00
David Cook
5b8f590520
Add spec for bug
...
You wouldn't believe how long it took me to figure out all the bits and pieces.
But now you don't have to!
2024-06-20 17:01:14 +10:00
David Cook
0cff734b86
Refactor spec
...
Linter said module was too big. I agreed, so made it smaller.
Best viewed with whitespace ignored.
2024-06-20 16:58:09 +10:00
Maikel Linke
98a29785a7
Load large on-screen reports on demand
...
Sending large reports via Cable Ready is unreliable. The events are
dropped at an unknown point and the report is never displayed to the
user. Instead we just send a link to the report via Cable Ready and
offer a button to load the report on screen.
This has the UX benefit of warning the user about the size as well.
Weaker devices can struggle rendering big HTML documents.
2024-06-20 11:32:33 +10:00
filipefurtad0
48a39f20e8
Adds regression spec for #12591
2024-06-19 19:30:42 -06:00
filipefurtad0
d1560ce15e
Adds shared examples for bulk send invoices in PDF
2024-06-19 17:58:58 -06:00
David Cook
0e0a7d9d3e
Merge pull request #12589 from cyrillefr/FixRailsRedundantActiveRecordAllMethodIssue
...
Fixes Rails/RedundantActiveRecordAllMethod issues
2024-06-20 09:40:56 +10:00
David Cook
66606eeeab
Merge pull request #12584 from mkllnk/spec-refactor
...
Update spec for quotation mark replacement
2024-06-20 09:37:09 +10:00
David Cook
ef195876fa
Merge pull request #12590 from abdellani/12452-improve-logging
...
update message logged when a product is deleted
2024-06-20 09:27:51 +10:00
Maikel
f933ae83c8
Merge pull request #12581 from dacook/cache-ci-yarn
...
Cache yarn global package data in CI
2024-06-20 09:01:05 +10:00
filipefurtad0
3380175c30
Restructures spec to accommodate shared example on bulk printing
2024-06-19 16:52:36 -06:00
Maikel
a9225543da
Merge pull request #12554 from mkllnk/dfc-logo
...
Add enterprise logo and contact name to DFC API with standard attributes
2024-06-20 08:49:27 +10:00
filipefurtad0
59b6cdaf01
Extends tests to cases where ABN is an empty string
...
Removes pending and changes testcase
As discussed on Slack we will not fix old invoice model, for ref. see: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1718781775612759?thread_ts=1718249609.127149&cid=CG7NJ966B
2024-06-19 16:42:10 -06:00
Abdellani
0337464291
update logged message when a product is deleted
2024-06-19 15:15:04 +01:00
Abdellani
7a015bad96
populate destroyed_by on produce_v3_controller#destory
2024-06-19 15:14:32 +01:00
cyrillefr
654fda89ca
Fix Rails/RedundantActiveRecordAllMethod issues
...
- Cop: Rails/RedundantActiveRecordAllMethod
- if receiver is an Active Record object, ".all" can be safely removed
- There are 2 allowed receivers that are listed in the
styleguide file (those are defaults cf. cop documentation).
2024-06-19 14:32:21 +02:00
Maikel
ef7f1d335f
Merge pull request #12587 from openfoodfoundation/revert-12536-stock-levels
...
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:46:54 +10:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel Linke
d5b77a4f80
Ensure all assets are compiled on test page visit
2024-06-19 11:45:28 +10:00
Maikel Linke
10f0eeef0b
Update spec for quotation mark replacement
...
I'm not sure why, but the pre-compiling of assets triggered Rails to
render `style="..."` instead of `style='...'` in this case. But when
assets are compiled on-demand, we get the single quotes. So I changed
the spec to be agnostic of this detail. We actually just want to know
about the link and its href.
2024-06-19 11:40:09 +10:00
filipefurtad0
fe93e3ed97
Restructures spec
...
Separating into different contexts, with and without invoices feature enabled
2024-06-18 19:32:44 -06:00
Maikel
1e189207ed
Merge pull request #12583 from dacook/add-attachment-translation
...
Add translation key for Spree::Image#attachment
2024-06-19 11:20:07 +10:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
Maikel
2188e96dfb
Merge pull request #12575 from zanetagebka/RedundantInterpolationCops
...
Solve Rubocop RedundantInterpolation cops
2024-06-19 11:01:42 +10:00
David Cook
6ce442a42e
Add translation key for Spree::Image#attachment
2024-06-19 09:49:15 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
Gaetan Craig-Riou
55ae1ba29f
Merge pull request #12579 from openfoodfoundation/dependabot/npm_and_yarn/ws-6.2.3
...
chore(deps): bump ws from 6.2.2 to 6.2.3
2024-06-19 09:17:53 +10:00
David Cook
6fd3cada8c
Fix classname
2024-06-19 09:13:53 +10:00
