David Cook
ee2520a1f6
Visit page directly to save time
...
Shaved a couple of seconds off, 35->33 sec.
And make it easier to hide from the list.
2023-09-13 19:09:55 +02:00
David Cook
b27f63fa60
Refactor: DRY up init code
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
4cb91da8b2
load only enterprise fees connected to incoming exchanges on the OC
2023-09-13 19:09:55 +02:00
filipefurtad0
af525f9f7f
Fixes rubocop issues
2023-09-13 19:09:55 +02:00
filipefurtad0
131474e91d
Updates test case
...
should list all the tax rates (2)
2023-09-13 19:09:55 +02:00
filipefurtad0
57f058eeb2
Updates test case
...
should list all the tax rates
2023-09-13 19:09:55 +02:00
filipefurtad0
fc9826b44a
Updates test case
...
should filter by fee name
2023-09-13 19:09:55 +02:00
filipefurtad0
86e6697723
Updates test case
...
should filter by producer
2023-09-13 19:09:55 +02:00
filipefurtad0
7734b0417d
Updates test case
...
should filter by distributor and order cycle (2)
2023-09-13 19:09:55 +02:00
filipefurtad0
d7a6db3eb0
Updates test case
...
should filter by distributor and order cycle
2023-09-13 19:09:55 +02:00
filipefurtad0
d8501e7d83
Updates test case
...
generates the report and displays fees for the respective suppliers
2023-09-13 19:09:55 +02:00
David Cook
47d5fe909e
Deduplicate order2 setup
2023-09-13 19:09:55 +02:00
David Cook
8c514b2fe9
Deduplicate order setup
2023-09-13 19:09:55 +02:00
David Cook
b574e71fc9
Refactor: set included_in_price once
...
This saves the need for an update, and more importantly moves setup out of the before block which means we can finally deduplicate order setup.
2023-09-13 19:09:55 +02:00
David Cook
6e15049728
Refactor distributor
2023-09-13 19:09:55 +02:00
David Cook
bf2298829f
Refactor order cycle setup more
...
Moving more code out of before blocks which will help us reduce duplication in following commits.
2023-09-13 19:09:55 +02:00
David Cook
ce57ac65f3
Refactor order cycle lets
...
It turns out the outgoing exchanges were never even used.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
9a22cdc5e7
test scenario: 'multiple orders, same enterprise fee, different tax rates'
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
624b4c8ad2
fix calculation of the summary row's total excl tax
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
f0c3d7685e
replace string reference with the translated string
2023-09-13 19:09:55 +02:00
David Cook
420494715f
Tighten up spec
...
I noticed that the tests don't check if the right totals are shown for each section. Now we can be certain.
2023-09-13 19:09:55 +02:00
David Cook
b7e1a660c3
Rename supplier to be more specific
...
To ensure specs are matching the right supplier.
2023-09-13 19:09:55 +02:00
David Cook
93cca56e68
Style/HashSyntax
2023-09-13 19:09:55 +02:00
filipefurtad0
019c7b3e71
Splits filtering tests between orders
...
Sets pending test case for orders with more than one supplier
2023-09-13 19:09:55 +02:00
filipefurtad0
e43661fd3c
Adds/corrects comments around Added tax section
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
44e8d2d735
fix pending lint issues
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
219c581f9a
remove pending from "should filter by producer"
2023-09-13 19:09:55 +02:00
filipefurtad0
9837a4fcf2
Removes pending (3)
...
Reverts Included Tax values
2023-09-13 19:09:55 +02:00
filipefurtad0
1b4235eb1d
Extends tests to inclusive tax scenario
2023-09-13 19:09:55 +02:00
filipefurtad0
bb0f9a6758
Adds pending test
...
on fees from order with line items from different suppliers
Adds pending test on producer filter
2023-09-13 19:09:55 +02:00
filipefurtad0
928337c3fd
Adds a second supplier and product to the setup
2023-09-13 19:09:55 +02:00
David Cook
55742f40d1
Show a line for cost of produce
...
Utilising a second group_by rule, we can add a second summary_row. The cost of produce is also inserted into the TOTALS row as per requirements.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
ee7668e713
implement enterprise fee report filters
...
squash Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
481b09edda
test enterprise summary fee with tax report by producer
...
Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Filipe
dae05e31ab
Merge pull request #11501 from jibees/9146-improve-user-feedback-in-oc-edit-page-for-hidden-inventory
...
Improve user feedback in oc edit page for hidden inventory
2023-09-13 16:26:39 +01:00
filipefurtad0
263b5e280e
Renames product so it always appears first on the report results
2023-09-13 11:33:58 +01:00
Gaetan Craig-Riou
9925399292
Sales Tax Totals by order, fix tax amount when voucher applied
...
Apply the tax discount to the tax collumn when a voucher is added
to the order, and update total excluding tax accordingly.
2023-09-12 14:36:28 +02:00
Gaetan Craig-Riou
a7bceb0b28
Add spec scenario where a voucher is added to the order
...
Voucher tax portion needs to be removed from the tax amount so we
can display the correct tax in the report.
2023-09-12 14:14:01 +02:00
Gaetan Craig-Riou
29a4bf88d7
DRY up specs
2023-09-12 14:13:04 +02:00
Jean-Baptiste Bellet
637096534f
Implement spec for #9146 issue
2023-09-12 10:20:26 +02:00
Gaetan Craig-Riou
e44a0092ea
Fix edge case when trying to deactivate the only availabe voucher
...
Plus spec
2023-09-11 12:00:48 +02:00
Maikel Linke
7654d37fc3
DRY, shorten swagger file names
2023-09-11 14:57:39 +10:00
Maikel Linke
fc7c8757d9
Move DFC patches into our DFC engine
...
It seems to belong there and it's avoiding some loading issues with
Spring.
2023-09-11 14:57:38 +10:00
Maikel Linke
6316974146
Group DFC API operations by endpoint
...
Previously they were all in one long list called "default".
2023-09-11 14:57:38 +10:00
Matt-Yorkley
839e580878
Fix error when importing entries with a tax category
2023-09-08 19:24:50 +01:00
Maikel
1991970185
Merge pull request #11377 from mkllnk/dfc-update-request
...
[DFC API] Import known units when creating new products
2023-09-08 09:05:26 +10:00
Konrad
ea622cd2d7
Merge pull request #11487 from pedrocarmona/feature/invitation-email-locale
...
Send translated email when creating users via super admin interface
2023-09-07 16:41:59 +02:00
Gaetan Craig-Riou
f225cd78df
Handle unique voucher code exception
...
Rails validation doesn't handle unique validation for soft deleted
object. So we rescue the exception raise by the database and display
a nice error message. We don't want an enterprise to be able to reuse
a code in case the voucher get reactivated.
2023-09-07 15:13:47 +02:00
Gaetan Craig-Riou
63cd8ccf28
Test scenario where a voucher is deactivated before end of checkout
...
A customer should be able to complete the checkout even if the voucher
has been deactivated after being added to the order.
2023-09-07 14:00:26 +02:00
Gaetan Craig-Riou
b955e0b25d
Use depedend: nil on adjustment association
...
We want to keep the voucher adjustment associated with the Voucher
event when the voucher as been soft deleted, as we use this
functionality as activate/deactivate feature
2023-09-07 13:58:07 +02:00