Filipe
e524b3ddb1
Merge pull request #13197 from dacook/reload-payments-12693
...
Fix obscure issue when choosing payment method in checkout
2025-03-18 12:04:33 +00:00
Filipe
3c801a2656
Merge pull request #13182 from mkllnk/invalid-dfc-catalog-url
...
Rescue from invalid DFC catalog URLs
2025-03-18 10:57:26 +00:00
Maikel
a0b5bd53f1
Merge pull request #13210 from dacook/test-locale
...
Ensure tests run with specified locale
2025-03-18 09:57:25 +11:00
Gaetan Craig-Riou
afb25a5209
Merge pull request #13209 from cyrillefr/FixRubocopLintIssuesIV
...
Fixes some rubocop linting offenses - part IV
2025-03-18 09:43:01 +11:00
Filipe
b3c7968e50
Merge pull request #13144 from rioug/13100-removed-fee-when-product-removed
...
Update line items enterprise fee instead of deleting and recreating
2025-03-14 10:12:50 +00:00
Maikel Linke
b15ffe7a4e
Restore empty block with comment
...
RSpec tags are too complex for this simple setup.
2025-03-14 11:26:04 +11:00
cyrillefr
ba58a7b924
Fix: inconsiderate use of RSpec.configure
2025-03-13 10:08:35 +01:00
David Cook
1bbd6b58fd
Run tests with specified locale
...
We changed .env.test a while ago, but I just discovered it hadn't taken any effect because it was overwritten here. Now it's loaded from env var.
2025-03-13 11:56:16 +11:00
cyrillefr
e26d591d24
Fixes some rubocop linting offenses - part VI
2025-03-12 21:23:49 +01:00
Maikel Linke
2f5667a294
Gracefully handle product missing from catalog
2025-03-12 12:56:08 +11:00
David Cook
1213455350
Merge pull request #13202 from mkllnk/flaky-cache
...
Ensure we test for the right text after AJAX loads filters
2025-03-12 10:12:11 +11:00
David Cook
19ae49aa68
Merge pull request #13200 from mkllnk/caching
...
Make sure the first page load is complete before updating database
2025-03-12 10:11:00 +11:00
Maikel Linke
fc73d8cd4a
Ensure we test for the right text after AJAX loads filters
2025-03-11 17:02:48 +11:00
David Cook
f37742d84a
Prevent exception when payment has been cleared
...
Note that in the real world, this avoids a crash, but still requires the user to click the button two more times before it will work, with no hints as to why. So not a great help.
2025-03-11 16:19:21 +11:00
David Cook
25eb00f69c
Spec for #12693
...
I tried to build it within context "with existing invalid payments", but couldn't get it to work so created a different one.
2025-03-11 16:10:54 +11:00
David Cook
0f923405cb
Attempt to spec for error
...
It didn't catch the error I was looking for. I'm not sure if it is a valid use case, but it still seems helpful to add coverage for current functionality.
2025-03-11 16:08:27 +11:00
Gaetan Craig-Riou
f2c3ab8b03
Per review, improve test expectation
2025-03-11 10:37:49 +11:00
Maikel Linke
fc2515eac1
Make sure the first page load is complete before updating database
2025-03-07 13:08:50 +11:00
cyrillefr
9bb617d748
Fixes some rubocop linting offenses - part III
2025-03-06 23:42:53 +01:00
David Cook
d3b7db0082
Merge pull request #13186 from cyrillefr/FixRubocopLintIssuesII
...
Fixes some rubocop linting offenses - part II
2025-03-06 11:33:56 +11:00
Ahmed Ejaz
434434f451
13127 - add shipment state in the oc customer total report
2025-03-04 04:09:04 +05:00
cyrillefr
446b948889
Fixes some rubocop linting offenses - part II
2025-03-03 14:03:47 +01:00
Maikel Linke
9d5ce0ede5
Remove surrounding whitespace from pasted DFC URL
2025-03-03 12:23:58 +11:00
Maikel Linke
b6153fc155
Rescue from invalid DFC catalog URLs
...
This mistake should be dealt with differently but I wanted to make sure
that a really invalid URL is handled well, too.
2025-03-03 12:23:58 +11:00
Filipe
feccef0b36
Merge pull request #13157 from drummer83/email_styled_password
...
Create styled email for reset password instructions
2025-02-27 16:53:04 -06:00
Filipe
cf3213cf96
Merge pull request #13168 from dacook/dfc-product-import-select-all-12301
...
[DFC Orders] Select/deselect all on DFC Product Import
2025-02-27 16:43:37 -06:00
David Cook
5a1d6b749e
Fix spec
...
The label got changed in a separate PR that was merged around the same time.
It's my fault for changing the label.
2025-02-26 15:57:12 +11:00
Maikel
462886447a
Merge pull request #13126 from mkllnk/oidc-error
...
Direct people to refresh OIDC connection when needed
2025-02-24 15:45:48 +11:00
Konrad
7cd3c32787
Merge pull request #13164 from rioug/fix-user-controlled-method-execution
...
Fix user controlled method execution
2025-02-21 12:59:40 +01:00
Filipe
9baed8536c
Merge pull request #13121 from rioug/13054-out-of-stock-autoremove
...
Autoremove/update item from the cart if stock changed during checkout
2025-02-20 22:35:40 -06:00
Filipe
f715c366ea
Merge pull request #13160 from chahmedejaz/task/13097-add-columns-in-packing-reports
...
Add shipping method and shipment state to packing reports
2025-02-20 19:49:03 -06:00
Filipe
f7b471da08
Merge pull request #13148 from mkllnk/dfc-variants
...
Add DFC product groups with variants
2025-02-20 18:53:00 -06:00
David Cook
b370b207b5
Automatically bind toggleCheckbox action
2025-02-20 12:14:49 +11:00
David Cook
b92c046119
Automatically bind toggleAll action
...
We are already specifying the element's role ('all') in the HTML. Its behaviour should be predefined; there's no need to also specify in the HTML.
The eventhandler doesn't need to be cleand up on disconnect, because they are removed along with the DOM object.
2025-02-20 11:24:21 +11:00
David Cook
c2e54104d0
Add select/deselect all checkbox
...
There's A Controller For That.
(But I think it makes the HTML ugly..)
2025-02-20 10:56:53 +11:00
Gaetan Craig-Riou
8116ad986e
Delete fees when fee are removed from the Order Cycle
...
This is to be consistent with the current behavior
2025-02-19 15:34:39 +11:00
Gaetan Craig-Riou
67ad532908
Handle scenario where the enterprise fee has been deleted
2025-02-19 15:34:32 +11:00
Gaetan Craig-Riou
12a54dd8f0
Move #recreate_all_fees! spec to HandleFeesService
...
Spree::Order just delegate Orders::HandleFeesService so there is no
point testing fees in the order spec
2025-02-19 15:13:35 +11:00
Gaetan Craig-Riou
46315c4045
Update Orders::HandleFeesService#recreate_all_fees!
...
We now update or create line item fees instead of deleting them and
recreating them. This is to cover the case when a product has been
removed from an Order Cycle but we want to keep the fee already applied
on existing order. This was an issue only if the existing order got
updated after the product was removed.
2025-02-19 15:13:26 +11:00
Gaetan Craig-Riou
2fc393037a
Add order_cycle_per_item_enterprise_fee_applicators_for
...
It retrieves all the per item fees associated with an order cycle and
create the appropriate Fee Applicator.
2025-02-19 15:11:24 +11:00
Gaetan Craig-Riou
c6fab57827
Remove Module from spec and some stylying
...
Also remove unnecessary use of `__send__`
2025-02-19 15:11:24 +11:00
David Cook
859a20b7a7
Ensure both email formats contain url
2025-02-19 14:20:28 +11:00
David Cook
96b8a4c068
Merge pull request #13134 from dacook/fix-locale-12301
...
Update label and change default dev locale
2025-02-19 09:38:14 +11:00
Ahmed Ejaz
d0650fdab0
Fix ABC size rubocop issue
2025-02-19 02:20:33 +05:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
David Cook
664119ddcf
Update test for multi-part email
...
Now that it's a multi-part email, we have to select the html part for the test.
Another option is to simply check mail.to_s, but this also includes mail headers so doesn't specifically test the body.
2025-02-18 16:15:04 +11:00
David Cook
c9f5dd2d0b
Refactor: rename subject to be consistent
...
Hmm, in different specs it gets called 'mail', 'email', 'message'. The object is a Mail::Message object. The method to generate the object is called `mail`, so I went with that.
2025-02-18 16:07:22 +11:00
Gaetan Craig-Riou
0ae855047d
Fix User controlled method execution
...
Add white list for the fire endpoint to limit which action can be taken.
Add specs for fire endpoint
2025-02-18 14:42:26 +11:00
Maikel Linke
2043d1f8df
Remove custom syntactical sugar
...
It just makes Rswag specs look more different to other request specs and
I found that discouraging. It's good to know that the parameter is just
specified with `let` and that it works exactly in the same way as `let`
in other specs.
The downside is maybe that it's not obvious that those `let` statements
have to correspond with the parameters for the request but error
messages will tell you if you got it wrong. And there's also the
`parameter` declaration to make that clear.
2025-02-18 12:58:10 +11:00
Maikel Linke
6707516203
Automatically document responses for DFC API w/o tag
2025-02-18 12:58:10 +11:00
