David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Maikel Linke
94b75540e4
Replace Timecop with Rails' time helpers
...
Rails 4.1 added time helpers but we never bothered using them. But now
I'm getting rid of the Timecop dependency and use standard helpers.
Beware though that the new helpers always freeze time. When you travel
to a certain date then the clock stops ticking while Timecop maintained
the passing of time.
The freezing of time could cause problems if you are trying to enforce a
timeout. But all current specs don't seem affected.
In most cases, the freezing will make it easier to avoid flaky specs.
2025-08-22 16:57:04 +10:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
Ahmed Ejaz
5dddf8b69a
fix specs
2025-01-31 17:34:34 +05:00
Ahmed Ejaz
393154bae3
13013: fix specs
2025-01-31 17:34:34 +05:00
François Turbelin
96c7c828c1
Fix specs
2025-01-13 16:54:17 +01:00
François Turbelin
9c153c6083
Improve specs
2025-01-13 16:54:17 +01:00
François Turbelin
3c7c02da2f
Repair specs
2025-01-13 16:54:17 +01:00
Konrad
8e0c0392d9
Merge pull request #12991 from murjax/remove-sku-11973
...
Remove product SKU from product pages and report
2025-01-07 21:14:39 +01:00
Gaetan Craig-Riou
12cf62c2ff
Refactor, add OrderManagement::Order::Updater#update_voucher
...
Move the logic to update a voucher and associated order to
`OrderManagement`
2024-11-28 13:35:01 +01:00
Ahmed Ejaz
7ca544540b
12890: fix product names
2024-11-24 15:24:39 +05:00
Ryan Murphy
bab7756017
Remove product SKU from product pages and report
2024-11-20 19:12:29 -05:00
Filipe
22f3afc7f7
Merge pull request #12930 from chahmedejaz/task/12878-add-variant-name-in-od-report
...
Report Orders and Distributors should display variant
2024-11-20 12:23:36 -06:00
Ahmed Ejaz
ed559b5257
update specs to have more line items
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
ec0d2d346b
use to_date for locale based formating
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
654263a823
add systems spec
2024-11-15 11:09:56 +01:00
Maikel Linke
aa7fffa5a2
Filter reports by last 3 months by default
...
The values are not shown on the screen and the user doesn't know which
default dates are applied but the filtering works.
2024-10-17 13:16:12 +11:00
Maikel Linke
3227922c76
Use reports helper to DRY
2024-10-17 13:16:12 +11:00
Maikel Linke
aa2a5757ec
Move Customers report spec to own file
2024-10-17 13:16:12 +11:00
Ahmed Ejaz
641b7beee3
add specs
2024-10-12 04:47:45 +05:00
David Cook
a9ad6a2851
Grant product managers ability to create reports
...
We missed this in c31416c
2024-09-17 13:08:49 +10:00
David Cook
1078e7cd36
Update specs
...
The key here is the enterprise_relationship. This is required for the supplier to have permission to see the orders.
Curiously, the unit test still passes. All will be revealed in the next commit..
2024-09-17 12:55:22 +10:00
filipefurtad0
556539d1b1
Removes pending from fixed issue
...
The pending was not signalling the bug fix as ordering needed to be corrected
2024-09-09 18:07:57 -06:00
filipefurtad0
b7aaab204c
Adds timer restriction with Timecop
...
The datet-time-picker test case was failing for me locally, but passing on GH-Actions. Controlling the time should prevent this type of flakyness
2024-09-09 18:07:57 -06:00
filipefurtad0
632184b0a8
Addresses Davids review
2024-09-09 18:07:57 -06:00
filipefurtad0
8500f6c198
Addresses reviews. The biggest change is moving the table CSS
...
into its helper, which touches other system specs (namely orders_and_fulfillment_spec.rb).
Rubocop fixup
2024-09-09 18:07:57 -06:00
filipefurtad0
ec4dba71c2
Adds flatpickr test
2024-09-09 18:07:57 -06:00
filipefurtad0
6117d70fae
Replaces code with shared examples
...
This spec was appearently flaky, let's see if this change stabilizes it. It came up here: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/10639846576/job/29498582671?pr=12790
Removes CSV tests based on permissions
Not sure we need these tests, proposing to remove them and use shared examples to test file download
2024-09-09 18:07:57 -06:00
filipefurtad0
2e5c526170
Adds basic coverage on report file download
...
Moves file download into report helper
Removes pdf file assertation
Removes test on PDF file on sales tax report
Removes PDF testing from helper
2024-09-09 18:07:57 -06:00
filipefurtad0
32e32117e3
Adds test case around hub filters
2024-09-09 18:07:57 -06:00
filipefurtad0
2a1d494301
Adds coverage for table contents
2024-09-09 18:07:57 -06:00
filipefurtad0
fd45dea9f7
Moves report test case into dedicated file
...
Sets up an enterprise user instead of an admin user
2024-09-09 18:07:57 -06:00
filipefurtad0
4773d1c82e
Reproduces bug #12835
2024-09-03 20:15:29 -06:00
filipefurtad0
72a503c3c1
Removes test on PDF file on sales tax report
2024-08-29 11:46:22 -06:00
Maikel Linke
d9c296cdb3
Stabilise flaky report specs
...
It looks like we have a new race condition that may only be a problem in
specs. If you trigger one report, it displays via websockets and then
you trigger the next report, there may still be some Javascript active
that displays the first report while the second one is loading. I'm not
sure if users would navigate that fast though.
To minimise the problem, I adjusted the polling to leave more room for
the default websockets response.
2024-08-16 17:08:57 +10:00
Gaetan Craig-Riou
0167357f8f
Fic enterprise fee summary report system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
4115b857f7
Fix revenue by hub system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
e0e78f2798
Fix order and fulfillment system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
93a63c5eb5
Fix payment report system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
03ee9529f1
Fix packing report system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
f161f51a0e
Fix sales tax by producer report
2024-07-03 11:15:10 +10:00
filipefurtad0
d88db1365d
Updates specs to accomodate changes on warnings/banners
2024-07-01 12:09:14 +10:00
filipefurtad0
2937bdc1d2
Deals with overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
50c7392c5e
Deals with overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
308c559810
Fixes case on assertions, on failing specs
...
Selects white_label tab with trigger(click)
Scrolling down did no fix it, it still fails https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/6526149195/job/17719815533?pr=11645 , selecting the element with trigger(click) should work
Updates invoice tests
2024-07-01 12:09:14 +10:00
cyrillefr
396ea65bc6
Bugfix on spec
2024-05-23 09:13:18 +02:00
cyrillefr
d27cd18f56
Force start date before end date with range mode flatpickr
...
- modify view to get a flatpickr component in range mode
- modify spec to take into account range mode
2024-05-23 09:13:18 +02:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Feruz Oripov
bdcb0856af
Fix failed specs
2024-03-16 19:23:17 +05:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
