cyrillefr
84747ea064
Fix Rails::NegateInclude issues
...
- cop class: RuboCop::Cop::Rails::NegateInclude
- replaced !array.include?(2) by array.exclude?(2)
2024-04-04 14:42:42 +02:00
Neal Chambers
69e7419a45
Safely autocorrect Style/NegatedIfElseCondition
...
Inspecting 1509 files
....................................................................................................................................................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................
Offenses:
app/mailers/spree/shipment_mailer.rb:15:25: C: [Corrected] Style/NegatedIfElseCondition: Invert the negated condition and swap the ternary branches.
default_subject = !@delivery ? t('.picked_up_subject') : default_i18n_subject
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/matchers/table_matchers.rb:34:5: C: [Corrected] Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
if rows.count != expected_table.count ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1509 files inspected, 2 offenses detected, 2 offenses corrected
2023-11-10 09:13:57 +09:00
Neal Chambers
3432e30465
Fix Style/UnlessGuard
2023-06-08 15:20:04 +10:00
Sebastian Castro
e9513f6172
Report Refactor 1: Enterprise Fee Summary
...
Disable enterprise fee summary spec for now
Will need to write them again
2022-05-12 16:54:13 +02:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
Maikel Linke
1407ae7778
Make TableMatcher match exactly, not part of row
...
Reverts dbf3a7aaaf9d458f99e14983ca9db2d4cbe4b564.
The reverted commit tried to avoid a 30 second delay by using
have_selector. While that was successful in reducing test time, it made
the matcher find rows that where not exactly the wanted row, but contained
text of the wanted row. This wasn't a problem until we experimented with
Chrome as test browser returns text on select boxes.
This commit makes the matcher precise again. We still have to deal with
the 30 second delay.
2019-01-16 16:21:30 +00:00
Rob Harrington
3b40ede0b8
Fix table row matchers
...
The matcher was silently failing on the check step (adding ~30 seconds to out specs each time it was used!), so I changed it to fail if the basic step does not succeed
2019-01-16 16:21:30 +00:00
Andy Palmer
131bf842a9
Update matchers to non-deprecated protocol
2017-11-10 08:47:12 +11:00
Rohan Mitchell
0737ac8da0
Write an rspec table matcher that gives informative error messages
2015-05-15 12:35:14 +10:00
Rob Harrington
b5ef24bacb
table matchers use capybara matchers rather than wait_until with micro-sleep
2014-09-24 16:18:59 +10:00
Rohan Mitchell
76d1754c32
Reorder helper method at bottom
2014-05-21 15:11:14 +10:00
Rohan Mitchell
6026a74c73
Table matcher have_table_row does not wait for full duration on should_not
2014-05-21 14:59:24 +10:00
Rohan Mitchell
ba7e29074f
have_table_row waits
2014-05-21 11:29:11 +10:00
Rohan Mitchell
61af8204d9
Add spec matcher have_table_row
2014-05-21 11:29:11 +10:00
