Maikel Linke
ef22269324
Clarify voucher code not found can mean fully redeemed
2025-05-29 14:18:32 +10:00
cyrillefr
758d78bfe4
Fixes RSpecRailsInferredSpecType
2025-05-21 09:43:24 +02:00
Gaetan Craig-Riou
d102652c03
Fix Vine::VoucherValidatorService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d413a142c9
Update various voucher related file to use the new Vouchers::Vine
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7726c7d129
Per review, rename not_vine scope to local
...
- use IS DISTINCT FROM instead of two conditions
- added spec for scope
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
0569b30e0d
Refactor Vine related services
...
Move them under Vine module to keep the code nicely organised
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
3a367ceb6e
Handle adding a VINE voucher to an order
...
Plus specs
2024-11-28 13:35:01 +01:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Neal Chambers
35e8f88943
Fix Style/HashSyntax
2023-09-24 22:41:27 +09:00
Gaetan Craig-Riou
619285ad4a
Add voucher_type to voucher
...
And update related specs
voucher_type doesn't do anything for now.
2023-08-11 14:19:25 +10:00
Maikel
b50fa216eb
Merge pull request #11117 from rioug/10857-voucher-error-moving-between-summary-and-cart-take2
...
[vouchers] error moving between summary and cart pages
2023-08-09 11:14:52 +10:00
Gaetan Craig-Riou
85adb9f345
Fix rubocop warning
2023-07-31 15:19:04 +10:00
Gaetan Craig-Riou
2857930263
Fix voucher adjustment request spec
...
Error messages have been updated to be more user friendly. This spec
was missed somehow.
2023-07-31 14:06:36 +10:00
Gaetan Craig-Riou
089d2b9c84
Clear any existing payment and payment fees when adding a voucher
...
If a user come back to checkout step 2 from step 3, the order
will have payment and possibly payment fee existing. This can
interfere with voucher calculation, so we clear them.
The user can then select a payment method again if needed
2023-07-31 12:05:52 +10:00
Matt-Yorkley
04bbea53e1
Move voucher processing out of checkout controller
2023-07-14 14:46:16 +10:00
Gaetan Craig-Riou
dc711bde78
Fix voucher adjustment delete
...
When using a voucher with tax not incluced in price, we need to delete
both the voucher adjustment and the tax adjustment
2023-07-14 13:37:45 +10:00
Gaetan Craig-Riou
74073946e6
Move VoucherAdjustmentsController to request specs
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9e5061fc31
Move voucher processing out of checkout controller
2023-07-04 13:13:05 +01:00
Mohamed ABDELLANI
bd0e7cdfc8
remove legacy checkout tests
2023-06-13 14:58:16 +01:00
Gaetan Craig-Riou
2d8fa24862
Add a voucher factory
...
As vouchers are getting more complicated, it makes sense to use a
factory to simplify writing test.
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
