cyrillefr
b9eeb53901
Style Metrics/ModuleLength in spec file
2025-06-17 15:31:17 +02:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Neal Chambers
35e8f88943
Fix Style/HashSyntax
2023-09-24 22:41:27 +09:00
Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
Cillian O'Ruanaidh
593da4996f
A shop won't be shown as open if it doesn't have useable shipping method so these shipping method validations are really necessary
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a3a52a07b7
Build shipping method with a category so it's valid in the test
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
cc5daf51b1
Expect to be_valid instead of checking presence of specific error spec/models/spree/shipping_method_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
fc4f951a1a
Only require OrderCycleShippingMethod records if people want to override the default shipping methods
...
It makes things much simpler if we return all shipping methods by default without needing OrderCycleShippingMethod records to be added to the database.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
1e817af5aa
Validate deleting a shipping method or switching it to backoffice only doesn't invalidate any order cycles
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a5daee39e3
Extract out a DISPLAY_ON_OPTIONS constant in Spree::ShippingMethod instead of magic strings
2022-09-30 13:13:39 +01:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Matt-Yorkley
2a0f132b8b
Improve ShippingMethod -> Shipment association
...
5a54a0b6b0
2021-03-04 14:27:01 +00:00
Matt-Yorkley
46ff247bc9
Ensure ShippingMethod#destroy is using soft-deletion
...
25f5c2daf8
We've already applied some of the changes in this commit during previous Spree upgrade work, but there were a couple of bits missing.
2021-01-11 15:46:38 +00:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
Arun Kumar Mohan
5928eba767
Use build to validate objects from the shipping method factory
2020-10-17 19:59:21 -05:00
Arun Kumar Mohan
27f1aeb803
Improve shipping method specs' performance
2020-10-09 22:11:31 -05:00
Luis Ramos
02f50774bb
Run transpec
2020-08-07 12:47:44 +01:00
Luis Ramos
ff8735d7a4
Make new specs pass
2020-08-07 12:45:06 +01:00
Luis Ramos
ba859111de
Merge decorators with original files brought from spree
2020-08-07 10:17:30 +01:00
Luis Ramos
0c7a0e3e96
Bring modesl from spree_core
2020-08-07 10:06:04 +01:00
Luis Ramos
8a9dae0ee2
Run rubocop autocorrect
...
This is the result of bundle exec rubocop --auto-correct
2020-06-22 12:23:10 +01:00
Matt-Yorkley
1b18808d21
Touch ShippingMethod when it's assigned to a new distributor
2020-04-28 15:11:59 +02:00
luisramos0
2b3865855d
Simplify shipping_method.include? method
2019-06-18 11:42:34 +01:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
luisramos0
04801e5c2e
Run transpec in spec/models
2019-05-09 22:25:29 +01:00
luisramos0
c652cfe4d5
Merge branch 'master' into 2-0-stable-Feb12
2019-02-12 16:03:33 +00:00
Kristina Lim
5fce9d0a7d
Add multi-distributor scope to shipping and payment methods
2019-02-08 21:26:37 +00:00
luisramos0
b16ed86b2d
Fix shipping_method basic test. Adapt to spree 2 that needs shipping_categories to be set and sets them on the base factory in a after_create block, the build command was not picking it up
2018-10-27 20:34:25 +01:00
Pau Perez
5c260dae51
Remove no longer valid tests
...
`#available_to_order?` is gone in Spree 2.0 and our customization on top
of it went away with #2256 .
2018-05-14 12:30:11 +02:00
Rob Harrington
59578a73af
Changing all references to 'be_true' and 'be_false' to 'be true' and 'be false'
...
See next commit for changes where this substitution was broken
2017-11-10 08:47:12 +11:00
Pau Perez
1f2820f6d4
Add #delivery? in ShippingMethod
2017-08-11 14:41:02 +10:00
Rohan Mitchell
780ec598d6
Use preferred_currency instead of preferences[:currency]. Use constant for currency instead of config var.
...
Conflicts:
spec/models/spree/shipping_method_spec.rb
2016-03-04 11:53:32 +11:00
Rohan Mitchell
1440544b2d
Use persisted models
2016-03-04 11:41:49 +11:00
Rohan Mitchell
bc2223fb8e
Fix intermittent spec fails: currency inconsistencies on CI and retry on VOs
2016-03-04 10:15:57 +11:00
Rohan Mitchell
22230294ab
Merge branch 'master' into optimise-shopfront
2015-06-03 10:07:42 +10:00
Rohan Mitchell
97e49c2bdb
Replace 'array.sort.should == expected.sort' pattern with match_array
2015-05-28 10:46:08 +10:00
Rohan Mitchell
f0e909c92b
Look up the shipping services (pickup, delivery) that different hubs provide
2015-05-27 15:44:01 +10:00
Will Marshall
cc3fb27490
Restoring the old checkout, but NOW our new checkout is broken
2014-03-06 16:16:00 +11:00
Rohan Mitchell
5f4d787d26
Fix sorting error in spec
2014-01-08 14:43:46 +11:00
Rohan Mitchell
48f18a93de
Order shipping methods by name, not distributor
2013-11-07 16:25:43 +11:00
Rohan Mitchell
bd112c64b0
Fix edit enterprise link to point to edit page, fix spec breakages
2013-10-18 15:39:58 +11:00
Rohan Mitchell
3b5e6f5742
When viewing shipping methods, only show those for the distributor I select
2013-10-18 10:01:11 +11:00
Rohan Mitchell
93cb845ee2
DB and model changes to make ShippingMethod distributor habtm
2013-10-17 11:15:43 +11:00
Rohan Mitchell
8654f23a19
Move spree model decorator specs into their own dir to mirror model dir layout
2013-10-17 09:53:54 +11:00