cyrillefr
e19caa0caa
Style Metrics/ModuleLength in spec file
2025-06-17 15:27:31 +02:00
Maikel Linke
be312246ec
Stop referring to stock movements
2025-05-13 15:24:26 +10:00
Filipe
e2161660b3
Merge pull request #13090 from mkllnk/replace-spree-roles
...
Replace spree roles
2025-01-30 21:30:56 -06:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Maikel Linke
70ebe7b964
Remove stock location from specs
2025-01-22 11:52:25 +11:00
Maikel Linke
271475893d
Remove unused stock aggregation
2024-11-01 16:46:35 +11:00
Maikel Linke
d2e5087668
Remove redundant HTML sanitisation
...
We don't need to run the sanitiser each time we read an attribute. It's
a waste of time.
2024-10-24 08:47:11 +11:00
Gaetan Craig-Riou
b0433bd8f5
Re add test for invalid cloned products
...
There is no easy way to make the original product invalid, but we can
make sure the cloned product will be invalid. The cloned product add
"COPe OF " in front of the product's name, so by starting with a name
that's long enough, the cloned product will have a name longer that 255
char and will then be invalid.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
9db417319d
Improve variant related validation when creating product
...
I disabled Metrics/AbcSize for ensure_standard_variant as I don't think
that's hard to understand the code. And utimately it will be removed
once product actually becomes optional.
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
00dfe6810f
Fix ProductDuplicator
...
There isn't away I could think of to create an invalid product, so I
removed those test
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
d0fe1585d7
Move variant unit attributes to variant 2
...
Update Spree::Product and spec
2024-10-14 14:56:46 +11:00
Gaetan Craig-Riou
448308710a
Per review, distributor are now updated via variant
...
When a product is deleted, it will delete associated variant and
in turn will touch the affected distributors
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
f73745a803
David's first review changes
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
c328ee8087
Remove stockable_by from Product and Variant
...
It's not used anymore
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
117f6d3300
First round of code review change
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
260211cf15
Fix Ruboxop issue
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
891f79666d
Spree::Product remove in_supplier_or_distributor scope
...
It is not used anywhere
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
b6faa43879
Fix touching distributor callback spec
...
The original spec check if the supplier and distributor where
updated after deleting product. In reality, the supplier and the
distributor are the same, so no need to test with the supplier
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
3dc7c2bf56
Fix spree product touch supplier
...
Take into account import product scenario, in this case the variant
doesn't have an assigned supplier yet.
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
564ea0bd49
Fix enterprise touching when associated record updated
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
25371ee9d0
Fix admin pages
...
- move supplier to variant row on Bulk Edit product page
- add supplier dropdow on add/update variant page
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
0c9223809b
Fix with_properties scope to accept any number of arguments
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
02b9dfb517
Add after update primary taxon call back
...
It updates supplier on primary taxon update. It fixes falling
enterprise caching specs.
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
8abea0afcf
Add missing associations and validations specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d1dd563720
Move supplier to variant part 1
2024-07-03 10:17:48 +10:00
David Cook
d799230440
Update controller to catch more specific error
...
We now know which errors to expect. We still let other unknown errors raise higher up, where they will be logged with BugSnag, and treated as internal_server_error.
2024-06-27 12:51:28 +10:00
Ahmed Ejaz
4315a05eb8
11987: fix lint issue
2024-06-26 16:32:32 +05:00
Ahmed Ejaz
3f6e5e7d09
11987: duplicate product without raising error
2024-06-26 16:00:59 +05:00
Ana Nunes da Silva
a7dc243db9
Sanitize product description using rails default sanitizer
2024-06-03 11:45:49 +01:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel
cf9414a352
Merge pull request #12329 from openfoodfoundation/dependabot/bundler/rubocop-rspec-2.28.0
...
chore(deps-dev): bump rubocop-rspec from 2.27.1 to 2.28.0
2024-04-04 13:43:02 +11:00
David Cook
6cff5c81fe
Fix RSpecRails/NegationBeValid
...
Another cop that only supports not_to instead of to_not.
2024-04-04 09:41:05 +11:00
Matt-Yorkley
d3e62c4390
Add test for persisting taxon on variant during product creation
2024-04-02 09:43:24 +11:00
Matt-Yorkley
8a364a5f48
Fix product touch spec
2024-04-02 09:43:24 +11:00
Matt-Yorkley
d9899e8af6
Update more specs
2024-04-02 09:27:36 +11:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
David Cook
250f7be8a0
Re-organise spec
2024-02-23 12:36:42 +11:00
David Cook
b758bf0735
Fix spec
2024-02-23 12:36:10 +11:00
David Cook
2107aeded1
Un-safely autocorrect RSpec/ExpectChange
2024-02-23 12:17:09 +11:00
David Cook
b42cf9735f
Only validate an image if it has been changed
...
Best viewed with whitespace ignored.
2023-10-11 10:12:52 +11:00
David Cook
31b5be73f9
Add spec
2023-10-11 10:12:52 +11:00
David Cook
3ec6386e1c
Validate length of some product fields
...
We know if the values are too long, so let's provide a useful message rather than generating an unhandled database error.
This code seems rather repetetive, it would be good to use a shared module. I wonder if there's a gem for that.
Note that the existing /products/*/edit screen doesn't even handle validation errors yet, but that's something for another day..
2023-10-06 14:15:07 +02:00
Neal Chambers
35e8f88943
Fix Style/HashSyntax
2023-09-24 22:41:27 +09:00
Mohamed ABDELLANI
3ab288f435
fix product's unit value validation
2023-08-22 09:16:47 +01:00
Mohamed ABDELLANI
a9e4159839
validate unit_value > 0 on product model
2023-08-22 09:16:47 +01:00
Matt-Yorkley
c18c525d9f
Save shipping category selection to new variant when creating a new product
2023-08-14 21:02:47 +01:00
Maikel Linke
e6c679cb34
Apply belongs_to_required_by_default to all models
...
Unless they state otherwise.
The new standard also changes the default behaviour of the Shoulda
matcher in Rspec. It now defaults to asserting that an association is
required. That needed some spec updates.
In one case, Spree::Product, I also had to update the model because the
presence validation was somehow not recognised by the Shoulda matcher.
The error message may change slightly but the outcome should be the
same.
2023-08-11 10:14:47 +10:00
Matt-Yorkley
a33b6e0ec9
Update variant sorting
2023-08-09 18:30:56 +01:00
Matt-Yorkley
321047d663
Update specs
2023-08-08 11:36:31 +01:00
Matt-Yorkley
e4a49f5d02
Update product duplication
2023-08-08 11:36:31 +01:00
