cyrillefr
5788698e8e
Fixes RSpecRailsInferredSpecType offenses in jobs & mailers
2025-05-20 12:57:11 +02:00
Konrad
9ee37ee0b6
Update specs
2025-04-01 18:11:13 +02:00
Maikel Linke
10f0eeef0b
Update spec for quotation mark replacement
...
I'm not sure why, but the pre-compiling of assets triggered Rails to
render `style="..."` instead of `style='...'` in this case. But when
assets are compiled on-demand, we get the single quotes. So I changed
the spec to be agnostic of this detail. We actually just want to know
about the link and its href.
2024-06-19 11:40:09 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Neal Chambers
7ecd4a149b
Fix Style/HashSyntax
2023-09-21 22:58:42 +09:00
Neal Chambers
5b6f45931c
Fix Layout/LineLength
2023-06-26 13:06:56 +09:00
Jean-Baptiste Bellet
f7d06fe0e8
Do not display OFN banner on subscription confirmation email if white label
...
+ add specs that test for the presence of the footer logo which is in the header (I know it's a bit contradictory)
2023-05-17 11:34:35 +02:00
Maikel Linke
9998025687
Remove useless test header setup for emails
...
Once upon a time we needed a helper to set the `from` header of emails.
This is now set in the ApplicationMailer and not necessary any more.
2023-04-20 12:15:34 +10:00
cyrillefr
ffe9756f50
Removes I18n keys in mailer specs
2023-02-16 14:27:21 +01:00
filipefurtad0
464496befa
Adds traits to enterprise_factory and spec
2022-06-13 16:40:55 +01:00
filipefurtad0
9c8756bf42
Makes the spec red: deletes file attachement from assertion
2022-06-13 16:26:09 +01:00
Maikel Linke
dd659f16c0
Correct method name for shop logo in email
2022-06-09 16:00:57 +10:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Pau Perez
5cf4aecc26
Enable customer_balance toggle in tests
...
This makes all tests exercise the new branch that `OrderBalance`
abstracts. It follows up #7363 addressing code review comments.
2021-04-12 09:31:23 +02:00
Andy Brett
d00970e05d
Merge pull request #7207 from andrewpbrett/fix-nil-price-subs
...
Report subscription failures
2021-04-09 12:13:11 -07:00
Andy Brett
61a39311b4
improve specs
2021-03-29 22:51:40 -07:00
Pau Perez
5815d1a4a4
Make #outstanding_balance return an OrderBalance
...
This will let us branch by abstraction. All existing calls to
`#outstanding_balance` will go through `OrderBalance` hence, will
check the feature toggle.
Note that by default, `OrderBalance` will end up calling
`#old_outstanding_balance`. As the name states, that's exactly what
`#outstanding_balance` was so far. This means no consumers will see any
change in behavior. We just added on item in the call stack (sort of).
2021-03-22 11:45:12 +01:00
Pau Perez
85446c0dde
Rearrange and cover balance in subs mailer specs
...
This moves them to a more unit-like style where the mailer methods are
the subjects. However, I did so only for the methods that show order
balance and thus we want to be extra sure of their coverage.
2021-03-18 09:18:16 +01:00
Luis Ramos
34ae3ca24d
Replace spree_order_url with order_url so we can use scope in the routes file
2021-01-25 19:56:25 +00:00
Luis Ramos
00fcb89af1
Fix order_url routes in a few places
2021-01-25 19:52:48 +00:00
Matt-Yorkley
3e6445c51c
Replace deprecated ActionMailer#deliver with ActionMailer#deliver_now
...
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job.
2021-01-08 20:35:47 +00:00
Luis Ramos
2b8f0abe49
Try some mass auto-correct adding frozen-string-literal to all specs
2020-12-03 06:38:24 -08:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
0009b663e7
Specify :mailer type in specs
...
According to RSpec docs we need to specify type: :mailer for mails to
work. Check it out:
https://relishapp.com/rspec/rspec-rails/v/3-8/docs/mailer-specs .
This fixes all specs in SubscriptionMailer
2019-01-13 15:50:35 +00:00
luisramos0
fcdb5cd7af
Merge branch 'master' into 2-0-stable-nov-8th
2018-11-08 11:18:54 +00:00
Maikel Linke
e6adb8a3b9
Extract email setup in specs for easy upgrade
...
The way we set up email sending completely changes with Spree 2. This
change encapsulates that code in a single method so that it can be
changed easily and doesn't create further merge conflicts while we are
still working on the master branch and the Spree upgrade.
2018-10-25 13:53:22 +11:00
luisramos0
801c4d1cab
Making SubsMailerSpec pending, 21 tests to be fixed in issue #2786
2018-09-29 23:31:11 +01:00
luisramos0
89d51d75ae
Merge branch 'master' into 2-0-stable-sept
2018-09-04 17:43:20 +01:00
luisramos0
8004abbb9f
Improved Order mailer and Subscriptions mailer specs by removing dependency to old mail method
2018-09-03 10:03:06 +01:00
Kristina Lim
f844236b9c
Remove order link in non-user order cancellation email
2018-09-01 23:46:12 +08:00
Kristina Lim
5f2c3a1955
Remove order link in non-user failed payment email
2018-09-01 23:46:12 +08:00
Kristina Lim
f8244a400a
Custom subscription placement email if non-user
...
The order link should not be provided if the order does not have an
associated user account.
2018-09-01 23:46:11 +08:00
Kristina Lim
dc4037474d
Test order links in subscription placement emails
2018-09-01 15:40:36 +08:00
Rob Harrington
b7876ebfbf
Replace references to 'standing order' with 'subscription' (spec)
2018-02-09 14:44:14 +11:00
Rob Harrington
902802594f
Renaming standing order files (lib, spec)
2018-02-09 14:44:13 +11:00
