Neal Chambers
|
4cce85378c
|
Safely autocorrect Rails/WhereNot
Inspecting 1488 files
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Offenses:
lib/reporting/reports/users_and_enterprises/base.rb:27:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprises: { id: nil }) instead of manually constructing negated SQL in where.
.where("enterprises.id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:39:14: C: [Corrected] Rails/WhereNot: Use where.not(enterprise_id: nil) instead of manually constructing negated SQL in where.
.where("enterprise_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/users_and_enterprises/base.rb:40:14: C: [Corrected] Rails/WhereNot: Use where.not(user_id: nil) instead of manually constructing negated SQL in where.
.where("user_id IS NOT NULL")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1488 files inspected, 3 offenses detected, 3 offenses corrected
|
2023-09-01 08:55:56 +09:00 |
|
Cillian O'Ruanaidh
|
40b0bfb433
|
Add an OFN UID column to the Users & Enterprises report
|
2023-06-25 19:01:42 +02:00 |
|
Sebastian Castro
|
56fab26235
|
Reports: refactor to easily provide default_params
|
2022-05-12 16:54:14 +02:00 |
|
Sebastian Castro
|
0218f75f34
|
Packing Report: hide by default phone and price column to avoid breaking changes
|
2022-05-12 16:54:14 +02:00 |
|
Sebastian Castro
|
5105ea345f
|
Reports Refactor 4: Final Touch
Split report_template
Clean code
Adds spec
|
2022-05-12 16:54:14 +02:00 |
|
Sebastian Castro
|
88bc417868
|
Report Refactor 3: User & Entreprises
|
2022-05-12 16:54:13 +02:00 |
|
Sebastian Castro
|
caccbb698b
|
Reports Refactor 2: Fix linting
|
2022-05-12 16:54:13 +02:00 |
|
Sebastian Castro
|
288a35f062
|
Reports Refactor 2: New templates abstract classes
|
2022-05-12 16:54:13 +02:00 |
|
Sebastian Castro
|
5f78fdce8b
|
Reports Refactor 2: Move all code to lib/reporting
|
2022-05-12 16:54:13 +02:00 |
|