Maikel Linke
1d2115766a
Show product groups to platform user
...
I removed the caching of `managed_enterprises` in Permissions because
it's just a scope and calling it again is very cheap. And that makes the
method a lot easier to read now that we have a conditional here.
Accessing the managed enterprises via the user instead of a separate
scope on the Enterprise model also reduce the SQL queries. We may want
to use this method in more places. I prefer to keep the
admin-conditional in a permissions class instead of in the model.
2025-08-13 15:06:31 +10:00
Gaetan Craig-Riou
e48cdeba20
Fix product related permissions
2024-07-03 10:17:49 +10:00
Matt-Yorkley
eef59bbaae
Improve permissions query building
...
For larger queries and especially where filtering and paginating, these simpler product queries are way more efficient. It cuts out some very large subqueries with large lists of product ids.
2022-04-05 22:28:09 +01:00
Maikel Linke
b999673dfc
Remove old version of relaxed styled guide
...
We had an old version under "contested settings" and it looks like some
of them were modified. I hope that our new, separate file will
discourage manual tweaks.
We can include the relaxed rules from a gem as well. Let's see if we
need that complexity one day.
2022-02-25 10:51:54 +11:00
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Matt-Yorkley
98fdbb8621
Update deprecated #scoped calls
...
Model#scoped is now deprecated. Model#where(nil) in Rails 4 returns the same result as Model#scoped in Rails 3
2020-02-22 11:06:51 +00:00
luisramos0
beaa8ffa27
Use more specific selector to avoid ambigous column error
2019-11-29 11:45:22 +00:00
luisramos0
5cb77c443b
Fix rubocop issues
2019-11-29 10:53:40 +00:00
luisramos0
484cdd1e07
Make managed_and_related_enterprises public so they can be used by other permissions classes
2019-11-29 10:49:27 +00:00
luisramos0
89056e13ed
Extract order permissions to a separate class
2019-11-29 10:48:58 +00:00
luisramos0
df0458743b
Replace pluck with select in permissions to avoid extra queries
2019-11-28 23:37:49 +00:00
Matt-Yorkley
7b5e5f4039
Clean up OpenFoodNetwork::Permissions
2019-11-12 11:57:19 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
ef61310bad
Fix long lines in order_cycle_permissions and permissions
2019-07-04 17:17:58 +01:00
luisramos0
bb9c54a445
Use enterprises.id instead of :id to remove ambiguous column errors
2019-07-03 22:03:40 +01:00
luisramos0
e5f396f975
Fix Permissions.related_enterprises_granted by adding explicit reference to table
2019-07-03 20:18:01 +01:00
luisramos0
a57a93d414
Adapt permissions.rb and order_cycle_permissions to rails 4
2019-07-03 20:18:01 +01:00
luisramos0
5184fa540c
Adapt enterprise_relationship permitting and permitted_by scopes to rails 4
2019-07-03 20:18:00 +01:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
Pau Perez
147a74f005
Fix Rubocop violations reported by Code Climate
2018-04-16 10:27:44 +02:00
Pau Perez
33ea2c0b07
Auto correct Rubocop's Layout/FirstParameterIndentation cop
2018-04-09 18:47:18 +02:00
Rob Harrington
04e48989c9
Replace references to 'standing order' with 'subscription' (lib)
2018-02-09 14:44:13 +11:00
Rob Harrington
c18c1c67d1
Adding visibility permissions for standing orders
2018-02-09 14:43:32 +11:00
Rob Harrington
357040f67a
Enterprise User can create and update schedules via OC index
2018-02-09 14:43:28 +11:00
Rob Harrington
920f52e112
Adding schedules to Order Cycles interface
2018-02-09 14:43:28 +11:00
Pau Perez
cee24dcca7
Use indented style for multiline method calls
...
This enables the Rubocop's Style/MultilineMethodCallIndentation cop with
indentend enforced style. Which makes you split multiline method calls like:
orders = Spree::Order
.an_scope
.another_scope
.where(id: list_of_ids)
It also autofixes the current violations and updates the
rubocop_todo.yml
2017-07-12 10:40:53 +02:00
Rob Harrington
465649475d
Revoke ability to overide variants based on shared management/ownership (ie. only explicit permissions)
2016-03-02 12:10:49 +11:00
Rob Harrington
186d1c1f26
Revoking ability to create variant overrides via OC permission
2016-03-02 12:10:49 +11:00
Rob Harrington
ae7e744644
WIP: BOM Refactor, adding for_line_items action to enterprises controller
2015-11-04 15:02:29 +11:00
Rob Harrington
8132f07d88
Adding visible products method to permissions
2015-05-20 15:53:10 +10:00
Rob Harrington
01d4cf6ecf
Renaming managed_products permissions method to editable_products
2015-05-20 15:02:36 +10:00
Rob Harrington
a7019e7e78
Adding permissions method for order report enterprises
2015-05-07 12:50:56 +10:00
Rob Harrington
bd66091d75
Push logic for checking of user super admin status down into private method
2015-05-07 12:50:56 +10:00
Rob Harrington
d8f5669fbb
Renaming granted > related_enterprises_granted
2015-05-07 12:50:56 +10:00
Rob Harrington
5806f50a84
Renaming granting > related_enterprises_granting
2015-05-07 12:50:56 +10:00
Rob Harrington
5cd528a87d
Removing obsolete related_enterprises_with permission method
2015-05-07 12:50:56 +10:00
Rob Harrington
f0f7e0ee2f
Making permissions method managed_and_related_enterprise_with method more specific
2015-05-07 12:50:56 +10:00
Rob Harrington
7ffe0f042e
Moving accessible_by scope on Enterprise to permissions
2015-05-07 12:50:55 +10:00
Rob Harrington
0a03483e36
Adding permissions methods for visible and editable orders and line_items
2015-05-07 12:50:55 +10:00
Rob Harrington
bc89018ee1
Refer to the right variable doofus
2015-04-11 23:24:50 +10:00
Rob Harrington
6f81a9ba18
Save common permission method results as instance variables
2015-04-11 22:53:57 +10:00
Rob Harrington
26d55baa35
Moving order cycle permissions to their own permissions class
2015-04-11 21:11:10 +10:00
Rob Harrington
c28ebf63ab
As participating Hub, I cannot edit incoming exchanges despite being granted P-OC by the producer
2015-04-09 13:41:43 +10:00
Rob Harrington
b1624a733e
Editable variants for incoming exchanges for hubs include those for producers that have granted my hub P-OC
2015-04-08 13:38:37 +10:00
Rob Harrington
b8ce6ed0fc
Coordinator can see any enterprises that are already in the order cycle
2015-04-08 13:28:49 +10:00
Rob Harrington
104a8ddecf
Refactor order_cycle_enterpises_for permission method, now requires an order cycle
2015-04-08 13:00:17 +10:00
Rob Harrington
4dcfec1de9
make enterprises_for_order_cycle permissions more correct
2015-04-08 12:12:02 +10:00
Rob Harrington
8859aa27ee
Slight refactor of order cycle enterprises
2015-04-08 10:33:32 +10:00
Rob Harrington
24062e5585
Adding permissions for outgoing hubs to see producers whose variants they are distributing, despite P-OC not existing
2015-04-08 10:15:50 +10:00
Rob Harrington
4a87798bb4
Variants belonging to a producer I manager that are already in an outgoing an exchange need not be editable
2015-04-06 23:30:43 +10:00
