Konrad
06ebeeac0f
Merge pull request #11543 from rioug/11364-Voucher-fix-tax-report
...
[Vouchers] Fix Sales Tax Totals By Order report
2023-10-01 02:09:33 +02:00
Gaetan Craig-Riou
097b775fa0
Add metadata before saving adjustment
...
Rails may put it all in one transaction
Co-authored-by: Maikel <maikel@email.org.au >
2023-09-25 17:44:16 +10:00
Gaetan Craig-Riou
03ce39d5c5
Add metadata to tax related voucher adjustment
...
In the scenario where you have tax excluded from price, when adding
a voucher to an order, we create 2 voucher adjusments. One of them
represent the tax part of the voucher, and has a label starting with
"Tax". To better differentiate them and allow a reliable way to
query it, we add a metadata entry.
2023-09-22 11:16:21 +02:00
Gaetan Craig-Riou
7c34145ed7
Add voucher_included_tax and voucher_excluded_tax
...
It retrieves the tax part of the voucher adjustment for tax included
in price and tax excluded from price respectively.
2023-09-22 10:17:40 +02:00
Gaetan Craig-Riou
776f478038
Make update the only public method
...
I think this got lost when refactoring, but only `update` is meant
to be a public method, other than `new`.
2023-09-15 11:42:04 +02:00
Neal Chambers
bf9db13bb3
Fix Style/HashSyntax
2023-09-14 16:25:49 +09:00
Gaetan Craig-Riou
2828bd098d
Refactor VoucherAdjustment service
...
We are taking advantage of having a FlatRate and a PercentageRate
model to simplify the code a little
2023-08-11 15:41:34 +10:00
Gaetan Craig-Riou
70bd714369
Finish calculation for percentage voucher
...
Add calculation when tax is not included in price
2023-08-11 14:51:36 +10:00
Gaetan Craig-Riou
cdb33aa0d0
Add calculation for percentage voucher
...
It include calculation for order with taxes included in the price
2023-08-11 14:30:48 +10:00
Gaetan Craig-Riou
a5b2bc6293
Per review, Refactor VoucherAdjustmentsService
...
Change #calculate to #update and clean up internal code
2023-07-18 15:16:21 +10:00
Gaetan Craig-Riou
a584f9aaec
Refactor VoucherAdjustmentsService
...
It's more inline with existing coding style
2023-07-18 14:39:01 +10:00
Gaetan Craig-Riou
3d9542fec2
Per review, rename amount to adjustment_amount
...
It was confusing as I was re assigning a variable given as a parameter
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
87790b29ae
Fix VoucherAdjustmentsService.calculate so we can call it mutiple time
...
It now uses `order.pre_discount_total` to make any calculation, that
means you can call it multiple time and you will still get the same
adjustment amount, included_tax and tax adjustment when needed. This
is assuming nothing changed on the order.
2023-07-14 14:47:03 +10:00
Matt-Yorkley
47b5a3fb1d
Don't apply tax calculations if there's no tax
2023-07-04 13:13:05 +01:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
