5 Commits

Author	SHA1	Message	Date
Matt-Yorkley	a8559e621f	Simplify exchange variant callback and prefer delete over destroy ... Delete is faster than destroy but should only be used if the object has no callbacks or touches.	2023-05-19 11:26:33 +01:00
Neal Chambers	77733169fc	Update OCs after ERs Permissions are Revoked	2023-04-04 09:37:13 +09:00
Luis Ramos	e52937c113	Use rubocop auto correct to add frozen string literal to all files ... This is an unsafe auto corection, we will need to trust our build here	2021-06-17 23:07:26 +01:00
Maikel Linke	b4d1e48693	Update soft-delete of variants ... Spree changed their way of soft-deleting variants from calling `delete` to calling `destroy`. We don't need our own implementation any more.	2019-02-19 14:25:18 +11:00
Maikel Linke	cdb49f88b0	Move Variant deletion into its own service ... This keeps the override of Spree's model leaner. More importantly, it prepares us for using `destroy` instead of `delete`. In the past, `Product#delete` soft-deleted the product, but didn't delete the variants. When we use `Product#destroy` to soft-delete the product, it will also call destroy on the variants. If the model doesn't allow the deletion of the last variant, it will fail. So when a product is deleted we want to allow the deletion of all variants. But the user should not be allowed to delete the last variant. That's why I'm moving the check to the controller level. Related commits: - e6c7acdff3 - 2b47c9145a - b9f19d5777 (diff-412c5af2ec1ba9f6643f6df5a673c1d4R105)	2019-02-19 14:25:18 +11:00