Jean-Baptiste Bellet
d1d050e6a4
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
Maikel Linke
99fbf80b4c
Style Layout/MultilineMethodCallIndentation
2023-06-08 11:15:42 +10:00
Matt-Yorkley
bf051fc35b
Pull checkout-workflow-related callback methods out into the Checkout module which defines checkout state changes
2023-06-07 18:54:20 +01:00
Matt-Yorkley
760bf269ca
Pull validations-related methods out into a separate module
2023-06-07 18:54:20 +01:00
Filipe
2d28a57c6f
Merge pull request #10922 from jibees/10903-white-label-make-logo-url-link-more-tolerant-in-terms-of-format-and-add-example
...
[White Label] Make logo url link more tolerant in terms of format
2023-06-07 10:00:31 +01:00
Maikel Linke
1ebacf96ad
Ignore accidental spaces around whitelabel URL
2023-06-07 13:12:06 +10:00
Matt-Yorkley
e88843c733
Ensure order number is generated nicely on new records
2023-06-07 00:58:43 +01:00
Matt-Yorkley
67c3e09dba
Use RESTful routes for orders controller actions
2023-06-07 00:35:47 +01:00
Matt-Yorkley
7c72969792
Move Order #state_changed method out into Checkout concern (alongside order states logic)
2023-06-05 23:54:04 +01:00
Matt-Yorkley
a62e51c0d0
Remove Order #refresh_shipment_rates method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
1a7d70772a
Make Order #products_available_from_new_distribution method private
2023-06-05 23:54:04 +01:00
Matt-Yorkley
3dd4e7ef03
Delegate order updater method
2023-06-05 23:54:04 +01:00
Matt-Yorkley
8a27dd84fe
Make Order #disallow_guest_order method private
2023-06-05 21:30:49 +01:00
Matt-Yorkley
05a715a43a
Remove Order #distribution_set? method
2023-06-05 21:30:46 +01:00
Matt-Yorkley
17b10d10c0
Make Order #deliver_order_confirmation_email method private
2023-06-05 21:30:43 +01:00
Matt-Yorkley
10dbeb32b2
Remove Order #credit_cards method
2023-06-05 21:30:40 +01:00
Matt-Yorkley
b3bd112cdb
Remove Order #shipped_shipments method
2023-06-05 21:30:36 +01:00
Jean-Baptiste Bellet
1594d1c718
Validate custom tab title
2023-06-05 15:41:33 +02:00
Jean-Baptiste Bellet
40111910b6
Validates white_label_logo_link on enterprise model
2023-06-05 11:24:07 +02:00
Maikel Linke
1cbb45a618
Style Lint/RedundantSafeNavigation
...
The cop suggested to change more but they were false positives:
* https://github.com/rubocop/rubocop/pull/11915
2023-06-05 12:09:32 +10:00
Jean-Baptiste Bellet
880ba85791
Add http to white label logo link if this do not start with http
2023-06-01 17:37:05 +02:00
Filipe
2ba0f635f2
Merge pull request #10860 from Matt-Yorkley/order-cycle-deleting
...
Delete exchange variants in bulk when deleting an order cycle
2023-06-01 13:49:32 +01:00
Matt-Yorkley
0ac10472cf
Update app/models/spree/line_item.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
a20277c3a7
Completely remove option_values and option_types from the codebase
2023-06-01 10:12:19 +01:00
Matt-Yorkley
35b41fc7fe
Persist unit_value on variant and "option value text" on variant and line_item and improve related AR callbacks
2023-06-01 10:12:19 +01:00
Matt-Yorkley
bfcf1203ac
Delete dead code
2023-06-01 10:11:20 +01:00
Matt-Yorkley
3e5ecba738
Remove unhelpful Helper
2023-06-01 10:11:20 +01:00
Jean-Baptiste Bellet
925b0e0308
Add a form in admin to create/update a custom tab for an enterprise
2023-05-25 09:19:51 +02:00
Jean-Baptiste Bellet
839419791f
Create CustomTab model, that belongs to an enterprise
2023-05-25 09:19:51 +02:00
Maikel Linke
ef3422bf58
Update syntax and clarify use of outdated gem
2023-05-23 08:23:58 +02:00
Maikel Linke
90cbac7176
Validate email domains
...
The gem checks the DNS system for a valid domain entry.
2023-05-23 08:23:58 +02:00
Maikel Linke
ffc45f77cf
Validate user email syntax on change
...
We probably have invalid entries in the database and we don't want these
records to suddenly become invalid. People would not be able to log in.
2023-05-23 08:23:58 +02:00
Matt-Yorkley
459ef5f0d1
Only delete related exchange variants if exchange is outgoing
2023-05-22 11:09:29 +01:00
Konrad
fed7c3da51
Merge pull request #10761 from rioug/vouchers-any-amount
...
[Vouchers] Flat rate of any amount
2023-05-19 17:39:33 +02:00
Matt-Yorkley
a8559e621f
Simplify exchange variant callback and prefer delete over destroy
...
Delete is faster than destroy but should only be used if the object has no callbacks or touches.
2023-05-19 11:26:33 +01:00
Matt-Yorkley
434c9ae110
Delete exchange variants in bulk when deleting an order cycle
2023-05-19 10:46:55 +01:00
Filipe
3d1b0816ed
Merge pull request #10512 from abdellani/fix-tax-not-charged-when-tax-category-set-to-inherit-from-product
...
Prevent saving the enterprise fee when a per order calculator is selected along with 'Inherit from product'
2023-05-18 13:43:14 +01:00
Konrad
39bb1f6f41
Merge pull request #10832 from Matt-Yorkley/cloning
...
Clone all ExchangeVariant objects in bulk
2023-05-18 14:32:30 +02:00
David Cook
c0c123a92a
Remove localized number logic from weight calculator
...
Follow-on from a46eef291c
2023-05-17 14:10:58 +02:00
saunmanoj888
aee7645e29
Fix searching issue with full name on bulk order management
2023-05-17 13:14:10 +02:00
Gaetan Craig-Riou
b585f77be4
Make enterprise mandatory for a voucher
...
It should have already been the case...
2023-05-16 16:20:04 +10:00
Gaetan Craig-Riou
15eee8175e
Add amount to voucher
...
Change value to amount to be more consistent
2023-05-16 16:19:59 +10:00
Maikel
10c918be75
Merge pull request #10732 from mkllnk/report-email
...
[Hidden] Notify about completed report with download link via email
2023-05-16 10:25:23 +10:00
Maikel Linke
08aff56e20
Expire report files after 1 week, maximum for S3
...
We didn't see this in tests which use disk storage. But AWS S3 has a
maximum of one week for URL expiry.
2023-05-15 19:41:45 +02:00
Maikel Linke
299bc253a4
Expire report download links in a month, not 5mins
2023-05-15 19:41:45 +02:00
Gaetan Craig-Riou
d29119f5c5
Remove non need belongs_to associations from Adjustments
...
It turns out the "tax_rate" association isn't used and wasn't working.
Same for the "voucher" one, which I added to be consistent with existing
code.
Both of these weren't caught by the specs because you can't test associations
with a custome relation with 'shouda-matchers' see: https://github.com/thoughtbot/shoulda-matchers/issues/981
2023-05-15 13:42:40 +10:00
Matt-Yorkley
9b1725d39f
Fix model name in adjustment association
2023-05-15 13:42:40 +10:00
Gaetan Craig-Riou
17e32a89f8
Add VoucherAdjustmentsService to handle calculation
...
Refactor Voucher to move voucher adjustments calculation
to VoucherAdjustmentsService
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
56e981d300
Refactor Voucher to get rid of CalculatedAdjustments
...
Voucher adjustment have complicated calculation that prevent us from
using Spree::Calculator, and we need to override CalculatedAdjustments
method, so no point using it.
We still keep the same methods to stay as consitent as possible in
regards to adjustments
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
43ab881181
Rename order association to voucher_adjustments
...
The name vouchers is a bit confusing as the order is linked to a
voucher adjutment and not the actual voucher
2023-05-15 13:42:39 +10:00