luisramos0
758394464b
Add bugsnag notification to products_controller create and update when on_hand or on_demand update fails with exception
2019-08-17 19:15:32 +01:00
luisramos0
b9ddb39edc
Re-add taxons jstree action to make taxonomies config page work again
2019-08-14 16:31:34 +01:00
Pau Pérez Fabregat
64d21969f0
Merge pull request #4064 from luisramos0/convert_search_Rabl
...
Replace views/admin/variants/search.rabl with Api::Admin::VariantSerializer
2019-08-05 15:07:10 +02:00
luisramos0
31bac9641f
Move api products and variants routes and ctrl out of spree namespace
2019-08-01 14:28:55 +01:00
luisramos0
6c054e6078
Add bulk_products and overridable to skip_authorization_check so these endpoints work with AMS
2019-07-31 12:18:27 +01:00
luisramos0
78ab852141
Make spree/api/products_controller work with AMS
2019-07-31 11:23:43 +01:00
luisramos0
4d74d246e8
Remove spree/api/products_controller index and new actions, not used
2019-07-31 10:32:45 +01:00
luisramos0
cc51537e93
Convert spree/api/products_controller from rabl to ams
2019-07-31 09:50:34 +01:00
luisramos0
07aececdcf
Remove unused route api/products managed
2019-07-31 09:50:31 +01:00
luisramos0
c3fbf9cdf9
Remove unused pagination from index and respective specs, fix spec for search by sku by adding sku to the serializer and adapt a few specs to pass with AMS attrivbutes,
2019-07-31 09:40:19 +01:00
luisramos0
180598c603
Convert spree/api/variants_controller to AMS by changing base_controller, using render json instad of respond with, deleting rabl templates and adapting specs
...
Delete unused pagination spec
2019-07-31 09:40:19 +01:00
luisramos0
18aa16650d
Remove dependency to Spree::ApiConfiguration, overall requires_authentication? is true, exceptions will be endpoint specific
2019-07-31 09:35:46 +01:00
luisramos0
314ed50e0f
Fix a rubocop issue in spree/api/products_controller
2019-07-31 09:34:20 +01:00
luisramos0
c668677b8a
Bring spree/api/taxons_controller_spec from spree_api, adapt it, transpec it and fix rubocop issues
2019-07-31 09:32:33 +01:00
luisramos0
0e4fe08ac4
Fix logical problem in spree/api/base_controller and in spree/checkout_controller
...
See this stack overflow post for more info: https://stackoverflow.com/questions/39629976/ruby-return-vs-and-return
2019-07-31 09:32:33 +01:00
luisramos0
cf0f716534
Fix easy rubocop issues in spree/api/taxons_controller
2019-07-31 09:32:33 +01:00
luisramos0
b70cfa5968
Bring spree/api/taxons controller from spree_api as it is needed in OFN admin
2019-07-31 09:32:33 +01:00
luisramos0
f77beb50ff
Fix class scope in spree/api/products_controller, should not use Spree namespace here
...
Also, add missing dependency to spree/admin/products_controller_decorator
2019-07-31 09:32:33 +01:00
luisramos0
a941280982
Fix easy rubocop issues in spree/api/base_controller
2019-07-31 09:32:33 +01:00
luisramos0
9d40ee49e6
Bring spree/api/base_controller from spree_api
2019-07-31 09:32:33 +01:00
luisramos0
6abbdecb97
Fix the easy rubocop issues in the new spree api controllers
2019-07-31 09:32:33 +01:00
luisramos0
660ce92c27
Merge spree api controllers and its decorators
2019-07-31 09:32:33 +01:00
luisramos0
c5bcef6ae4
Delete unused spree/api/line_items_controller_decorator.rb
2019-07-31 09:32:33 +01:00
luisramos0
d26a0b6b73
Bring from spree_api the api controllers that are overriden in OFN so that we can merge the original and the override afterwards
2019-07-31 09:32:33 +01:00
Pau Perez
c85d00fcb8
Remove N+1 while fetching distributors of OCs
...
What used to be done as
```sql
SELECT "order_cycles".* FROM "order_cycles"
WHERE (order_cycles.orders_open_at <= '2019-07-29 17:45:20.137294'
AND order_cycles.orders_close_at >= '2019-07-29 17:45:20.137333')
SELECT DISTINCT "enterprises".* FROM "enterprises"
INNER JOIN "exchanges" ON "enterprises"."id" = "exchanges"."receiver_id"
WHERE "exchanges"."order_cycle_id" = 1
AND "exchanges"."incoming" = 'f'
(...)
SELECT DISTINCT "enterprises".* FROM "enterprises"
INNER JOIN "exchanges" ON "enterprises"."id" = "exchanges"."receiver_id"
WHERE "exchanges"."order_cycle_id" = 4
AND "exchanges"."incoming" = 'f'
```
it became
```sql
SELECT "order_cycles".* FROM "order_cycles"
WHERE (order_cycles.orders_open_at <= '2019-07-29 17:45:20.137294'
AND order_cycles.orders_close_at >= '2019-07-29 17:45:20.137333')
SELECT "exchanges".* FROM "exchanges"
WHERE "exchanges"."incoming" = 'f'
AND "exchanges"."order_cycle_id" IN (1, 2, 3, 4)
SELECT "enterprises".* FROM "enterprises"
WHERE "enterprises"."id" IN (3, 4, 5, 6)
```
I haven't got any perf numbers yet but each of the N+1 queries took as
long as the single `enterprises` query on my dev machine.
This should have a noticeable perf impact since the changed method
belongs to the `BaseController` seems to be executed in all HTML
requests as it gets called by
```ruby
before_filter :warn_invalid_order_cycles, if: :html_request?
```
2019-07-29 20:02:47 +02:00
luisramos0
7e6259da31
Replace admin/variants/search rabl template with existing admin variant serializer with a few added attributes
...
This commit fixes a bug as the image of the variatn was not being rendered, we need to fetch the image of the product, not the image of the variant.
2019-07-23 21:37:45 +01:00
luisramos0
1681e8a572
Remove unused auth config
2019-07-08 14:06:01 +01:00
luisramos0
e897eb0439
Remove Spree::BaseController.class_eval, these methods are already in the application helper through spree::application_helpers
...
We can ignore the difference in spree_logout_path as spree.logout_path is the user_sessions#destroy route
2019-07-08 13:59:26 +01:00
luisramos0
0101dcdd93
Remove unused Spree::Dash from controllers brought from spree_auth_devise
2019-07-08 13:10:52 +01:00
luisramos0
9416f61fb3
Remove spree/checkout_controller.completion_route only used in spree/checkout_controller.update which is never used in OFN. Checkout update happpens in the checkout_controller.update
2019-07-08 13:04:38 +01:00
luisramos0
8efd69c3d1
Remove unnecessary checkout registration code, it's not used in OFN
2019-07-08 12:57:17 +01:00
luisramos0
dcbdfbb081
Fix rubocop issues in multiple files copied from spree_auth_devise, mostly hash rockets
2019-07-08 11:22:56 +01:00
luisramos0
92968c5efe
Merge spree/users_sessions_controller into spree/users_sessions from spree_auth_devise
2019-07-07 22:06:18 +01:00
luisramos0
c8ac64566f
Merge spree/users_controller_decorator into spree/user_controller
2019-07-07 22:04:04 +01:00
luisramos0
17448699f9
Bring devise initializer from spree_auth_devise and fix spree initializer details
2019-07-05 22:45:59 +01:00
luisramos0
a413f22e12
Remove unnecessary dependency to spree/users helper
2019-07-05 22:37:07 +01:00
luisramos0
fc0ffda8ec
Bring routes and controllers from spree_auth_devise
2019-07-05 15:08:42 +01:00
Luis Ramos
00841cb537
Merge pull request #3923 from luisramos0/prod_image_error
...
User friendly error when creating a product with an image in an unsupported format
2019-06-26 15:30:18 +01:00
Luis Ramos
57917a498b
Merge pull request #3946 from luisramos0/missing_translatiojns
...
Fix last missing translations covered by specs
2019-06-24 20:52:59 +01:00
Maikel
71f396a44f
Merge pull request #3896 from luisramos0/clear_unit_desc
...
Clear product.variants.unit_description if product.variant_unit is items
2019-06-21 15:00:06 +10:00
Maikel
5aea361d87
Merge pull request #3709 from luisramos0/2-0-prepare-4-rails-4
...
Start upgrade to Rails 4
2019-06-21 14:58:24 +10:00
luisramos0
eab6cc563b
Fix rubocop issues
2019-06-18 10:49:20 +01:00
luisramos0
02b9fca620
Remove unused spree checkout and spree cart routes
2019-06-18 10:49:19 +01:00
luisramos0
40f7d07e27
Remove unnecessary method from spree storecontroller and spree orderscontroller
2019-06-18 10:47:34 +01:00
luisramos0
c56486d7ae
Remove unnecessary methods from spree checkoutcontroller
2019-06-18 10:47:34 +01:00
luisramos0
56db90f49e
Remove unused checkout controller update action and order controller populate action
...
Additionally, remove routes of these actions as well as routes already defined in routes.rb (checkout and cart)
2019-06-18 10:47:34 +01:00
luisramos0
a8b4037885
Remove dependency to coupon code logic in checkoutcontroller, ofn doesnt have that feature
2019-06-18 10:47:34 +01:00
luisramos0
fc145d472d
Add home controller to ofn codebase from spree frontend
2019-06-18 10:47:34 +01:00
luisramos0
5037cce6f5
Add all the code missing from checkout, order and store controllers to ofn controllers
2019-06-18 10:47:34 +01:00
luisramos0
c399491314
Move spree frontend routes to ofn and transform decorators with class_eval to controller classes
2019-06-18 10:47:34 +01:00
