15609 Commits

Author	SHA1	Message	Date
filipefurtad0	57aa151ddd	Comments out default values from superadmin fields to bring the build back to green	2023-12-15 12:48:21 +00:00
Gaetan Craig-Riou	b8e24918fc	Merge pull request #11933 from openfoodfoundation/dependabot/bundler/rubocop-1.59.0 ... Bump rubocop from 1.58.0 to 1.59.0	2023-12-14 11:42:17 +11:00
Rachel Arnould	329ad1ddb2	Merge pull request #11874 from dacook/buu-success-message-11517 ... [BUU] Flash message redesign	2023-12-13 11:59:19 +01:00
David Cook	f99b0b19e7	Disable another OutputSafety warning ... This one is a little more concerning: what if a model error message includes the user-submitted value? But this is for the admin interface only, and I'm not sure if we have model error messages that do that. So it's probably fine (it's certainly been like this a long time already).	2023-12-13 14:21:27 +11:00
David Cook	0e95b3211b	Disable most OutputSafety warnings ... These all seem to require html_safe/raw, so we'll permit it. Some of the spree code is a bit strange and could probably be improved, but I think it's ok for now.	2023-12-13 14:19:19 +11:00
David Cook	dc9fd669a2	Remove unnecessary html_safe calls ... The tag generator methods should already be returning html_safe strings.	2023-12-13 14:11:02 +11:00
drummer83	dcba1dc5e9	Fix colour of the arrow when hovering the change package area in dashboard	2023-12-12 03:56:37 +01:00
drummer83	43effb8197	Fix missing translation of tooltip	2023-12-12 02:00:59 +01:00
Konrad	5aaaef63ac	Merge pull request #11911 from arunguleria/11599-checkout-page-title-changes ... Change page title on checkout pages	2023-12-10 20:53:56 +01:00
Konrad	cdb7312e95	Merge pull request #11798 from cillian/conditional-supplier-column-in-order-cycle-report ... Only display Supplier column in Order Cycle Report email if there is more than one supplier	2023-12-10 16:49:23 +01:00
Mohamed ABDELLANI	fea910f8b6	update the invoice number rendering	2023-12-08 13:33:36 +01:00
Mohamed ABDELLANI	41d5ca7861	update the invoice number calculation	2023-12-08 13:33:36 +01:00
Rachel Arnould	60656dedd4	Merge pull request #11901 from dacook/buu-bom-pagination-11608 ... Ensure pagination appears at bottom of table	2023-12-08 13:25:31 +01:00
Arun Guleria	d60216787b	11599 Remove whitespace trailing	2023-12-08 09:05:00 +05:30
Arun Guleria	4e408d404b	11599-Change page title on checkout pages	2023-12-08 09:05:00 +05:30
Konrad	7efc6f35b2	Merge pull request #11891 from bmd08a1/ft/search-by-customer-fullname-with-comma ... Allow searching orders by customers' full name with comma and full name reversed	2023-12-06 21:08:28 +01:00
Konrad	7c892b2e9e	Merge pull request #11889 from cillian/split-checkout-to-just-checkout ... Replace references to 'split checkout' with just 'checkout'	2023-12-06 20:42:26 +01:00
Konrad	dc4b6519dd	Merge pull request #11885 from dacook/flash-messages ... Fix mapping of flash messages on order cycle pages	2023-12-06 18:03:57 +01:00
David Cook	0f3a952fd0	Add translation for product cloned message ... A validation error shouldn't happen. If it does, it's an exception, not an error.	2023-12-06 15:13:20 +11:00
David Cook	0f46da07b2	Render flashes along with table ... It doesn't matter where the flash messages appear in the HTML (thanks to fixed positioning), so why not keep it simple and send them with the main response. preventDefault in case we are inside a form, so the button doesn't submit it.	2023-12-06 15:13:15 +11:00
David Cook	7fe2284d84	Refactor: Move ID out of partial ... Because it can only be used once. But the classname can be used each time the partial is included.	2023-12-06 14:18:58 +11:00
David Cook	9fa521917e	Allow nav menu items to wrap ... And thus avoid wrapping inside the li. This avoids the menu going off the edge of the screen.	2023-12-06 12:54:04 +11:00
David Cook	4de40e817f	Left-align navigation menu ... It looks really wierd when there's only a few items.	2023-12-06 12:54:04 +11:00
David Cook	3760cd93b9	Enable brower-default outlines on links ... This code was from Spree. Unless you have good focus/active styles for all links, the outline is very helpful for accessibility. Most websites these days add nice thick outlines, which might be worth considering in the future.	2023-12-06 12:54:01 +11:00
David Cook	32a4088386	Revert "#11067, remove messages to match with old UI UX" ... Now we support flash messages, we can show it! This reverts commit d8904099dd.	2023-12-06 10:12:18 +11:00
David Cook	fbf0afa15d	Auto dismiss success flashes only	2023-12-06 10:12:18 +11:00
David Cook	0b4013dd11	Add dismiss button to flashes ... And updating the secondary button style to ensure it's always white background	2023-12-06 10:12:17 +11:00
David Cook	20afe5b99c	Update style of flash messages ... They now hover near the bottom of the screen. I've created new variables so as not to mess with the existing use of color-success etc.	2023-12-06 10:12:17 +11:00
David Cook	44187658be	Copy messages styles for admin_v3	2023-12-06 10:12:17 +11:00
David Cook	f1a407c8a9	Remove unnecessary mixin, ... and use generic variable for shadows.	2023-12-06 10:12:17 +11:00
David Cook	54d61cd24d	Don't show flashes until everything else is done. ... Mario reported that it was showing before the loading spinner had gone. Technically the loading spinner doesn't hide until after the reflex is finished, but hopefully this is close enough.	2023-12-06 10:12:17 +11:00
David Cook	6dc04c458c	Show saving success message in flash ... I don't know if this is the best way to do it with SR, but it works..	2023-12-06 10:12:17 +11:00
David Cook	7d299affd3	Move hiding logic to stimulus controller ... This ensures morphed flashes hide like other flashes (eg in bulk order actions). I wanted to write a spec to prove it, but Capybara doesn't support mocking setTimeout and I didn't want to use sleep. I've made it optional because this controller is shared with the shop frontend ([supposedly](5ef34347a3), although angular seems to override it).	2023-12-06 10:11:19 +11:00
David Cook	127eaa44e5	Ensure loading message always shows ... Before, it was affixed near the top of the page and wasn't visible after scrolling down.	2023-12-06 10:11:19 +11:00
David Cook	c4e8d4318c	Ensure pagination appears at bottom of table ... I'm not sure what the problem was. It's obviously a hacky fix, but it works for now. We intend to rebuild this screen without Angular anyway.	2023-12-05 14:46:51 +11:00
David Cook	300998acb6	Merge pull request #11811 from dacook/buu-stock-levels-11062 ... [BUU] Stock level popout	2023-12-05 13:56:01 +11:00
David Cook	685a1955bc	Merge pull request #11872 from mkllnk/activate-background-reports ... Activate background report processing by default	2023-12-05 12:04:19 +11:00
Dung Bui	8a3aababa1	group specs into one it block, added fullname with comma reversed ransacker	2023-12-04 08:45:19 +07:00
Dung Bui	6206164c30	fix rubocop	2023-12-03 14:28:50 +07:00
Dung Bui	600226cb52	add fullname reversed search	2023-12-03 14:15:41 +07:00
Dung Bui	febda2ce12	add search by fullname with comma	2023-12-03 14:10:12 +07:00
Cillian O'Ruanaidh	b78258c505	Replace references to :split_checkout translation keys with :checkout in views, controllers, etc.	2023-12-01 12:37:13 +00:00
Cillian O'Ruanaidh	def027efb2	Replace references to split_checkout directory in views and specs	2023-12-01 11:32:55 +00:00
Cillian O'Ruanaidh	a63b9c2690	Rename SplitCheckoutController to CheckoutController	2023-12-01 11:18:56 +00:00
Cillian O'Ruanaidh	222c6d8ac5	Rename app/views/split_checkout directory to app/views/checkout	2023-12-01 11:12:00 +00:00
Filipe	f94d2c386c	Merge pull request #11863 from abdellani/11862-fix-product-shoud-not-be-priceless ... product should not be priceless	2023-12-01 10:43:30 +00:00
David Cook	a2b8fb5105	Show success messages as.. success.	2023-12-01 16:59:23 +11:00
Maikel Linke	bbe37e1392	Update ReportsController for background reports ... As it turns out, the background reports were missing a small feature to store user preferences. Yay specs!	2023-12-01 15:21:42 +11:00
David Cook	1cd9d9aafd	Organise controller translation keys with lazy loading	2023-12-01 14:20:30 +11:00
Gaetan Craig-Riou	082f78c772	Merge pull request #11873 from dacook/viewcomponent-sidecar ... ViewComponent sidecar	2023-12-01 10:44:13 +11:00