Maikel Linke
56667f6142
Simplify test setup with enabled features
...
If a feature is activated or not depends on the database which is reset
after each test scenario. So enabling a feature doesn't leak into other
scenarios.
Just enabling the feature is less code and more realistic than mocking a
method call.
2022-10-27 15:32:05 +11:00
Maikel Linke
f9246f1917
Remove unused/broken feature toggle helper
2022-10-27 15:25:33 +11:00
Maikel Linke
36c44a5487
Allow FeatureToggleConstraint to run w/o warden
...
Routing specs and controller specs don't set warden on the request
environment. While we could try to re-implement Warden/Devise logic
here, it's much easier to not rely on the environment to be set.
While I'm usually opposed to changing production code to make testing
easier, it does avoid a lot of complication in this case. And maybe it
would be handy in other circumstances to have a more defensive approach
to checking the logged in user.
2022-10-27 15:07:04 +11:00
Maikel
54b0554bb4
Merge pull request #9831 from filipefurtad0/fix_flaky_spec_bom_9811
...
Brings back rspec_retry; Creates helper method for flaky spec #9811
2022-10-27 09:52:43 +11:00
Rachel Arnould
2652bc086a
Merge pull request #9755 from cillian/order-cycle-payment-methods
...
Let people choose which payment methods are available to customers on order cycles
2022-10-26 20:10:34 +02:00
filipefurtad0
b53faceebb
Retries improved but still flaky examples
2022-10-26 13:26:21 +01:00
filipefurtad0
aebf84b53f
Brings back rspec-retry gem and configs
2022-10-26 13:26:21 +01:00
Jean-Baptiste Bellet
edb2645af1
Add a country to test db and modify one spec
...
Check that businness address changes are ok
Test with another county since only one country and one state couldn't spot the fact that when changing country it needs to change also states selector
2022-10-26 11:21:44 +02:00
filipefurtad0
14955ac8ca
Minor changes to improve flakyness
2022-10-25 17:39:10 +01:00
filipefurtad0
3447959a06
Adds click_on_select2 helper
2022-10-25 13:32:29 +01:00
Mohamed ABDELLANI
41440af533
test if product's variant is duplicated properly
2022-10-25 11:28:16 +01:00
Mohamed ABDELLANI
826b1e95ef
add a product variant.
2022-10-25 11:27:51 +01:00
Mohamed ABDELLANI
6cabbee1a2
rename new_variant double to new_master_variant
2022-10-25 11:27:14 +01:00
Mohamed ABDELLANI
11bc5c775c
rename the variant double to master_variant
2022-10-25 11:26:43 +01:00
Konrad
d12e99e363
Merge pull request #9808 from abdellani/sort_items_by_product_name_in_ocstd_report
...
add sort by product name to order_cycle_supplier_totals_by_distributo…
2022-10-25 10:34:22 +02:00
Jean-Baptiste Bellet
ede38a417f
Respect rubocop Metrics/AbcSize by extracting a method
2022-10-25 10:22:35 +02:00
Maikel Linke
7081e712e8
Flag style issue on todo list for later
...
The code needs some bigger refactoring to avoid this style issue.
2022-10-25 10:09:26 +02:00
Nihal Mohammed
5c0f3a2d4b
Add weight, height, width, depth fields to pack by customer reports
...
+ update specs by adding dimensions fields into reports specs
2022-10-25 10:09:26 +02:00
Maikel
55ef4dfe0d
Merge pull request #8809 from Matt-Yorkley/dead-code-variants-check
...
Remove dead code: Product#variants?
2022-10-25 10:49:01 +11:00
Konrad
4a7ac45dba
Merge pull request #9830 from jibees/9821-remove-report_inverse_columns_logic-feature-toggle
...
Remove `report_inverse_columns_logic` feature toggle
2022-10-25 00:23:31 +02:00
Konrad
84bf38ce4d
Merge pull request #9791 from vsmay98/8250-fix-snail-for-all-enterprise-fee
...
Fix snail issue for all enterprise fees
2022-10-24 21:49:45 +02:00
saunmanoj888
490c5afc59
Mock bigDecimal methods in specs
2022-10-25 00:05:31 +05:30
filipefurtad0
367f77f477
Replaces select2_select helper for find/click
2022-10-24 17:57:10 +01:00
Rachel Arnould
3c9b7a10f4
Merge pull request #9058 from Matt-Yorkley/oidc-redux
...
Add OIDC authentication for Les Communs
2022-10-24 13:18:36 +02:00
Jean-Baptiste Bellet
6dec80aaaf
Links only on right side
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
edc667a336
By default, some columns are hidden.
2022-10-24 11:12:22 +02:00
Jean-Baptiste Bellet
02787e668f
Remove report_inverse_columns_logic feature toggle
...
Co-Authored-By: Maikel <maikel@email.org.au >
2022-10-24 11:12:22 +02:00
Mohamed ABDELLANI
da9a4803ff
add it "lists products sorted by name" test
2022-10-24 09:01:42 +01:00
Mohamed ABDELLANI
732ebd8457
fix the expected table size in "generates the report" test
2022-10-24 09:01:42 +01:00
Mohamed ABDELLANI
39e567d386
set line_items_count to 3
2022-10-24 09:01:42 +01:00
jibees
ee70ab8adb
Merge pull request #9847 from mkllnk/stable-orders_and_fulfillment_spec
...
Expect report rows for same product in random order
2022-10-24 09:57:06 +02:00
Maikel Linke
167ce0e53c
Expect report rows in random order
...
It's not deterministic which variant is shown first and therefore this
spec would fail from time to time.
2022-10-24 15:40:35 +11:00
Maikel
e873771f18
Merge pull request #9822 from filipefurtad0/redis_CannotConnectError
...
Extracts routing outside it block
2022-10-24 13:33:01 +11:00
Maikel
627b8af37b
Merge pull request #9828 from mkllnk/authorize-api-key
...
Prevent users from changing API keys for others
2022-10-24 11:22:35 +11:00
Cillian O'Ruanaidh
eb72ec8e13
An order cycle isn't ready for checkout if a tag rule means no payment/shipping methods are available to the customer
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
62cd507fb9
Stub Spree::Config.stripe_connect_enabled instead of changing it before and back after tests
...
It's less code and sometimes there can be issues when config cache values are changed.
Co-authored-by: Maikel <maikel@email.org.au >
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
2c14aecf4f
Extract a OrderCycleClone service
...
Before it was giving a Rubocop error, probably not a bad idea anyway.
2022-10-21 17:21:31 +01:00
Cillian O'Ruanaidh
4e6d64c0a1
Let people choose which payment methods are available to customers on order cycles
2022-10-21 17:21:31 +01:00
saunmanoj888
ee8454bd2c
Use js-big-decimal package for calculation
2022-10-21 21:30:00 +05:30
jibees
3a68e237de
Merge pull request #9772 from mkllnk/revenue-report-for-au
...
Add more fields to revenue report as used by Aus
2022-10-20 23:10:17 +02:00
jibees
48e18b016a
Merge pull request #9756 from vsmay98/8249-fix-snail-for-all-shipping-method-fee
...
Fix snail issue for all shipping method fees
2022-10-20 17:31:24 +02:00
jibees
da851079f4
Merge pull request #9776 from abdellani/product-creation-minor-improvements
...
Product creation minor improvements
2022-10-20 17:30:47 +02:00
jibees
1d265d19ce
Merge pull request #8872 from Matt-Yorkley/bugsnag-data
...
Update Bugsnag error data
2022-10-20 17:30:14 +02:00
jibees
fdc362cb44
Merge pull request #9806 from mkllnk/feature-constraint
...
Generalise feature toggle constraint
2022-10-20 17:27:46 +02:00
Maikel Linke
fc79612f26
Prevent users from changing API keys for others
...
It was checking for the permission to create a user which everyone can
do. Now it's checking for updating that particular user and doesn't
allow generating new keys for other users any more.
This would have been an inconvenience but not a big security issue
because you can't view the key of another user.
2022-10-20 17:56:46 +11:00
Vishal Jain
de28027623
add system spec
2022-10-20 12:15:22 +05:30
saunmanoj888
b40cd579bc
Fix spec failure
2022-10-19 23:18:22 +05:30
saunmanoj888
8e45b758ba
Fix unit value UI issue
2022-10-19 22:59:28 +05:30
filipefurtad0
c4de247dd9
Clarifies contexts, cleans-up spec DRY
2022-10-19 16:56:04 +01:00
filipefurtad0
a244b34627
Extracts routing to context (DRY); creates context for separate it block
2022-10-19 11:15:15 +01:00
