Pau Perez
|
c61fc25e9f
|
Disable Knapsack only to Github workflow
|
2021-03-09 16:19:27 +01:00 |
|
Pau Perez
|
1f0b597120
|
Run tests in a Github workflow
Things to be aware of:
* Allows manually triggering GH workflow. See:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch.
* Installs versions in the yarn.lock and prevents updates to the yarn.lock.
* Yarn and npm come pre-installed in Github's runner VMs. See
https://docs.github.com/en/actions/guides/building-and-testing-nodejs#installing-dependencies.
* We use the latest LTS Node version so it can read ES6 syntax `let`.
* Karma tests require RAILS_ENV. In lib/tasks/karma.rake we default to
`test` so that means someone else is setting `RAILS_ENV` before that.
We'll need to find out who so we can avoid this.
* We run the CI build only on pushes to any branch. This the
redundancy of all build jobs due to the `push` and `pull_request`
events. I still don't see what's the exact difference between these
two events. See:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows.
|
2021-03-09 16:18:04 +01:00 |
|
Pau Perez
|
e4c0fa5043
|
Add Github CI build workflow
based on
https://docs.github.com/en/actions/guides/building-and-testing-ruby#starting-with-the-ruby-workflow-template.
Things worth mentioning:
* ruby/setup-ruby reads `.ruby-version` by default. See:
https://github.com/ruby/setup-ruby#supported-version-syntax
* I chose to run on ubuntu-18.04 because that's what we use in
production. This should reduce potential "it runs on machine but fails
in CI" due to different system libraries versions and such.
We're temporarily running only `spec/queries/` specs because we want it
to finish quickly as we iterate on its configuration.
|
2021-02-17 12:37:11 +01:00 |
|
Pau Perez
|
8c1e222788
|
Upgrade Ruby and Ubuntu to latest in GH action
It was asked for in
https://github.com/openfoodfoundation/openfoodnetwork/pull/6163/ to use
the latest stable Ruby version. It's also better to use Ubuntu's latest
as well.
|
2020-11-30 09:11:41 +01:00 |
|
Luis Ramos
|
dbd41e9d31
|
Use ruby 2.4 as github actions do not support ruby 2.3.
|
2020-10-13 10:31:26 +01:00 |
|
Luis Ramos
|
87327dcf57
|
Add brakeman config
|
2020-10-13 10:31:13 +01:00 |
|