Maikel Linke
94b75540e4
Replace Timecop with Rails' time helpers
...
Rails 4.1 added time helpers but we never bothered using them. But now
I'm getting rid of the Timecop dependency and use standard helpers.
Beware though that the new helpers always freeze time. When you travel
to a certain date then the clock stops ticking while Timecop maintained
the passing of time.
The freezing of time could cause problems if you are trying to enforce a
timeout. But all current specs don't seem affected.
In most cases, the freezing will make it easier to avoid flaky specs.
2025-08-22 16:57:04 +10:00
Gaetan Craig-Riou
7450f8a530
Fix spec, enable inventory when needed
2025-07-09 13:43:18 +10:00
Gaetan Craig-Riou
8829f6ad03
Only scope variant when inventory is enabled
2025-07-09 11:35:26 +10:00
Ahmed Ejaz
ade35f2fa2
Fixes specs and update code respectively
2025-06-21 16:19:31 +05:00
cyrillefr
6a44c45699
Style Metrics/ModuleLength in spec file
2025-06-17 14:37:35 +02:00
cyrillefr
bb0a6b7f8d
Style Metrics/ModuleLength in spec file
2025-06-17 14:33:15 +02:00
cyrillefr
abaa7c35a7
Style Metrics/ModuleLength in spec file
2025-06-17 14:18:42 +02:00
cyrillefr
97c4cd382b
Style Metrics/ModuleLength in spec file
2025-06-17 14:05:21 +02:00
cyrillefr
089caa228f
Style Metrics/ModuleLength in spec file
2025-06-17 13:48:22 +02:00
Ahmed Ejaz
20146a8e11
update respective specs
2025-04-13 21:35:55 +05:00
Filipe
c3cb51441f
Merge pull request #13192 from dacook/display-customer-contacts-in-reports-13129
...
[FF] Add option to display customer contact details to suppliers in reports
2025-04-08 20:34:44 +01:00
Filipe
a7c77dc894
Merge pull request #13084 from abdulazizali77/bugfix/11529-report-by-enterprise-fee-from-lineitems
...
Fetch variant enterprise fees from order lineitems adjustments #11529
2025-04-01 16:13:51 +01:00
David Cook
e02ef08b06
Consolidate translations for hidden field
...
The string '< Hidden >' was agreed on as a good default, so we will use the hidden_field key.
I also moved the definition in en.yml up to the more general area at the start of admin.reports section (before it was hidden between report-specific keys.
2025-03-31 16:24:07 +11:00
David Cook
19b6cbcc9b
Packing reports: Display phone numbers to suppliers
2025-03-31 16:16:27 +11:00
David Cook
f40a00dde3
Expand spec to cover existing behaviour
...
And use let to avoid extra db query
2025-03-31 16:16:27 +11:00
David Cook
47b6888fe6
Display customer emails & phone numbers to suppliers
...
when permitted.
The MaskDataService is used by the report framework, so this should affect all reports. It would be nice to test all reports, but I figured it wasn't worth it (already we only test one report for masking names).
2025-03-31 16:16:27 +11:00
cyrillefr
9bb617d748
Fixes some rubocop linting offenses - part III
2025-03-06 23:42:53 +01:00
Ahmed Ejaz
434434f451
13127 - add shipment state in the oc customer total report
2025-03-04 04:09:04 +05:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
filipefurtad0
77b857a30d
Adds test case when the hub is owner of the fee
2025-02-12 21:22:19 -06:00
filipefurtad0
48f5df349a
Adds test case on included tax
2025-02-12 21:22:19 -06:00
filipefurtad0
85ec771e27
Adds coverage on supplier option to charge tax
2025-02-12 21:22:19 -06:00
Ahmed Ejaz
e8b185256e
13013: add specs
2025-01-31 17:34:34 +05:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Abdul Aziz Ali
a15cb58ab5
fetch variant enterprise fees from order lineitems adjustments #11529
2025-01-21 06:53:42 +08:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
Maikel Linke
c1198c8e1f
UNSAFE Style Rails/CompactBlank
2025-01-10 09:14:34 +11:00
Konrad
8e0c0392d9
Merge pull request #12991 from murjax/remove-sku-11973
...
Remove product SKU from product pages and report
2025-01-07 21:14:39 +01:00
Maikel Linke
5db8cb452e
Leverage Rails' caching when checking for admin
...
The privileges of a user should never change within a request
life cycle. The `spree_roles` association is very small, between 0 and 2
items are quickly searched in memory without the need of additional
database queries.
From memory, I've seen a lot of spree_roles queries in log files per
request. This should reduce it to one.
2024-12-19 10:12:31 +11:00
Ahmed Ejaz
c331d57cdb
13008: add tax category in all products report
2024-12-04 03:36:42 +05:00
Gaetan Craig-Riou
12cf62c2ff
Refactor, add OrderManagement::Order::Updater#update_voucher
...
Move the logic to update a voucher and associated order to
`OrderManagement`
2024-11-28 13:35:01 +01:00
Filipe
a493d70f5c
Merge pull request #12950 from macanudo527/unlock_bigdecimal
...
Fix rounding issues by upgrading decimal maths library
2024-11-25 19:18:19 -06:00
Ryan Murphy
bab7756017
Remove product SKU from product pages and report
2024-11-20 19:12:29 -05:00
Filipe
22f3afc7f7
Merge pull request #12930 from chahmedejaz/task/12878-add-variant-name-in-od-report
...
Report Orders and Distributors should display variant
2024-11-20 12:23:36 -06:00
Ahmed Ejaz
6b3b29ac39
12776: refactor spec
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
9bcdac8f30
12776: rename vat to tax
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
e2d999da8d
12776: use EnterpriseFeeCalculator in specs
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
298c0e8d7f
fix reported issues:
...
- wrong enterprise fees
- always 0 tax on fees
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
ec0d2d346b
use to_date for locale based formating
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
654263a823
add systems spec
2024-11-15 11:09:56 +01:00
Ahmed Ejaz
4349e42a84
12776: add specs
2024-11-15 11:09:56 +01:00
Neal Chambers
7a5074cc90
Refactor option_value_value_unit_scaled for correct unit value scaling and update sales tax report spec for clarity
2024-11-13 16:28:18 +09:00
Neal Chambers
3302f0e78d
Improve Precision of Spec for New Version of BigDecimal
2024-11-13 16:28:18 +09:00
Filipe
7b677796c1
Merge pull request #12797 from rioug/report-fix-supplier
...
Fix supplier loading on Product & inventory report
2024-11-10 18:03:20 -06:00
Gaetan Craig-Riou
fa986f3fc2
Fix orders and fulfillment report
2024-10-14 15:01:18 +11:00
Ahmed Ejaz
641b7beee3
add specs
2024-10-12 04:47:45 +05:00
David Cook
1078e7cd36
Update specs
...
The key here is the enterprise_relationship. This is required for the supplier to have permission to see the orders.
Curiously, the unit test still passes. All will be revealed in the next commit..
2024-09-17 12:55:22 +10:00
Ahmed Ejaz
983addff0d
12777: use unit_to_display method for variant unit
...
- This method prioritize display_as and after that considers options_text
2024-09-05 10:49:45 +02:00
filipefurtad0
cc3181c820
Adds unit spec regression test
2024-09-04 16:51:33 -06:00
Gaetan Craig-Riou
ef6e37e7ca
Fix suppliers_of_products_distributed_by
...
Plus spec
Left over from product refactor, it was missed because it's not covered
by unit or integration test
2024-08-21 13:05:34 +10:00
