Gaetan Craig-Riou
c2c2a9503c
Rename stimulus controller based on the new shorter naming
2025-09-24 10:47:59 +10:00
Gaetan Craig-Riou
bc1823e276
Add http error handling
...
Because we are using fetch here to manually request turbo stream we have
to handle errors ourselves.
2025-09-24 10:46:37 +10:00
Gaetan Craig-Riou
01d5830480
Move turbo http error handling to its own file
2025-09-24 10:46:37 +10:00
Gaetan Craig-Riou
ab65b2d745
Per review, fix various syntax/misspell
2025-09-24 10:46:37 +10:00
Gaetan Craig-Riou
3862e0206c
Limit to only one tag per tag rule
2025-09-24 10:46:34 +10:00
Gaetan Craig-Riou
3a0722f39c
Remove tag related methods
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
9d9f7e8717
Remove Angularjs files related to tag rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
0cf244b211
Document variant filtering rule behavior
...
Add test to conver scenario where we have conficting rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
646ba18b8a
Fix bug, load tag rule types when update errors
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
8bd631fbb7
Clean up tag rule form component template
...
Consolidate everything in one template and move visibility options to
the component.
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
5c3acf38d7
Clean up stimulus usage
...
Use value and parameter when possible instead of relying on hidden
input
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
afdc40d230
Move helper function to component
...
It's only used in the component so there is no need to keep it as an
helper.
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
953122b6f6
Fix adding new rule
...
We separate the default tag rules and the various tag rule groups by an
index of 1000. This is so the previous group does not overlap with the
current group. Rails will managed the non continusly numbered
tag_rule_attributes param just fine. It saves us from having to manage
the numbering of tag_rule_attributes in javascript
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
75325e2935
Consolidate modal to add rule into a component
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
7e48007d09
Add new tag group and add rule to tag group
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
50ab0a494c
Move tag rule group form to a component
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
d3ef744daf
Display existing grouped tag rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
ccdd12bf59
Small improvment
...
- add value for preferred customer tags
- allow passing html options to preferred customer tags hidden field
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
b66b033999
Small improvement
...
- allow passing html options to the hidden field with the tags values,
to be used to add stimulus directive
- dispatch an input event when the hidden field with tags value gets
updated, it allows stimulus controller (or javascript) to react to
update
2025-09-24 10:40:34 +10:00
Gaetan Craig-Riou
35d37639af
Refactor tag rule filter input
...
Consolidated four partials into one
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
6790cad089
Add deleting tag rule
...
TagRuleController is now a subclass of Spree::Admin::BaseController
because Admin::ResourceController did not play well with turbo_stream.
And to be honest we did not need all the functionality provided by the
ResourceController
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
7087d1b290
Add default tag rule
...
I tried to leverage turbo as much as possible
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
8f0cdf8722
Move individual tag rule form to a component
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
25f6db09a5
TagListInputComponent removed dependency on the form
...
This allows us to use the component in a context where there is no form
object defined.
2025-09-24 10:38:47 +10:00
Gaetan Craig-Riou
11006c3a60
Display default rule
2025-09-24 10:36:21 +10:00
Gaetan Craig-Riou
b2a3715a8b
Fix bug
...
Don't add a leading coma when the tag list is empty
2025-09-24 10:36:21 +10:00
Maikel
9e746d1b40
Merge pull request #13531 from rioug/better-stimulus-name-for-component
...
Load component stimulus controller with a shorter name
2025-09-17 17:10:37 +10:00
Filipe
273f78b214
Merge pull request #13530 from mkllnk/hub-address-feature
...
Remove retired hub_address feature
2025-09-16 17:23:42 +01:00
Filipe
bfcadfd7c0
Merge pull request #13404 from cyrillefr/UnsavedChangesMustAppearOnRemovingSingleTagFromOrderCycle
...
Fixes Save button does not enable when removing only tag in OC
2025-09-15 13:27:26 +01:00
Gaetan Craig-Riou
1c7fbd1d2d
Rename vertical ellipsis menu component files
...
There is no need to have a different name scheme to shorten stimulus
controller name. It's now inline with the other components
2025-09-10 15:27:56 +10:00
Gaetan Craig-Riou
8042dac74f
Fix stimulus controller name to use the shorter version
2025-09-10 15:10:10 +10:00
Gaetan Craig-Riou
ad1ce00223
Generate a better stimulus name for component controller
...
Using the helper `definitionsFromContext` generate quite long name for
stimulus controller in component, ie :
`tag-list-input-component--tag-list-input`.
This custom loader will generate much more readable name, ie L
`tag-list-input`. It's expecting the following pattern :
ofn_component/ofn_controller.js and will fall back to the default
of replacing "_" by "- and "/" by "--" for controller not matching
the pattern.
2025-09-10 15:03:31 +10:00
Maikel Linke
d916ed2c96
Remove retired hub_address feature
2025-09-10 09:59:47 +10:00
Cillian O'Ruanaidh
6f7a547e15
Add a :link_to_or_disabled helper method
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
c057c72321
Replace ofn-page-alert angular directive
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
7a3b4d394b
Replace inline-alert angular directive
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
32e3fc0175
Replace disable-dynamically angular directive
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
23c9410a25
Replace darker-background angular directive
2025-09-05 09:38:20 +01:00
Filipe
ddb8b2d08f
Merge pull request #13496 from dacook/fix-link
...
Fix link to enterprise payment methods tab
2025-08-28 19:17:37 +01:00
Filipe
42c9ee033a
Merge pull request #13503 from AndreyUsyaev/usandy/fix-i18n-sells-options
...
Fix missed I18n translations for enterprises sells options
2025-08-28 18:50:07 +01:00
Filipe
b0c7e29b0d
Merge pull request #13468 from mkllnk/rails-config-updates
...
Add Rails 7.0 and 7.1 framework defaults
2025-08-28 11:44:44 +01:00
Andrey Usyaev
3d7799df19
Fix code review remarks
2025-08-27 13:21:44 +03:00
Andrey Usyaev
5f02d88a86
Fix missed I18n translations for enterprises sells options
2025-08-27 13:21:44 +03:00
Maikel
bdae8e6478
Merge pull request #13475 from mkllnk/dfc-sib-tokens
...
Accept tokens from Startin'Blox OIDC server
2025-08-27 14:55:30 +10:00
David Cook
646d538a3d
Fix broken link
...
This link would go to the enterprise edit screen, but didn't successfully select the payment methods panel.
Ideally, the spec would try to follow the link and verify that you can see the Connect with Stripe button. But it opens the link in a new tab and I'm not sure how to test that.
2025-08-20 11:54:47 +10:00
Filipe
ae477b7e52
Merge pull request #13455 from kirst-n/13366-only-load-necessary-flatpickr
...
Optimise loading of language-specific date pickers
2025-08-14 23:24:59 +01:00
Filipe
0e191e5fca
Merge pull request #13459 from rioug/13454-fix-redeemeing-voucher-when-using-paypal
...
[VINE] Redeem voucher before redirecting to payment url
2025-08-14 16:30:22 +01:00
Maikel Linke
b16e541a81
Show DFC catalog to authorised platform
2025-08-13 15:02:09 +10:00
Maikel Linke
05b00f16ad
Move config option to a better place
2025-08-12 20:24:16 +10:00
Kirst
b8ad428b5d
Load only specified flatpickr locale
...
Dynamically import only the requested flatpickr locale.
English locale is bundled by default, so passing null triggers flatpickr's built-in English fallback without an explicit import.
2025-08-11 20:28:47 +10:00